227792 - building without crypto fails with missing "nsIPK11TokenDB.h" and "nsIPK11Token.h" files

Status: RESOLVED INVALID

(Firefox Build System :: General, defect)

Description

[Henrik Gemal]

I'm trying to build firebird without crypto enabled and got this:

c:/mozilla/mozilla/toolkit/components/passwordmgr/base/nsPasswordManager.cpp:72:
28: nsIPK11TokenDB.h: No such file or directory
c:/mozilla/mozilla/toolkit/components/passwordmgr/base/nsPasswordManager.cpp:73:
26: nsIPK11Token.h: No such file or directory
c:/mozilla/mozilla/toolkit/components/passwordmgr/base/nsPasswordManager.cpp: In

   static member function `static void nsPasswordManager::EnsureDecoderRing()':
c:/mozilla/mozilla/toolkit/components/passwordmgr/base/nsPasswordManager.cpp:155
9: `
   nsIPK11TokenDB' undeclared (first use this function)
c:/mozilla/mozilla/toolkit/components/passwordmgr/base/nsPasswordManager.cpp:155
9: (Each
   undeclared identifier is reported only once for each function it appears
   in.)
c:/mozilla/mozilla/toolkit/components/passwordmgr/base/nsPasswordManager.cpp:155
9: template
   argument 1 is invalid
c:/mozilla/mozilla/toolkit/components/passwordmgr/base/nsPasswordManager.cpp:155
9: warning: ISO
   C++ forbids declaration of `tokenDB' with no type
c:/mozilla/mozilla/toolkit/components/passwordmgr/base/nsPasswordManager.cpp:155
9: `
   NS_PK11TOKENDB_CONTRACTID' undeclared (first use this function)
c:/mozilla/mozilla/toolkit/components/passwordmgr/base/nsPasswordManager.cpp:156
3: `
   nsIPK11Token' undeclared (first use this function)
c:/mozilla/mozilla/toolkit/components/passwordmgr/base/nsPasswordManager.cpp:156
3: template
   argument 1 is invalid
c:/mozilla/mozilla/toolkit/components/passwordmgr/base/nsPasswordManager.cpp:156
3: warning: ISO
   C++ forbids declaration of `token' with no type
c:/mozilla/mozilla/toolkit/components/passwordmgr/base/nsPasswordManager.cpp:156
4: base
   operand of `->' is not a pointer
c:/mozilla/mozilla/toolkit/components/passwordmgr/base/nsPasswordManager.cpp:156
4: no
   matching function for call to `getter_AddRefs(int&)'
c:/mozilla/mozilla/toolkit/components/passwordmgr/base/nsPasswordManager.cpp:156
7: base
   operand of `->' is not a pointer
c:/mozilla/mozilla/toolkit/components/passwordmgr/base/nsPasswordManager.cpp:157
0: base
   operand of `->' is not a pointer
make[6]: *** [nsPasswordManager.o] Error 1
make[6]: Leaving directory `/cygdrive/c/mozilla/mozilla/toolkit/components/passw
ordmgr/base'
make[5]: *** [libs] Error 2
make[5]: Leaving directory `/cygdrive/c/mozilla/mozilla/toolkit/components/passw
ordmgr'
make[4]: *** [libs] Error 2
make[4]: Leaving directory `/cygdrive/c/mozilla/mozilla/toolkit/components'
make[3]: *** [libs] Error 2
make[3]: Leaving directory `/cygdrive/c/mozilla/mozilla/toolkit'
make[2]: *** [tier_50] Error 2
make[2]: Leaving directory `/cygdrive/c/mozilla/mozilla'
make[1]: *** [default] Error 2
make[1]: Leaving directory `/cygdrive/c/mozilla/mozilla'
make: *** [build] Error 2

Comment 1

[Paul Pietromonaco]

Here's a little extra data about this bug if you're having trouble reproducing 
it.  I've found that this bug seems to be related to having these two options 
in your mozconfig:

ac_add_options --disable-shared
ac_add_options --enable-static

If you build Firefox with the default settings, except for removing crypto 
support, it should build okay.

Comment 2

[Paul Pietromonaco]

Okay - I don't know what possessed me yesterday.  Please ignore my previous
comment.  I can't build Firefox without enabling crypto.  My guess is that I
forgot to clear out a crypto module in my build tree yesterday - so even though
I had crypto disabled in the mozconfig, the build found a missing module and
compiled.

This bug is really bad for cross-compiling.  Since you have to disable crypto to
cross-compile ( see http://www.mozilla.org/build/cross-compiling.html and
http://bugzilla.mozilla.org/show_bug.cgi?id=104541 ), this bug prevents me from
creating builds cross platform. (e.g. intel to mips).  Firebird 0.7 seemed to
cross-compile okay.

Comment 3

[Axel Hecht]

Note that this is a blocker for anybody with the VC standard edition, too.

Comment 4

[David G King]

I noticed that this fails on my Firefox build under Linux (Fedora Core 3). May
be due to the new build config options....

Comment 5

[Ryan VanderMeulen [:RyanVM]]

If the two files don't even exist in the tree anymore, would there be any harm
in removing the two entries from nsPasswordManager.cpp?

Comment 6

[Andrew Schultz]

> If the two files don't even exist in the tree anymore

they're in the tree... the build is just configured without crypto (so they're
not available)

Comment 7

[Benjamin Smedberg]

For legal reasons, I think we should try to address this for 1.1.

Comment 8

[Asa Dotzler [:asa]]

If we can get this, that would be great. If someone who has the cycles can
accept this and come up with a patch, we'll certainly consider it for inclusion
but not going to block on it.

Comment 9

[Ryan VanderMeulen [:RyanVM]]

Maybe I can take a stab at this one. Can someone who knows the source tree 
give me a quick rundown of what would have to be done?

Comment 10

[Reed Loden [:reed]]

What's the status of this bug? Is it still valid with trunk and/or branch?

Comment 11

[Andrew Schultz]

This still valid.  The hard part here is that the toolkit password manager (unlike wallet) does not have a fallback of just obscuring the passwords (although it happily encrypts data with a blank password, which seems worse).  So the possible solutions are:

1. Add a couple small #ifdef blocks and successfully build a non-functional password manager.
2. Don't build password manager if crypto is disabled.
3. Add obscuring to the password manager along with UI changes.

1 is really easy, 2 is a bit harder (various things expect password manager to exist), and 3 is a biger job.  If 1 or 2 would be acceptable, I'll work on fixing this.

Comment 12

[cls]

*** Bug 319217 has been marked as a duplicate of this bug. ***

Comment 13

[:Cykesiopka]

You can't build without crypto since the changes in Bug 837862 landed, so this is now invalid.