230693 - Missing reload within view source window

Status: VERIFIED FIXED

(Toolkit :: View Source, enhancement)

Description

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Starting page reload inside view-source window doesn't work. If I have opened
the source window within a new tab I can reload with shift+ctrl+r only. Ctrl+r
seams to load the data from cache. If I have a separate window I can't start any
reload with this two combinations.

Always fixed for Seamonkey (Bug 85908) but missing for Firebird.

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+2]]

-> QA

Comment 2

[Steffen Wilberg]

-> view source.

Comment 3

[José Jeria]

*** Bug 256229 has been marked as a duplicate of this bug. ***

Comment 4

[Jo Hermans]

*** Bug 258389 has been marked as a duplicate of this bug. ***

Comment 5

[Nickolay_Ponomarev]

*** Bug 263108 has been marked as a duplicate of this bug. ***

Comment 6

[Christian Schmidt]

Attachment: Add Reload to View menu and hook up shortcut keys

This adds four different shortcut keys to the reload function: Ctrl+R,
Ctrl+Shift+R, F5 and Ctrl+F5.

In a regular browser Ctrl+R and F5 do a reload from cache and Ctrl+Shift+R and
Ctrl+F5 do a force reload from network. In view source reloading from cache
doesn't make much sense (or am I missing something), so I hooked up all four
keys to force reload.

I added Reload to the View menu. I don't know if this bloats the UI too much.

I renamed BrowserReload() to ViewSourceReload(). The former name was chosen in
xpfe so that the function could be called by an overlay used by both view
source and the regular browser, but there doesn't seem to be such an overlay in
toolkit.

Comment 7

[Christian Schmidt]

Attachment: New patch

Comment 8

[Mike Connor [:mconnor]]

Comment on attachment 180266 [details] [diff] [review]
New patch

diff -up8 is a goodness.  Regardless of that, r=me.

Comment 9

[Christian Schmidt]

Thanks for the review. Could you (or somebody else) check this in for me?

Comment 10

[Christian Schmidt]

Mike, could you help me getting this checked in? I don't have CVS access myself.
Thanks :-)

Comment 11

[José Jeria]

(In reply to comment #10)
> Mike, could you help me getting this checked in? I don't have CVS access myself.

I am not sure that mconnor got that message, since he is not cc:ed

Comment 12

[Christian Schmidt]

Mike, could you help me getting this checked in? I don't have CVS access myself.
Thanks :-)

Comment 13

[Mike Shaver (:shaver emeritus)]

Comment on attachment 180266 [details] [diff] [review]
New patch

a=shaver

Comment 14

[Asaf Romano (gone)]

Checking in toolkit/locales/en-US/chrome/global/viewSource.dtd;
/cvsroot/mozilla/toolkit/locales/en-US/chrome/global/viewSource.dtd,v  <-- 
viewSource.dtd
new revision: 1.4; previous revision: 1.3
done
Checking in toolkit/components/viewsource/content/viewSource.js;
/cvsroot/mozilla/toolkit/components/viewsource/content/viewSource.js,v  <-- 
viewSource.js
new revision: 1.13; previous revision: 1.12
done
Checking in toolkit/components/viewsource/content/viewSource.xul;
/cvsroot/mozilla/toolkit/components/viewsource/content/viewSource.xul,v  <-- 
viewSource.xul
new revision: 1.22; previous revision: 1.21
done

Comment 15

[Henrik Skupin [:whimboo][⌚️UTC+2]]

There are still some shortcut issues to fix for that part. Therefor I filed bug
299683.

v.