232403 - Need a Close button for <dialog>

Status: NEW

(Core :: XUL, enhancement)

Description

[Daniel Wang]

follow up on bug 70750

We need a Close option for <dialog buttons>. Right now we only have Ok, Cancel,
Help, and More Info. In Image Manager and Cookie Manager, we use a OK button and
re-label it via JavaScript (see
http://lxr.mozilla.org/mozilla/source/extensions/wallet/cookieviewer/resources/content/CookieViewer.js#84)

There should be a more elegant way of putting a Close button

see also discussion in bug 160694

Comment 1

[Daniel Wang]

*** Bug 232404 has been marked as a duplicate of this bug. ***

Comment 2

[Jo Hermans]

Note to discourage anyone, but be careful when constructing close buttons inside
the dialog window (cookies manager, image manager, ...). Not every OS wants
that, you might need to hide that particular close button (on that OS) if the OS
provides a similar functionality somewhere else (like in the titlebar). I'm
pretty sure it's menioned in other bugs, but I can't find them back right now.
For ref, see <http://mpt.phrasewise.com/2002/09/04#a332>

See also bug 228230 on Mac, as an example of the current mess. Also, don't
forget bug 50521 : modal dialogs on Mac should *not* have a close-box (enforced
by the OS), while Windows ones do. The API should take that into account.

Hmmm ... I'm starting to become a clone of mpt :-)

Comment 3

[Michiel van Leeuwen (email: mvl+moz@)]

A close button would make hiding it on certain os-es easier than a relabeled ok
button. (platform specifix overlays, just like for the order of buttons.) So
that is an reason to add the button, so it isn't discouraging :)