234681 - for "save all": every non system locale character attachment replaced with '_'

Status: RESOLVED WORKSFORME

(MailNews Core :: Attachments, defect)

Description

[Seak, Teng-Fong]

User-Agent:       
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.6) Gecko/20040113

When an email contains an attachment whose name contains non system locale
(Unicode) characters, and when we try to save such attachment, every non system
locale character is replaced by '_'.

I'll upload a test-case.

Reproducible: Always
Steps to Reproduce:




It's at least a good news that such attachment could be saved, even though the
name is changed :)

This bug is somehow the "reverse process" of bug 172337.

Comment 1

[石庭豐 (Seak, Teng-Fong)]

Attachment: Test-case mail containing Unicode filename

Let's me if this test-case if good or not.  I had to use Outlook 2003 to send
myself a mail with Unicode attachment, and I had deleted unrelated
mail-headers.  Hope the mail-header is still valid.

Comment 2

[石庭豐 (Seak, Teng-Fong)]

Typo error 'cause typing in a hurry :p

I meant
Let me know if test-case is good or not......

Comment 3

[Boris Zbarsky [:bzbarsky]]

*** Bug 234682 has been marked as a duplicate of this bug. ***

Comment 4

[石庭豐 (Seak, Teng-Fong)]

Attachment: Email containing several unicode-filenamed attachments

My last test-case if useful for those who use Western system locale.

This time I've made up an email containing several attachments.  The filename
of each one is in a different language (that I can enter using my computer).
So hopefully testers using Western or Eastern system locale could test
differently.

Comment 5

[石庭豐 (Seak, Teng-Fong)]

This bug is still unconfirmed ... I think it's because the Component field was
set at "Attachment".

I set it now to "Internationalization" and hope it would get more attention.

IMO, this bug depends on bug 162361.

Comment 6

[Mike Cowperthwaite]

*** Bug 259398 has been marked as a duplicate of this bug. ***

Comment 7

[Mike Cowperthwaite]

Confirming; seen with 1.8a4-0927, as well as TB 0.8.
I'm putting this back in Attachments for ease of searching, and adding the 
'intl' keyword.

Comment 8

[Elmar Ludwig]

*** Bug 295794 has been marked as a duplicate of this bug. ***

Comment 9

[Jungshik Shin]

this might be a dupe

Comment 10

[Adam Guthrie]

*** Bug 304220 has been marked as a duplicate of this bug. ***

Comment 11

[Jungshik Shin]

attachment handling code still uses obsolet nsFileSpec which is not fixed by bug 162361. Once it's switched over to nsI(Local)File, this bug will be fixed automatically because bug 162361 has been fixed at long last. 

Comment 12

[Masatoshi Kimura [:emk]]

*** Bug 335656 has been marked as a duplicate of this bug. ***

Comment 13

[Mike Cowperthwaite]

Seak, Teng-Fong: your bug 359148 (now fixed) seems to be the same as this one; dupe this over to the fixed bug?

Comment 14

[Trejkaz]

More like, dupe that one over to this one (this one was reported first.)

Comment 15

[石庭豐 (Seak, Teng-Fong)]

These two bugs are indeed similar, but on one hand, they are on two different products: one on Firefox while the other on Thunderbird (Mozilla mailer at the time of report).  On the other hand, even though they have the same "symptom", nothing allows us to conclude that they have common cause (same function).  That's why I reported the FF problem as a separate bug.

So unless FF and TB developers confirm this, I'm not going to dup them.

Comment 16

[Jungshik Shin]

This bug is not a dupe of bug 359148. See my comment #11 and bug 33451 this bug depends on. 

Comment 17

[Zhang Yichao]

This problem also can be seen in uploading or downloading picture. and its name will have this problem.

Comment 18

[Zhang Yichao]

(In reply to comment #17)
> This problem also can be seen in uploading or downloading picture. and its name
> will have this problem.
> 

especially ,downloading pics in the BBS

both reproduce on 2.0.0.3 and Minefield 

Comment 19

[Mike Cowperthwaite]

With TB 3a1-0527, which has the patches from bug 33451, I'm not seeing this bug's particular symptom.  Mark this Fixed?

Zhang Yichao, this is a Thunderbird bug, not a browser bug; your comments are out of place.  See bug 359148.

Comment 21

[klonos]

I can confirm this is fixed in Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1b2pre) Gecko/20081113 Shredder/3.0b1pre - Build ID: 20090226032557

Comment 22

[Magnus Melin [:mkmelin]]

->WFM then

Comment 23

[klonos]

On a second test using the second attachment with several unicode-filenamed attachments [https://bugzilla.mozilla.org/attachment.cgi?id=141675], and while trying to confirm bug 262739 [https://bugzilla.mozilla.org/show_bug.cgi?id=262739], I noticed the following two things (same 3.0b1pre build as above):

- When saving attachments one-by-one everything is ok, but when you choose 'Save all', the unicode letters are indeed replaced by '_'. This causes an error message in the case you have attachments with the same number of unicode letters saying that the file already exists and asking if you want to replace or not.

- This replacing of unicode letters with '_' occurs only for the Chinese, Japanese and Hebrew filenames. For the Spanish, the 'español.txt' is saved as 'espanol.txt'.

Comment 24

[klonos]

That's for windows platform though (WinXP Greek with unicode support enabled for all applications). Perhaps keep this one open till some people confirm it is resolved in other OSs as well?

Comment 25

[Steve Cooper]

This is not fixed in Thunderbird 2.0.0.19 (20081209), Windows Vista SP1, English-US.

1. In Thunderbird, right click on an attachment with a unicode filename, and choose "Save As...". The Save Attachment dialog will appear.

2. The file name displayed in the Save Attachment dialog is correct (unicode characters are preserved). However, if you click Save, the saved file's name has all unicode characters replaced with underscores (_). 

On the other hand, if you save the attachment in a different way, the unicode file names are preserved correctly:

1. Double-click the attachment icon. This will open the "Opening <filename>" dialog, asking you whether to open the file with another application or save the file to disk.

2. Click "Save to Disk", and click OK. This will display the "Enter name of file to save to..." dialog. The File name box will have the correct unicode file name filled in.

3. Click Save. The file, with the correct unicode file name, is saved on disk.

Comment 26

[Magnus Melin [:mkmelin]]

Please try
http://ftp.mozilla.org/pub/mozilla.org/thunderbird/nightly/latest-comm-central/
http://www.mozillamessaging.com/en-US/thunderbird/early_releases/

Comment 27

[Simon Montagu :smontagu]

This WFM on all platforms in 3.0b3

Comment 28

[石庭豐 (Seak, Teng-Fong)]

Reporter's here.

Using WinXP and TB 3.1, I can confirm that this bug is fixed.  I could test in Win2k if that's necessary.

(Sorry, I preferred the FIXED status rather than WORKSFORME because WFM implies the bug never existed or wrongly reported which is of course not the case).

Comment 29

[Ryan VanderMeulen [:RyanVM]]

WORKSFORME is used here as the resolution used when a bug disappears without knowing specifically what checkin fixed it. It has nothing to do with whether or not it was a legitimate bug.