235336 - password manager doesn't prefill mailman admin passwords

Status: RESOLVED FIXED

(Toolkit :: Password Manager, defect, P3)

Description

[Myk Melez [:myk] [@mykmelez]]

mozilla.org's mailman list admin login page looks like this:

<FORM METHOD=POST ACTION="/admin/list-name">
<INPUT TYPE=password NAME=adminpw SIZE=30>
<INPUT TYPE=SUBMIT name="request_login" value="Let me in...">
</FORM>

When I first submit this form, password manager asks me if I want to save the
logon.  If I say yes, it creates an entry like the following in my signons.txt
file but doesn't prefill the password the next time I go to the page:

.
http://mail.mozilla.org

MDIEEPgAAAAAAAAAAAAAAAAAAAEwFAYIKoZIhvcNAwcECBzU5SysyuplBAgpYIw19SDRIw==
*adminpw
MDIEEPgAAAAAAAAAAAAAAAAAAAEwFAYIKoZIhvcNAwcECKwzGi2sDhKYBAjXTkpVAmo5Dg==
.

Comment 1

[HJ]

I can't remember exactly what I did, I think I only had to add a (hidden) name
field, but my modified version of the mozdev admin page worked. 

I asked the mozdev guys to modify the admin page, but they never did. I am sure
that someone can find my modified version in the mailinglist archives. Hmm,
maybe this was done per e-mail.

I can do a search for the modified copy of the admin page, if someone needs it.

Comment 2

[Mailer Key]

this happens on a LOT of sites; stored passwords basically don't work for me
anymore... :(

Comment 3

[Ben Goodger (use ben at mozilla dot org for email)]

+ing to get on bryner's radar

Comment 4

[Ben Goodger (use ben at mozilla dot org for email)]

Not a "blocker"

Comment 5

[Christian Persch (GNOME) (away; not receiving bug mail)]

Attachment: possible fix

This patch fixes the problem with mailman login page for me.

The problem is that while searching the page for user/pwd fields, the password
manager first searches for the username field, and doesn't search for the pwd
field if there's no username field.

Comment 6

[Richard van den Berg]

I believe this is a duplicate of bug 210771. Someone please merge them.

Comment 7

[Christian Persch (GNOME) (away; not receiving bug mail)]

(In reply to comment #6)
> I believe this is a duplicate of bug 210771. Someone please merge them.

Yes, it's a duplicate. Since this bug has a patch and the other one not, let's
resolve bug 210771 as dup of this one.

Comment 8

[José Jeria]

Isn't the other one a suite-specif bug, while this one is firefox only?

Comment 9

[Christian Persch (GNOME) (away; not receiving bug mail)]

(In reply to comment #8)
> Isn't the other one a suite-specif bug, while this one is firefox only?

You're right. Not a duplicate then.

Comment 10

[Richard van den Berg]

Comment #2 of bug 210771 reads "I also see this with Firefox 1.0, so this is not
specific to Mozilla App Suite."

Are these 2 products now so separated that common bugs will have 2 entries in
bugzilla? That stinks.

Comment 11

[Ian Jackson]

I think this bug is a duplicate of
https://bugzilla.mozilla.org/show_bug.cgi?id=119731
(but this report is more informative, so it might be better to mark 119731 a duplicate of this one).

We have been running this patch in Ubuntu Breezy (it was first applied to our firefox in July 2005) without trouble and it now forms party of the actual release.

I am about to transfer this patch to Dapper (our next release, targetted for April 2006) and also to bring the patch to the attention of the Debian firefox maintainers.  It would be nice if this change could be reviewed by an expert at some point to know whether we are making a mistake :-).

Ideally of course we would like it in 1.5 but I'm sure there are other considerations about including patches like this one at this stage.

Comment 12

[Brian Ryner (not reading)]

Comment on attachment 185577 [details] [diff] [review]
possible fix

yep, looks ok.

Comment 13

[Brian Ryner (not reading)]

Comment on attachment 185577 [details] [diff] [review]
possible fix

checked in on trunk.  mconnor, you think this looks ok to take on the ff2 branch?

Comment 14

[Mike Connor [:mconnor]]

Comment on attachment 185577 [details] [diff] [review]
possible fix

Yeah, looks good.

Comment 15

[Phil Ringnalda (:philor)]

*** Bug 290820 has been marked as a duplicate of this bug. ***