Closed Bug 238898 Opened 17 years ago Closed 13 years ago
Error Console evaluates commands only one time
Confirmed with Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.7b) Gecko/20040327 Firefox/0.8.0+ It's enough to type a command like "alert('');" and hitting Enter one time. This alert box is displayed. All further evaluations doesn't open the alert box - nothing happens. -> QA
Status: UNCONFIRMED → NEW
Ever confirmed: true
QA Contact: bugzilla
Does this happend in Mozilla suite as well?
Product: Firefox → Browser
Version: unspecified → Trunk
*** Bug 292107 has been marked as a duplicate of this bug. ***
*** Bug 316994 has been marked as a duplicate of this bug. ***
*** Bug 326182 has been marked as a duplicate of this bug. ***
This was almost fixed by bug 328932 already.
bz, is the result of multiple setting the src of a frame even deterministic?
Comment on attachment 229229 [details] [diff] [review] always reset the iframe bz says that the right way to force a frame to reload is to set its location rather than muck about with src attributes. (Make sure you don't loop infinitely.)
Attachment #229229 - Flags: superreview?(neil) → superreview+
This works for me and doesn't require resetting the iframe to about:blank at all.
Comment on attachment 229229 [details] [diff] [review] always reset the iframe Whoops, typo ;-)
Attachment #229229 - Flags: superreview+ → superreview-
Comment on attachment 233505 [details] [diff] [review] use Evaluator.location I was sure I had reproduced bug 158475 earlier this week but it was getting late so I couldn't debug it at the time. Then yesterday I couldn't reproduce it, so I guess the patch is fine after all. Sorry for the delay.
Attachment #233505 - Flags: superreview?(neil) → superreview+
Attachment #233505 - Flags: review?(mconnor) → review?(gavin.sharp)
Comment on attachment 233505 [details] [diff] [review] use Evaluator.location I guess I have two questions about this patch: A) Can you also remove blank.html now? Seems like removing the only remaining reference after applying this patch (attribute on the iframe in console.xul) doesn't have any negative effects, though I'm not sure why it doesn't regress bug 328932. B) Looks like it relies on the global scope polluter (or something equally magical) to reference Evaluator directly, is that really desirable?
(In reply to comment #16) > A) Can you also remove blank.html now? There's one further instance (which should keep bug 328932 from regressing): http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/toolkit/components/console/content/console.xul&rev=1.11&mark=132#129 > B) Looks like it relies on the global scope polluter See comment #13 and the first line of function displayResult. Seems like reason for a different bug should we want to change this.
(In reply to comment #17) > (In reply to comment #16) > > A) Can you also remove blank.html now? > > There's one further instance (which should keep bug 328932 from regressing): > http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/toolkit/components/console/content/console.xul&rev=1.11&mark=132#129 That's what I meant by "the only remaining reference", removing it doesn't regress that bug. Neil has theorized that that other bug was fixed on the trunk by bz's security architecture work, so I think you should just remove that reference and the file itself (from xpfe too).
(In reply to comment #18) > That's what I meant by "the only remaining reference" I misread. This patch now additionally removes all references to blank.html and - while I'm at it - also fixes bug 369097 for both Toolkit and XPFE (which apparently didn't get the fix for bug 342662 to begin with).
Attachment #264477 - Flags: review?(gavin.sharp) → review-
Oh, and I was wanting to patch that escaping bug too, but I think it's best to leave that to a separate patch in the other bug (I can r+ quickly and land it for you).
(In reply to comment #20) > Missing the closing quote here. Good catch. > iframe.contentDocument.location [...] both toolkit and xpfe versions Done. > You also need to remove the blank.html entries from jar.mn. Done.
Attachment #264477 - Attachment is obsolete: true
(In reply to comment #21) > leave that to a separate patch Missed that one. Now done.
Attachment #264483 - Flags: review?(gavin.sharp) → review+
(In reply to comment #24) Filed bug 380422 for this issue.
No longer blocks: 380422
Whiteboard: [checkin needed]
mozilla/toolkit/components/console/jar.mn 1.7 mozilla/toolkit/components/console/content/console.js 1.7 mozilla/toolkit/components/console/content/console.xul 1.12 mozilla/toolkit/components/console/content/blank.html removed mozilla/xpfe/components/console/resources/content/console.js 1.26 mozilla/xpfe/components/console/resources/content/console.xul 1.38 mozilla/xpfe/components/console/resources/content/blank.html removed
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Hardware: PC → All
Resolution: --- → FIXED
Whiteboard: [checkin needed]
Target Milestone: --- → mozilla1.9alpha5
Oh, and mozilla/xpfe/components/jar.mn 1.90, too (oops).
v. with CVS build of Thunderbird version 3.0a1 (20070511)
Status: RESOLVED → VERIFIED
Product: SeaMonkey → Toolkit
QA Contact: error-console → error.console
You need to log in before you can comment on or make changes to this bug.