24256 - View>Page Source can be recursive, probably shouldn't be

Status: VERIFIED FIXED

(SeaMonkey :: UI Design, defect, P3)

Description

[Sean Richardson]

* Overview:
If the source for a page is viewed, the window showing the source will have
a "Page Source" item on its View Menu: activating this re-displays the same
page source in another window. This is both wasteful and unintuitive.

* Steps to reproduce:
0. Close the sidebar if open to work around bug 20171.
1. View any HTML page in Mozilla.
2. Use "Page Source" on the View Menu to view the source in a new window.
3. In that window, repeat step 2.

* Actual Results:
The source is displayed again in another window.

* Expected Result:
Step 3 should not have been possible: either the "Page Source" item should
not appear on the View menu in a page-source-viewing window (best), or it
should do nothing (still better than actual results).

* Tested with:
2000-01-14-08-M13 nightly binary on Windows NT 4.0sp3

* Additional Information:
While it is truly wonderful to have menus in the source-viewing window,
this is probably not the only item that may be best removed from the menus
of such windows.

Comment 1

[Matthew Tuck [:CodeMachine]]

I suggest bug #12111 as the solution to this.

Comment 2

[Sean Richardson]

Amending "Expected Results":
Step 3 should not have been possible: either the "Page Source" item should
not appear on the View menu in a page-source-viewing window, or it should
*be greyed out*. The latter is probably better.

Note that it would still be desirable to grey out the equivalent menu item,
which would presumably be transformed to "View > As Page Source", if bug 12111,
"[RFE] Browser modes, eg normal, view source, view DOM, etc" were implemented.

Comment 3

[Chris McAfee]

m15

Comment 4

[Sean Richardson]

The same logic may apply to text/plain pages, which have no "source" as such.
Currently, invoking View>Page Source on a page like 
http://www.ietf.org/rfc/rfc0003.txt presents the exact same content in a 
"Source for" window.

Also, everything said here about "Page Source" on the View menu would apply
equally to the "View Source" item on a contextual menu. Right now, no context
menu appears when right-clicking in a "Source for" window, but if that changes,
it should be greyed out too.

Comment 5

[Hixie (not reading bugmail)]

*** Bug 30039 has been marked as a duplicate of this bug. ***

Comment 6

[don]

Move to M16 for now ...

Comment 7

[Sean Richardson]

Fixed by removal of all menus from the View Source window.

Quoting from bug 32719, "menus missing entirely from View Source Window":
> ------- Additional Comments From [e-mail] 2000-04-27 09:15 -------
> View source window shouldn't have menu items. Confirmed by German.

Comment 8

[sairuh (rarely reading bugmail)]

verif.