242850 - closing Download Manager window while download happening asks to confirm quit

Status: VERIFIED FIXED

(Toolkit :: Downloads API, defect, P2)

Description

[Sophia Poirier]

User-Agent:       Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.8a) Gecko/20040506 Firefox/0.8.0+
Build Identifier: Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.8a) Gecko/20040506 Firefox/0.8.0+

I get a "if you quit now, you will cancel your 1 download" dialog when I try to
close the Download Manager window that is open (which, mind you, will not quit
the app).  This is when I have no browser windows open, just the Download
Manager window.

Reproducible: Always
Steps to Reproduce:
1.  Download something.
2.  Close browser window(s).
3.  Try to close Download Manager window while download is still occurring.
Actual Results:  
I get a "if you quit now, you will cancel your 1 download" dialog.

Expected Results:  
The window should close and the download should continue uninterrupted, since
closing that window does not quit the application.

Comment 1

[Ali Ebrahim]

This should be confirmed as long as others can reproduce it too. It's of course,
an OSX specific bug, as only in OSX is the browser supposed to remain running in
the absence of any windows.

Comment 2

[riscky]

Yeap... I keep wanting to file this bug but never have... if you accept the
dialog  firefox doesn't actually quit...

This dialog gets prompted when you close the last open Firefox window...
Download Manager or browser window.

Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.8a) Gecko/20040504
Firefox/0.8.0+

Comment 3

[Adit Panchal]

I too have noticed this issue. It also occurs when you set the download manager to not show (set in the 
Downloads preferences). In this case, the dialog will not show up a sheet on the download manager, but 
on the last browser window itself. This is probably due to the fact that there is no download manager to 
attach the sheet to.

You can reproduce this variant of the error by the following steps;
1. Disable the download manager in preferences so that it doesn't show when downloading a file.
2. Start downloading a file.
3. After you know you have started the download, try to close the browser window. It will prompt you 
with the same message as above. This only occurs if it is the last browser window open.

The expected results should be the same as mentioned above: as long as the application has 
not been asked to terminate, it should never prompt you for this dialog, regardless of the download 
manager visibility setting.

Thread at MozillaZine where I first reported the issue: http://forums.mozillazine.org/viewtopic.php?
p=681228

Comment 4

[David Feldman]

(In reply to comment #3)
I'm seeing this too (1.0RC2), but it's worth noting that the dialog is
inaccurate. If I choose to disable the download, then reopen the Download
Manager, the download is still in progress. As the previous poster said, it
would seem like the solution is simply to eliminate the dialog.

Comment 5

[Asa Dotzler [:asa]]

moving blocking1.0mac bugs to Firefox1.1 Target Milestone.

Comment 6

[Asaf Romano (gone)]

*** Bug 282829 has been marked as a duplicate of this bug. ***

Comment 7

[Asaf Romano (gone)]

problem is, "quit-application-requested" is fired (from canQuitApplication) when
closing the last window; This shoudn't be done on OS X, since closing the last
window doesn't mean "Quit" on mac.

Comment 8

[Asaf Romano (gone)]

Attachment: patch

see previous comment.

Comment 9

[Mike Connor [:mconnor]]

Comment on attachment 174905 [details] [diff] [review]
patch

this comment shouldn't show up in the processed file, it'll just be confusing. 
Stick a shell-style comment  before the #ifndef and we're good

Comment 10

[Asaf Romano (gone)]

Attachment: v1.1

Comment 11

[Asaf Romano (gone)]

Comment on attachment 174908 [details] [diff] [review]
v1.1

oops, wrong diff

Comment 12

[Asaf Romano (gone)]

Attachment: v1.1

again...

Comment 13

[Mike Connor [:mconnor]]

Comment on attachment 174909 [details] [diff] [review]
v1.1

This is really trivial, but even out the two lines, just for readability (the
quotes threw me off at the start of the line).	While I'm at it, lets just make
the comment read:

Closing the last window should not quit the application on OS X.

Comment 14

[Asaf Romano (gone)]

Checking in toolkit/content/globalOverlay.js;
/cvsroot/mozilla/toolkit/content/globalOverlay.js,v  <--  globalOverlay.js
new revision: 1.15; previous revision: 1.14
done
Checking in toolkit/content/jar.mn;
/cvsroot/mozilla/toolkit/content/jar.mn,v  <--  jar.mn
new revision: 1.10; previous revision: 1.9
done

Comment 15

[Asaf Romano (gone)]

*** Bug 304732 has been marked as a duplicate of this bug. ***

Comment 16

[Bryan Mills]

This bug has clearly not been fixed -- the program doesn't exit, but the dialog
still fires (1.0.6).

Comment 17

[riscky]

Bryan... the 1.0 branch is now, more or less, just for security fixes... the
next version Firefox 1.5 will have this fixed... which is why this bug has been
marked fixed.