Closed Bug 24581 Opened 25 years ago Closed 24 years ago

[CRASH, PP] linux,win: Font prefs crash on close if "when webpage chooses own fonts" selected

Categories

(SeaMonkey :: Preferences, defect, P3)

Product:
SeaMonkey
Component:
Preferences
Platform:
x86
Linux
Type:
defect

Tracking

(Not tracked)

Status:
VERIFIED FIXED

People

(Reporter: rzach, Assigned: matt)

References

Details

The font preferences dialog crashes if one of the options in the Fonts
preference regarding "If the webpage chooses its own fonts" is selected.  Note
that no radio button is selected initially.

To reproduce:
1. Open Preferences
2. Open Fonts
3. Select radio button under "If web page..."
4. Click OK

Actual result: Segfault
Expected result: Preference saved, back to browser.

*** VALUE=x-western
*** VALUE=8
*** VALUE=8

Program received signal SIGSEGV, Segmentation fault.
[Switching to Thread 1314]

Program received signal SIGSEGV, Segmentation fault.
0x4012f700 in PL_HashString ()
(gdb) where
#0  0x4012f700 in PL_HashString ()
#1  0x4012f5ea in PL_HashTableLookup ()
#2  0x40616931 in NSGetModule ()
#3  0x40615683 in NSGetModule ()
#4  0x4061854b in NSGetModule ()
#5  0x400ffbb5 in XPTC_InvokeByIndex ()
#6  0x405fc7e6 in NSGetModule ()
#7  0x405fd870 in NSGetModule ()
#8  0x40060c28 in js_Invoke ()
#9  0x40066f0a in js_Interpret ()
#10 0x40060c7d in js_Invoke ()
#11 0x40066f0a in js_Interpret ()
#12 0x40060c7d in js_Invoke ()
#13 0x40066f0a in js_Interpret ()
#14 0x40060c7d in js_Invoke ()
#15 0x40066f0a in js_Interpret ()
#16 0x40060c7d in js_Invoke ()
#17 0x40066f0a in js_Interpret ()
#18 0x40060c7d in js_Invoke ()
#19 0x40060e5c in js_InternalInvoke ()
#20 0x4004945f in JS_CallFunctionValue ()
#21 0x403439fe in nsJSContext::CallEventHandler ()
#22 0x40371aff in nsJSEventListener::HandleEvent ()
#23 0x40aef0bb in NSGetModule ()
#24 0x40aef50e in NSGetModule ()
#25 0x40dc547c in NSGetModule ()
#26 0x40af2fd9 in NSGetModule ()
#27 0x40af1b8d in NSGetModule ()
#28 0x40b23680 in NSGetModule ()
#29 0x4096e544 in NSGetModule ()
#30 0x4097adba in NSGetModule ()
#31 0x4096d03d in NSGetModule ()
#32 0x411dd16a in nsWidget::DispatchEvent ()
#33 0x411dd095 in nsWidget::DispatchWindowEvent ()
#34 0x411dd1f0 in nsWidget::DispatchMouseEvent ()
#35 0x411ddde1 in nsWidget::OnButtonReleaseSignal ()
#36 0x411e0dfc in nsWindow::HandleGDKEvent ()
#37 0x411d3b5a in handle_gdk_event ()
#38 0x4082b5cb in gdk_event_dispatch ()
#39 0x40859be6 in g_main_dispatch ()
#40 0x4085a1a1 in g_main_iterate ()
#41 0x4085a341 in g_main_run ()
#42 0x4077f859 in gtk_main ()
#43 0x411cc0aa in nsAppShell::Run ()
#44 0x4118fc12 in nsAppShellService::Run ()
#45 0x804a3a5 in JS_PushArguments ()
#46 0x804a714 in JS_PushArguments ()
#47 0x40214cb3 in __libc_start_main (main=0x804a538 <JS_PushArguments+4848>, 
    argc=1, argv=0xbffff864, init=0x8048fd8 <_init>, fini=0x804bae0 <_fini>, 
    rtld_fini=0x4000a350 <_dl_fini>, stack_end=0xbffff85c)
    at ../sysdeps/generic/libc-start.c:78

Linux build 2000.01.20.08
Severity: normal → critical
yup, was also able to repro this with the same linux bits --as well as on winNT
(2000-01-20-08). however, it didn't crash at all on mac (non-comm bits,
2000-01-20-08), although the resulting fonts (i had selected the last radio
button) looked awfully tiny. dunno if that's due to comm vs non-comm diffs
--then again this particular pref is the same on both (i'd imagine).

i'll attach Talkback reports...as soon as http://cyclone gets 'em...

btw, is Fonts one of those prefs that should be taken out for beta1? if yes, we
should pull this out...
Summary: [CRASH] Font prefs crash on close if "when webpage chooses own fonts" selected → [CRASH, PP] linux,win: Font prefs crash on close if "when webpage chooses own fonts" selected
*** Bug 24621 has been marked as a duplicate of this bug. ***
*** Bug 24639 has been marked as a duplicate of this bug. ***
I think the fonts will hopefully be polished 
enough for beta.  I'll look at this one
Status: NEW → ASSIGNED
m15?
Target Milestone: M15

I need a code review from someone.
Easy fix.  Just moving the prefstring to the radiobutton.
It was attached to the label and that was causing the program to crash. 

thx
-mf

Index: pref-fonts.xul
===================================================================
RCS file: /cvsroot/mozilla/xpfe/components/prefwindow/resources/content/pref-fon
ts.xul,v
retrieving revision 1.19
diff -r1.19 pref-fonts.xul
144,145c144,145
<                     pref="true" preftype="int" prefindex="2" />
<               <html:label for="pref:2:int:browser.use_document_fonts" accesske
y="t" tabindex="0" prefstring="browser.use_document_fonts">
---
>                     pref="true" preftype="int" prefindex="2"  prefstring="brow
ser.use_document_fonts"/>
>               <html:label for="pref:2:int:browser.use_document_fonts" accesske
y="t" tabindex="0">
151,152c151,152
<                     pref="true" preftype="int" prefindex="1" />
<               <html:label for="browserUseDocumentFonts1" accesskey="t" tabinde
x="0" prefstring="browser.use_document_fonts">
---
>                     pref="true" preftype="int" prefindex="1"  prefstring="brow
ser.use_document_fonts"/>
>               <html:label for="browserUseDocumentFonts1" accesskey="t" tabinde
x="0">
158,159c158,159
<                     pref="true" preftype="int" prefindex="0" />
<               <html:label for="browserUseDocumentFonts0" accesskey="t" tabinde
x="0" prefstring="browser.use_document_fonts">
---
>                     pref="true" preftype="int" prefindex="0"  prefstring="brow
ser.use_document_fonts"/>
>               <html:label for="browserUseDocumentFonts0" accesskey="t" tabinde
x="0">



fixed
Status: ASSIGNED → RESOLVED
Closed: 25 years ago
Resolution: --- → FIXED
*** Bug 25394 has been marked as a duplicate of this bug. ***
No crash on 2000.01.29.09 Linux build.  Marking verified.
Status: RESOLVED → VERIFIED
*** Bug 25433 has been marked as a duplicate of this bug. ***
*** Bug 25820 has been marked as a duplicate of this bug. ***
Bulk move of all Pref UI component bugs to new Preferences component.  Pref UI 
component will be deleted.
Component: Pref UI → Preferences
*** Bug 27673 has been marked as a duplicate of this bug. ***
*** Bug 27941 has been marked as a duplicate of this bug. ***
*** Bug 28204 has been marked as a duplicate of this bug. ***
*** Bug 28392 has been marked as a duplicate of this bug. ***
*** Bug 28388 has been marked as a duplicate of this bug. ***
*** Bug 28851 has been marked as a duplicate of this bug. ***
I am experiencing this bug in M14 Build ID: 2000022820
On Win 98
Reopening.
Status: VERIFIED → REOPENED
Resolution: FIXED → ---
M14 is now a month and a half old.  This bug was fixed just after M14 came out. 
Please download a new build.
Status: REOPENED → RESOLVED
Closed: 25 years ago → 24 years ago
Resolution: --- → FIXED
Verifying again.
Status: RESOLVED → VERIFIED
Product: Browser → Seamonkey
You need to log in before you can comment on or make changes to this bug.