252393 - toolbarbutton XUL elements with the orient attribute set to horizontal are broken

Status: VERIFIED FIXED

(Core :: XUL, defect)

Description

[Patrick Woodworth]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7) Gecko/20040707 Firefox/0.9.2
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7) Gecko/20040707 Firefox/0.9.2

XUL toolbarbutton elements with the orient="horizontal" attribute set, are
broken in multiple ways.  First the command associated isn't executed when
clicked. Second, when the type attribute isn't set so it should be a standard
button it still shows a dropmarker. Third, and finally if the type="menu-button"
attribute is set, then two dropmarkers are displayed.


Reproducible: Always
Steps to Reproduce:
The following XUL snippet demonstrates the problem.

<commandset id="mainCommandSet">
    <command id="cmd_gogoogleit" 
        oncommand="window._content.document.location='http://www.google.com'"/>
</commandset>

<commandset id="commands">
    <command id="cmd_gogoogleit" 
        oncommand="window._content.document.location='http://www.google.com'"/>
</commandset>

<toolbox id="navigator-toolbox">

    <toolbar id="fubar_toolbar" pack="start">

        <toolbarbutton id="good_button"
            label="GoodButton"
            tooltiptext="Good Button"
            command="cmd_gogoogleit" />

        <toolbarbutton id="fubar_button"
            orient="horizontal"
            label="FubarButton"
            tooltiptext="Fubar Button"
            command="cmd_gogoogleit" />


        <toolbarbutton id="fubar_menubutton"
            type="menu-button"
            orient="horizontal"
            label="FubarMenuButton"
            command="cmd_gogoogleit">

            <menupopup>
                <menuitem label="images" 
                   
onclick="window._content.document.location='http://images.google.com'"/>
                <menuitem label="groups" 
                   
onclick="window._content.document.location='http://groups.google.com'"/>
            </menupopup>
        </toolbarbutton>

    </toolbar>
</toolbox>
Actual Results:  
The second and third button have one more dropmarker than they should, and the
buttons themself do not invoke their associated command (i.e. changing the page
to  www.google.com).

Expected Results:  
The second button should have not have a dropmarker and the third should have
one dropmarker.  Both buttons when clicked should change the browser to the
Google home page.

Comment 1

[Patrick Woodworth]

I have placed the XUL test case on my webserver at http://emergent.org/fubar.xul

Comment 2

[Thiago Barbanti]

Yes, i have a same trouble with a toolbarbutton with atribute orient sets to
horizontal.

I tested in firefox 0.9, 0.9.1 and 0.9.2 in MacOSX, Win9x, Win2k/XP and Linux.

The button appear with a double arrow and not respond at click action.


(In reply to comment #0)
> User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7)
Gecko/20040707 Firefox/0.9.2
> Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7)
Gecko/20040707 Firefox/0.9.2
> 
> XUL toolbarbutton elements with the orient="horizontal" attribute set, are
> broken in multiple ways.  First the command associated isn't executed when
> clicked. Second, when the type attribute isn't set so it should be a standard
> button it still shows a dropmarker. Third, and finally if the type="menu-button"
> attribute is set, then two dropmarkers are displayed.
> 
> 
> Reproducible: Always
> Steps to Reproduce:
> The following XUL snippet demonstrates the problem.
> 
> <commandset id="mainCommandSet">
>     <command id="cmd_gogoogleit" 
>         oncommand="window._content.document.location='http://www.google.com'"/>
> </commandset>
> 
> <commandset id="commands">
>     <command id="cmd_gogoogleit" 
>         oncommand="window._content.document.location='http://www.google.com'"/>
> </commandset>
> 
> <toolbox id="navigator-toolbox">
> 
>     <toolbar id="fubar_toolbar" pack="start">
> 
>         <toolbarbutton id="good_button"
>             label="GoodButton"
>             tooltiptext="Good Button"
>             command="cmd_gogoogleit" />
> 
>         <toolbarbutton id="fubar_button"
>             orient="horizontal"
>             label="FubarButton"
>             tooltiptext="Fubar Button"
>             command="cmd_gogoogleit" />
> 
> 
>         <toolbarbutton id="fubar_menubutton"
>             type="menu-button"
>             orient="horizontal"
>             label="FubarMenuButton"
>             command="cmd_gogoogleit">
> 
>             <menupopup>
>                 <menuitem label="images" 
>                    
> onclick="window._content.document.location='http://images.google.com'"/>
>                 <menuitem label="groups" 
>                    
> onclick="window._content.document.location='http://groups.google.com'"/>
>             </menupopup>
>         </toolbarbutton>
> 
>     </toolbar>
> </toolbox>
> Actual Results:  
> The second and third button have one more dropmarker than they should, and the
> buttons themself do not invoke their associated command (i.e. changing the page
> to  www.google.com).
> 
> Expected Results:  
> The second button should have not have a dropmarker and the third should have
> one dropmarker.  Both buttons when clicked should change the browser to the
> Google home page.

Comment 3

[Andrew]

Attachment: fixes orient set to horizontal

This bug was caused by the checkin for bug 214893.
https://bugzilla.mozilla.org/show_bug.cgi?id=214893
This patch restores the horizontal attribute functionality and keeps the
existing mail button function.

Comment 4

[Serge Gautherie (:sgautherie)]

(In reply to comment #1)
> I have placed the XUL test case on my webserver at http://emergent.org/fubar.xul

This URI could be down, currently !?
Could you attach your testcase to this bug ?

Comment 5

[[e-mail]]

Comment on attachment 170205 [details] [diff] [review]
fixes orient set to horizontal

If this is the only button currently using this binding then I'd appreciate it
if the orient could be moved from the XUL to the XBL and its type changed to
"menu-vertical".

Comment 6

[Andrew]

Attachment: addresses Neil's comments

Comment 7

[Andrew]

As an update to anyone interested this bug still exists in the current nightlies and the 1.8 branch but the mail button no longer exists to use this functionality. The mail button and this bug are still in the 1.8.0 branch. The bug that removed the mail button from the 1.8 branch is https://bugzilla.mozilla.org/show_bug.cgi?id=306453

Comment 8

[[e-mail]]

Attachment: Add a dropmarker to Thunderbird's File button [Checkin: Comment 12 & 16]

Thus making it more obvious that the button has a menu.

Comment 9

[Serge Gautherie (:sgautherie)]

(In reply to comment #8)
> Created an attachment (id=214196) [edit]
> Add a dropmarker to Thunderbird's File button

Neil,
This patch would seem to obsolete the previous one !?
What about the previously suggested change to <mozilla/mail/themes/qute/mail/primaryToolbar.css> ?

Comment 10

[[e-mail]]

(In reply to comment #9)
> What about the previously suggested change to
> <mozilla/mail/themes/qute/mail/primaryToolbar.css> ?
Sorry, I don't see to which change you refer...

Comment 11

[Serge Gautherie (:sgautherie)]

(In reply to comment #10)
> (In reply to comment #9)
> > What about the previously suggested change to
> > <mozilla/mail/themes/qute/mail/primaryToolbar.css> ?
> Sorry, I don't see to which change you refer...

My fault: I compared the patch in the wrong order.

Obsoleting previous patch, as the <mozilla/browser/base/content/browser.xul> part was removed in bug 306453 as mentioned in comment 7.

Comment 12

[[e-mail]]

I checked the patch in; can someone download tomorrow's build and retest?

Comment 13

[Serge Gautherie (:sgautherie)]

(In reply to comment #12)
> I checked the patch in; can someone download tomorrow's build and retest?

With Neil's hint,
{{
> Well, where is that "Thunderbird's File button" ? :-/
You have to customise the toolbar to find it.
}}
I verified that a dropmarker was added between
[Mozilla Thunderbird, version 3 alpha 1 (20060402)] (nightly) (W98SE)
and
[Mozilla Thunderbird, version 3 alpha 1 (20060404)] (nightly) (W98SE)
.

But, unlike the 'Get Mail' and 'Print' buttons, the 'File' icon and dropmarker behave synchronously wrt :hover and :active.
Is this related to the current patch, or another bug ?

PS: Neil, do we want this in the 1.8 branch !!? (as bug 306453 was fixed there too)

Comment 14

[Serge Gautherie (:sgautherie)]

Comment on attachment 214196 [details] [diff] [review]
Add a dropmarker to Thunderbird's File button
[Checkin: Comment 12 & 16]

Neil's email answer:
[[
> PS: Neil, do we want this in the 1.8 branch !!? (as bug 306453 was fixed there too)
Maybe.
]]

I still guess this (TK only) UI fix should be welcomed on v1.8.1 branch !!?

Comment 15

[Serge Gautherie (:sgautherie)]

Comment on attachment 214196 [details] [diff] [review]
Add a dropmarker to Thunderbird's File button
[Checkin: Comment 12 & 16]

(As a note, this patch did not update

/toolkit/themes/qute/communicator/button.css, line 80 -- .toolbarbutton-1[type="menu"] > .toolbarbutton-menu-dropmarker {

but it seems mscott should remove these (obsoleted) files someday...)

Comment 16

[Serge Gautherie (:sgautherie)]

Comment on attachment 214196 [details] [diff] [review]
Add a dropmarker to Thunderbird's File button
[Checkin: Comment 12 & 16]


Checkin: { 2006-05-05 07:03	bugzilla%standard8.demon.co.uk 	MOZILLA_1_8_BRANCH }

Comment 17

[Serge Gautherie (:sgautherie)]

[Mozilla Thunderbird, version 2 alpha 1 (20060506)] (tinderbox-builds, 2006050504(+)) (W98SE)

V.Fixed on 1.8.1 branch.

Comment 18

[Serge Gautherie (:sgautherie)]

Comment on attachment 214196 [details] [diff] [review]
Add a dropmarker to Thunderbird's File button
[Checkin: Comment 12 & 16]

Restoring
[[
[e-mail]  	2006-04-02 23:16:41 PDT  	  review+
]]
which was lost when I changed the product+component.