254225 - Display keyboard shortcuts for "back" and "forward" in "Go" menu

Status: RESOLVED FIXED

(Firefox :: Menus, defect, P2)

Description

[Craig Davis]

User-Agent:       Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.7) Gecko/20040628 Firefox/0.9.1
Build Identifier: Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.7) Gecko/20040628 Firefox/0.9.1

There are two undocumented features in the Mac OS X version of Firefox.  The
command+left arrow shortcut for back function is not listed next to Back in the
Go menu like it is in the Windows version of Firefox.  The same goes for the
Forward function and the command+right arrow that should be listed next to it. 
I have tried both shortcuts and they work perfectly despite being undocumented.
 If nothing else this change should be made so that Firefox does not have any
visible differences between the Windows and Mac OS X version of Firefox.  

Reproducible: Always
Steps to Reproduce:
1.Open Firefox
2.Click the Go menu 


Actual Results:  
You'll immediately see the keyboard shortcuts aren't listed next to the Back and
Forward functions.

Expected Results:  
The keyboard shortcuts should've been listed next to the Back and Forward
functions like they're in the Windows version of Firefox.

Comment 1

[riscky]

*** Bug 254233 has been marked as a duplicate of this bug. ***

Comment 2

[Bruce Davidson]

Confirming this bug on 0.9.3, can't see any dupes. Changing the summary from
"There are two undocumented features in the Mac OS X version of Firefox that
need menu items: back and forward" to make it more obvious in search, and reduce
the risk of any excited chatter about undocumented features.

Comment 3

[Jo Hermans]

see also bug 117186(for Seamonkey)

Comment 4

[Peter van der Woude [:Peter6]]

*** Bug 262741 has been marked as a duplicate of this bug. ***

Comment 5

[Asaf Romano (gone)]

Attachment: patch v1: show Accel+[ / ] in go menu

On OS X, the expected keyboard shortcuts for back and forward are Accel+[ / ]
(i.e. Safari and Camino) which is our second keyboard shortcut on *nix.

I'm not sure why we're supporting Accel+Arrows on mac anyway, it's known
not-to-work when any textfield (html or ui widget) has focus; I'm prettry sure
that was the reason for not using it on other platforms.

Comment 6

[Asaf Romano (gone)]

Attachment: up-to-date

also, killing Accel+Arrows (for back/forward) on mac.

Comment 7

[sairuh (rarely reading bugmail)]

while accel+[ / ] are used in Camino, Camino also (redundantly) uses
accel+arrows.  but as you say, the latter don't work when focus is in an html
form field.

Comment 8

[Asaf Romano (gone)]

mconnor: ping

Comment 9

[Mike Connor [:mconnor]]

Comment on attachment 175820 [details] [diff] [review]
up-to-date

We can't use alt-arrow on UNIX, some WMs use that for accel, and it'll cause
conflicts.

Comment 10

[Mike Connor [:mconnor]]

Comment on attachment 175820 [details] [diff] [review]
up-to-date

Gah, misread this.  Its an evil shortcut, but Epiphany uses it too, and its 4xp
(not that I care about 4xp).

Comment 11

[Asa Dotzler [:asa]]

Comment on attachment 175820 [details] [diff] [review]
up-to-date

a=asa

Comment 12

[Asaf Romano (gone)]

Checking in base/content/browser-menubar.inc;
/cvsroot/mozilla/browser/base/content/browser-menubar.inc,v  <-- 
browser-menubar.inc
new revision: 1.49; previous revision: 1.48
done
Checking in base/content/browser-sets.inc;
/cvsroot/mozilla/browser/base/content/browser-sets.inc,v  <--  browser-sets.inc
new revision: 1.46; previous revision: 1.45
done

Comment 13

[Mark Mentovai]

This killed the Command-Arrow shortcuts, but that doesn't seem like a good idea
to me.  Bug 291516.