Closed Bug 256065 Opened 21 years ago Closed 12 years ago

Add description field value to tooltips for bookmarks and/or folders

Categories

(Firefox :: Bookmarks & History, enhancement)

enhancement
Not set
normal

Tracking

()

RESOLVED WONTFIX

People

(Reporter: richard.corbin, Unassigned)

References

Details

Attachments

(4 obsolete files)

When hovering/selecting a folder/bookmark in the "Bookmarks" menu, the folder/bookmark's description (entered via "Bookmarks > Manage Bookmarks") should be displayed as a tooltip. If no description entered then show 'No description' as the tooltip (or nothing at all). NOTE - Wasn't sure whether the component for this was 'bookmarks' or 'menus'. Please change if necessary.
Assignee: vladimir → vladimir+bm
The tooltip / bubble should show both bookmark url and description. -slamdunk
The bookmarks toolbar currently shows the name and the URL. I don't think it would be a very good idea to deviate from that. Besides, the description would probably be too long in most cases anyways.
(In reply to comment #2) > The bookmarks toolbar currently shows the name and the URL. I don't think it > would be a very good idea to deviate from that. Besides, the description would > probably be too long in most cases anyways. I'm using 1.0 (Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.7.5) Gecko/20041107 Firefox/1.0) and I haven't seen any Tooltip/bubble appear when I mouse-hover over any bookmark-item. IE shows a URL when you hover over bookmark-link. The Manage-Bookmark screen shows both the URL and the Description. This is regarding 'Menu->Bookmarks' not 'Menu->Manage Bookmarks'
(In reply to comment #3) > I'm using 1.0 (Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.7.5) > Gecko/20041107 Firefox/1.0) and I haven't seen any Tooltip/bubble appear when I > mouse-hover over any bookmark-item. I'm talking about the Bookmarks *Toolbar*, which you may or may not use. > This is regarding 'Menu->Bookmarks' not 'Menu->Manage Bookmarks' I know what this is about. I'm just saying that it should stay consistent. Most people don't even have descriptions for their bookmarks. Using the name like the toolbar currently does would be best IMO.
OS: Windows XP → All
Hardware: PC → All
(In reply to comment #4) The current bookmark is simple as it shows only the title. Like you said maybe this is best as bubble might add complexity and confuse the average user. But if there is a way to add the bubble functionality through about:config then that would be good. The advanced users who really want it can enable it through about:config. Right now nobody care about 'description' because there it is displayed only in manage-bookmarks which people rarely use. If it was shown in bubble then some people would have used it. Description field can be used to write down short personal note related to particular bookmark. Might be useful for people who do research etc using internet.
Wait a minute, now you're asking for a bubble? This bug report was about adding a tool tip.
(In reply to comment #6) Tooltip and Bubble are same things except Bubble would allow multiline whereas tooltip is restricted to displaying one single line. Using bubble would add scalability.
Note that this FF bug is the same (duplicate !?) as bug 135962 for MAS.
Assignee: vladimir+bm → nobody
*** Bug 300554 has been marked as a duplicate of this bug. ***
sorry for bugspam, long-overdue mass reassign of ancient QA contact bugs, filter on "beltznerLovesGoats" to get rid of this mass change
QA Contact: mconnor → bookmarks
(In reply to comment #2) > The bookmarks toolbar currently shows the name and the URL. It should also display the description when you hover over items on the bookmarks toolbar.
Attached patch patch v1 (obsolete) — Splinter Review
This seems to fix the issue for me.
Assignee: nobody → wgianopoulos
Status: NEW → ASSIGNED
Attachment #292224 - Flags: review?
Attachment #292224 - Flags: review? → review?(mconnor)
Status: ASSIGNED → NEW
Component: Bookmarks → Places
Version: unspecified → Trunk
Blocks: 407484
Status: NEW → ASSIGNED
(In reply to comment #13) > Created an attachment (id=292224) [details] > patch v1 > > This seems to fix the issue for me. > This code can be greatly simplified if the only 2 possibilities here are folders and URL items.
Attached patch patch v2 (obsolete) — Splinter Review
More correct and simplified patch.
Attachment #292224 - Attachment is obsolete: true
Attachment #292228 - Flags: review?(mconnor)
Attachment #292224 - Flags: review?(mconnor)
Attached patch patch v2a (obsolete) — Splinter Review
Fix comment typo.
Attachment #292228 - Attachment is obsolete: true
Attachment #292229 - Flags: superreview?(mconnor)
Attachment #292228 - Flags: review?(mconnor)
Attached patch patch v3 (obsolete) — Splinter Review
One more try. Make variable name conform to standard.
Attachment #292229 - Attachment is obsolete: true
Attachment #292230 - Flags: review?(mconnor)
Attachment #292229 - Flags: superreview?(mconnor)
QA Contact: bookmarks → places
Comment on attachment 292230 [details] [diff] [review] patch v3 Upon re-reading the summary on this bug, it seems to be about adding tooltips for all items in the bookmarks menus using the item description as the tooptip. My patch is about using the description field for bookmark folders as tooltip in the bookmark toolbar. Not exactly the same thing. I filed bug 412166 on my issue and moved my patch there.
Attachment #292230 - Attachment is obsolete: true
Attachment #292230 - Flags: review?(mconnor)
Assignee: wgianopoulos → nobody
No longer blocks: 407484
Status: ASSIGNED → NEW
so i'm changing this to generally cover a "add description to bookmarks", the details of where and how can be defined here. Bill since this can be more generic i'm duping your new bug to this, and if you want to continue here you're welcome to do so.
Summary: Bookmarks menu should show tool tip for each folder/bookmark's description → Add description field value to tooltips for bookmarks and/or folders
Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h". In Thunderbird 3.0b, you do that as follows: Tools | Message Filters Make sure the correct account is selected. Click "New" Conditions: Body contains places-to-b-and-h Change the action to "Delete Message". Select "Manually Run" from the dropdown at the top. Click OK. Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter. Gerv
Component: Places → Bookmarks & History
QA Contact: places → bookmarks
The front-end team has decided not to fix this bug.
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: