258561 - Update button not persistent in menu toolbar

Status: VERIFIED INVALID

(Firefox :: Menus, defect)

Description

[Volkmar W. Pogatzki]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; rv:1.7.3) Gecko/20040908 Firefox/0.10
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; rv:1.7.3) Gecko/20040908 Firefox/0.10

When starting Firefox from a clean profile the update button is not in menu
toolbar. It can be put there by using "Restore Default Set" in customizing
toolbars. But it's not persistent. After closing and restarting Firefox it's
missing again.

Reproducible: Always
Steps to Reproduce:
1. Start Firefox from a clean profile
2. Find no UpdateButton in menu toolbar
3. Go => View => Toolbars => Customize...
4. Hit "Restore Default Set" button
5. Find green arrow UpdateButton next to throbber
6. Confirm hitting the "Done" button
7. Close and restart Firefox
8. Is the green arrow still there? No.
Actual Results:  
Update button could be customized to sit in menu toolbar, but it's gone after a
restart.

Expected Results:  
Update button in menu toolbar should be persistent if customized to sit there.

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Confirming with Mozilla/5.0 (Windows; U; Windows NT 5.0; rv:1.7.3)
Gecko/20040908 Firefox/0.10

Comment 2

[Asa Dotzler [:asa]]

see also bug 258985 and 258677

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Mmh, on another machine (Mozilla/5.0 (Windows; U; Windows NT 5.0; rv:1.7.3)
Gecko/20040912 Firefox/0.10) is no update button available within the customize
dialog. I also created a fresh profile but no way, the update button is not there.

Comment 4

[Anbo Motohiko]

(In reply to comment #0)
This contains two problems:
First, as I reported in Bug 258677, update icon is missing in toolbar (step 2, 7
and 8).

Second, when you customize update notification icon, update icon does not show
any information including its tooltip (step 4 to 6). This occurs not only
pressing 'Restore Default Set' button, but also dragging and dropping update icon.


First problem, I wrote in Bug 258677, the author specifies in update.css.
http://lxr.mozilla.org/aviarybranch/source/toolkit/themes/winstripe/mozapps/update/update.css#68
http://lxr.mozilla.org/aviarybranch/source/toolkit/themes/pinstripe/mozapps/update/update.css#63

Second problem is from no refreshing update icon's status. This status is set
only dynamically, and refreshData is not called when toolbar customization is done.
http://lxr.mozilla.org/aviarybranch/source/toolkit/mozapps/update/content/updates.xml#56

Comment 5

[Volkmar W. Pogatzki]

It's not a bug, it is a feature.
The icon should be visible (as is] only if there are updates available.

Comment 6

[Henrik Skupin [:whimboo][⌚️UTC+1]]

(In reply to comment #5)
> It's not a bug, it is a feature.
> The icon should be visible (as is] only if there are updates available.

Ok, that's why it isn't visible inside the customize dialog anymore. It makes
sense. 

v.

Comment 7

[Peter van der Woude [:Peter6]]

*** Bug 260189 has been marked as a duplicate of this bug. ***

Comment 8

[Peter van der Woude [:Peter6]]

*** Bug 262426 has been marked as a duplicate of this bug. ***