258822 - needs minimize/restore/close tooltip for F11 mode

Status: RESOLVED FIXED

(SeaMonkey :: UI Design, defect)

Description

[Sekundes]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.0; rv:1.7.3) Gecko/20040910 Firefox/0.10
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.0; rv:1.7.3) Gecko/20040910 Firefox/0.10

Needs minimize/restore/close tooltip for minimize/restore/close button in
fullscreen mode.
And I hope it can be fixed before Firefox localization string is freezed...

Reproducible: Always
Steps to Reproduce:

Comment 1

[Boris Zbarsky [:bzbarsky]]

Over to firefox.

Comment 2

[Sekundes]

ah, this is the bug for Mozilla, not Firefox.
The Firefox one I filed is bug 258823.

Comment 3

[Sekundes]

ah, this is the bug for Mozilla, not Firefox.
The Firefox one I filed is bug 258823.

Comment 4

[Christian :Biesinger (don't email me, ping me on IRC)]

Attachment: patch

Comment 5

[[e-mail]]

Comment on attachment 159262 [details] [diff] [review]
patch

>         <toolbarbutton id="close-button" class="toolbarbutton-1"
>+                       tooltiptext="&closeWindow.label;"
>                        oncommand="window.close();"/>
While you're here could you fix this to use the version that prompts the user
to close all tabs?

>+<!ENTITY minimizeButton.tooltip       "Minimize">
>+<!ENTITY restoreButton.tooltip        "Restore">
It would be nice to have all three entities together.

Comment 6

[Christian :Biesinger (don't email me, ping me on IRC)]

(In reply to comment #5)
> >+<!ENTITY minimizeButton.tooltip       "Minimize">
> >+<!ENTITY restoreButton.tooltip        "Restore">
> It would be nice to have all three entities together.

the third entity is the one already used for file|close window... I don't really
want to move that; it's probably already grouped with menuitems around it

Comment 7

[Christian :Biesinger (don't email me, ping me on IRC)]

Attachment: patch v2

puts minimize/restore texts near close window; asks when closing the window w/
multiple open tabs

Comment 8

[[e-mail]]

Comment on attachment 159435 [details] [diff] [review]
patch v2

r+sr=me

Comment 9

[Christian :Biesinger (don't email me, ping me on IRC)]

Checking in browser/resources/content/navigator.xul;
/cvsroot/mozilla/xpfe/browser/resources/content/navigator.xul,v  <--  navigator.xul
new revision: 1.422; previous revision: 1.421
done
Checking in browser/resources/locale/en-US/navigator.dtd;
/cvsroot/mozilla/xpfe/browser/resources/locale/en-US/navigator.dtd,v  <-- 
navigator.dtd
new revision: 1.176; previous revision: 1.175
done

Comment 10

[Christian :Biesinger (don't email me, ping me on IRC)]

*** Bug 189251 has been marked as a duplicate of this bug. ***