Closed Bug 264031 Opened 20 years ago Closed 20 years ago

Adding bookmarks does not work

Categories

(Firefox :: Bookmarks & History, defect)

Product:
Firefox
Component:
Bookmarks & History
Version:
1.0 Branch
Type:
defect
Priority:
Not set
Severity:
blocker

Tracking

()

Status:
VERIFIED FIXED

People

(Reporter: pavel.penaz, Assigned: vlad)

Details

(Keywords: fixed-aviary1.0, regression, Whiteboard: remaining problem: bookmarks manager)

Attachments

(2 files, 1 obsolete file)

264031-adding-bookmarks-broken-0.patch
3.21 KB, patch
bugs
: review+
bugs
: approval-aviary+
Details | Diff | Splinter Review
264031-adding-bookmarks-part-2.patch
2.13 KB, patch
asa
: approval-aviary+
Details | Diff | Splinter Review 
User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.3) Gecko/20041012 Firefox/0.10
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.3) Gecko/20041012 Firefox/0.10

In todays latest tinderbox branch build adding new bookmarks does not work.
Dragging links to the bookmark manager works though.

Reproducible: Always
Steps to Reproduce:
1. Clean install of Firefox with a new profile
2. Go to any web page
3. Go to bookmarks/Bookmark this page
4. Press OK

Actual Results:  
The add bookmark dialog remains on the screen and the page is not added to
bookmarks.

Expected Results:  
The dialog should go away and the page should appear in the bookmark manager.
It seems that dragging links to bookmark toolbar does not work as well. It seems
that links can only be dragged to the root folder in the bookmarks manager.
Dragging links to subfolders does not do anything..
Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.7.3) Gecko/20041012
Firefox/0.10

confirming

->NEW
->regression
Status: UNCONFIRMED → NEW
Ever confirmed: true
Keywords: regression
Version: unspecified → 1.0 Branch
patches in /bookmarks/ since last build
bug 248817
bug 252133
bug 256025
bug 262758
bug 263394
JSConsole error when you try to add / create a new bookmark:

Error: uncaught exception: [Exception... "Component returned failure code:
0x80070057 (NS_ERROR_ILLEGAL_VALUE) [nsIRDFContainer.InsertElementAt]" 
nsresult: "0x80070057 (NS_ERROR_ILLEGAL_VALUE)"  location: "JS frame ::
chrome://browser/content/bookmarks/bookmarks.js :: anonymous :: line 1662" 
data: no]
This also seems to cause dragged bookmarks to be placed in the wrong spot by one.
Attached patch partial backout (obsolete) — — Splinter Review 
This fixes the Add Bookmark dialog and the off-by-one error with dragging
bookmarks.
Comment on attachment 161873 [details] [diff] [review]
partial backout

Vlad?  I haven't checked the rationale, but this patch fixes the mentioned
problems.
Attachment #161873 - Flags: review?(vladimir)
seen on Mac too.

smoketest blocker
Keywords: smoketest
OS: Windows XP → All
Hardware: PC → All
Keywords: smoketest
OS: All → Windows XP
Hardware: All → PC
On it; I'd rather not back this out completely, because it does fix the bug with
items getting created in the wrong place.  I'm not sure why the same mechanism
isn't working for new items.  Patch soon.
Status: NEW → ASSIGNED
OS: Windows XP → All
Hardware: PC → All
Fix, as best I can tell, without breaking the recent fix -- this is sort of a
band aid, but it's also the least intrusive patch; otherwise, I'd have to
figure out what's incrementing the index incorrectly.  Bookmarks bits that i've
tested with this seem to work for me, but as has been proven, I suck at
testing, soo..
Attachment #161873 - Attachment is obsolete: true
Comment on attachment 161885 [details] [diff] [review]
264031-adding-bookmarks-broken-0.patch

r+a=ben@mozilla.org
Attachment #161885 - Flags: review?(bugs)
Attachment #161885 - Flags: review+
Attachment #161885 - Flags: approval-aviary+
Status: ASSIGNED → RESOLVED
Closed: 20 years ago
Keywords: fixed-aviary1.0
Resolution: --- → FIXED
Attachment #161873 - Flags: review?(vladimir)
"New Bookmark" and "New Live Bookmark" are still broken in the bookmarks
manager. Reopening. The js console shows:

Error: [Exception... "Component returned failure code: 0x80070057
(NS_ERROR_ILLEGAL_VALUE) [nsIRDFContainer.InsertElementAt]"  nsresult:
"0x80070057 (NS_ERROR_ILLEGAL_VALUE)"  location: "JS frame ::
chrome://browser/content/bookmarks/bookmarks.js :: anonymous :: line 1666" 
data: no]
Source File: chrome://browser/content/bookmarks/bookmarks.js
Line: 1666

Error: [Exception... "Component returned failure code: 0x80070057
(NS_ERROR_ILLEGAL_VALUE) [nsITransactionManager.doTransaction]"  nsresult:
"0x80070057 (NS_ERROR_ILLEGAL_VALUE)"  location: "JS frame ::
chrome://browser/content/bookmarks/bookmarks.js :: anonymous :: line 1392" 
data: no]
Source File: chrome://browser/content/bookmarks/bookmarks.js
Line: 1392
Status: RESOLVED → REOPENED
Flags: blocking-aviary1.0?
Keywords: fixed-aviary1.0
Resolution: FIXED → ---
Whiteboard: remaining problem: bookmarks manager
At least I was honest about sucking at testing. :)

This is my final offer!  (Every single New* and drag-type thingy seems to work
for me)
Comment on attachment 161935 [details] [diff] [review]
264031-adding-bookmarks-part-2.patch

a=asa for aviary checkin.
Attachment #161935 - Flags: approval-aviary+
Okay, really honestly fixed this time.  Read my lips, no new bugs!
Status: REOPENED → RESOLVED
Closed: 20 years ago → 20 years ago
Keywords: fixed-aviary1.0
Resolution: --- → FIXED
was it fixed on trunk as well?
Flags: blocking-aviary1.0?
No, the bug never made it to the trunk.
vrfy'd fixed with 2004101309-0.9+ linux bits on fc2.
Status: RESOLVED → VERIFIED
I noticed a problem that can be related to this bug:

1. rightclick personal toolbar and create a new folder
2. rightclick the new folder and delete that
3. repeat step 1 -> no new folder can be added
4. rightclick an existing folder and try to create a new folder there, result:

Error: [Exception... "Component returned failure code: 0x80070057
(NS_ERROR_ILLEGAL_VALUE) [nsIRDFContainer.InsertElementAt]"  nsresult:
"0x80070057 (NS_ERROR_ILLEGAL_VALUE)"  location: "JS frame ::
chrome://browser/content/bookmarks/bookmarks.js :: anonymous :: line 1677" 
data: no]
Source File: chrome://browser/content/bookmarks/bookmarks.js
Line: 1677

*** Bug 264368 has been marked as a duplicate of this bug. ***
Daniel, please search for a dupe and/or file a new bug for what you're seeing
with new folders.  Thanks. 
(In reply to comment #19)
> I noticed a problem that can be related to this bug:
> 
> 1. rightclick personal toolbar and create a new folder
> 2. rightclick the new folder and delete that
> 3. repeat step 1 -> no new folder can be added
> 4. rightclick an existing folder and try to create a new folder there, result:

I see it too. You might want to report this in a new bug.
Ok submitted bug 264385
sorry for bugspam, long-overdue mass reassign of ancient QA contact bugs, filter on "beltznerLovesGoats" to get rid of this mass change
QA Contact: mconnor → bookmarks
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: