267352 - printing doesn't print form inputs

Status: VERIFIED FIXED

(Core :: Printing: Output, defect)

Description

[(not reading, please use [e-mail] instead)]

printing doesn't print form inputs

to reproduce:

1) go to https://bugzilla.mozilla.org/enter_bug.cgi?product=Firefox
2) start filling out a bug, summary, url, cc, description etc.
3) hit print

you won't see the text values in the forms on paper.

note:  if you print preview, you will see the values.

I'm using Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.3)
Gecko/20041026 Firefox/1.0

this used to work, but I can't say for sure when it regressed.

Comment 1

[(not reading, please use [e-mail] instead)]

ben / asa, do you think this sort of printing regression should block 1.0?

Comment 2

[chris hofmann]

we need to figure out when this might have regressed, and what caused the
regression...  any ideas?

Comment 3

[Marcia Knous [:marcia]]

Tracy sees this on today's build on the Mac. We are investigating the regression
window.

Comment 4

[sairuh (rarely reading bugmail)]

for a simple test case, this also occurs at http://www.google.com

Comment 5

[Johnny Stenback (:jst)]

This worked in Firefox PR1, so it's a post-PR1 regression, it seems.

Comment 6

[sairuh (rarely reading bugmail)]

this regressed btwn 2004100409-0.9+ (works) and 2004100509-0.9 (broken) builds
--tested on linux fc2.

Comment 7

[chris hofmann]

on the blocker list until we know more.

Comment 8

[Johnny Stenback (:jst)]

Looks like this was caused by bug 228557, backing out that fix (plus the fix for
263060) makes printing contain form control values again.

Comment 9

[Mike Shaver (:shaver emeritus)]

Attachment: Flush the event queue to be sure that editor initialization has completed before we actually print.

I have learned much about event queue services today.  Please find enclosed a
patch which makes printing hold its horses until async initializations have
completed.

Comment 10

[Darin Fisher]

Comment on attachment 164643 [details] [diff] [review]
Flush the event queue to be sure that editor initialization has completed before we actually print.

r=darin with one change:

use the PR_STATIC_CALLBACK macro since you don't want to be exporting those
callback functions.

Comment 11

[Johnny Stenback (:jst)]

Comment on attachment 164643 [details] [diff] [review]
Flush the event queue to be sure that editor initialization has completed before we actually print.

sr=jst with PR_STATIC_CALLBACK(void *) etc used.

Comment 12

[Asa Dotzler [:asa]]

Comment on attachment 164643 [details] [diff] [review]
Flush the event queue to be sure that editor initialization has completed before we actually print.

after discussing in aviary meeting today, we don't want to risk this patch and
would like to revert the change at bug 228557.

Comment 13

[Johnny Stenback (:jst)]

The fix for bug 228557 is now backed out, so this is no longer a problem on the
aviary branch.

Comment 14

[Tracy Walker [:tracy]]

confirmed fixed on Firefox branch with builds:
Win 2004-11-05-07-0.11
Mac 2004-11-05-06-0.11

Comment 15

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 164643 [details] [diff] [review]
Flush the event queue to be sure that editor initialization has completed before we actually print.

a=roc for 1.8a5

Comment 16

[Mike Shaver (:shaver emeritus)]

Fixed on trunk for 1.8a5.

Comment 17

[Frank Wein [:mcsmurf]]

*** Bug 276452 has been marked as a duplicate of this bug. ***

Comment 18

[Frank Wein [:mcsmurf]]

It seems we forgot about the 1.7 branch here :/ (Bug 228557 was only backed out
on aviary branch as far as i read it on that bug; but the fix was checked into
1.7 branch, too). So what now (i dont know if backing out that patch is still
possible or if too much checkins already happened)?

Comment 19

[Frank Wein [:mcsmurf]]

Bug has NOT been fixed, still lack of fix for 1.7 branch.

Comment 20

[Frank Wein [:mcsmurf]]

*** Bug 277931 has been marked as a duplicate of this bug. ***

Comment 21

[John Coonrod]

Why is this marked "resolved" when I cannot download a fixed version?

Comment 22

[Frank Wein [:mcsmurf]]

(In reply to comment #21)
> Why is this marked "resolved" when I cannot download a fixed version?

It is fixed on Firefox and Mozilla Trunk builds. Don't worry, i'll hope this bug
will be fixed for 1.7.6.

Comment 23

[Mats Palmgren (inactive)]

*** Bug 278305 has been marked as a duplicate of this bug. ***

Comment 24

[Mats Palmgren (inactive)]

*** Bug 278697 has been marked as a duplicate of this bug. ***

Comment 25

[Frank Wein [:mcsmurf]]

*** Bug 278852 has been marked as a duplicate of this bug. ***

Comment 26

[James Ralston]

As of a follow-up to comment #22: is this fix going to be backported to the 1.7
branch (and be included in 1.7.6)?

We're stuck between a rock and a hard place here--many people are complaining
about this problem, but we don't want to revert to a version of Mozilla with
known security vulnerabilities...

Comment 27

[OstGote!]

*** Bug 279779 has been marked as a duplicate of this bug. ***

Comment 28

[Mike Kaply [:mkaply]]

Should we backport this fix for 1.7.6 or backout bug 228557 from 1.7.6 as was
done for aviary?

Comment 29

[Boris Zbarsky [:bzbarsky]]

Given that bug 228557 caused bug 267225 too, I would say we should back it out
of 1.7.6....

Comment 30

[Frank Wein [:mcsmurf]]

*** Bug 280970 has been marked as a duplicate of this bug. ***

Comment 31

[Gérard Talbot]

*** Bug 282321 has been marked as a duplicate of this bug. ***

Comment 32

[OstGote!]

Should now be fixed for 1.7.6. Please test it.

MOZILLA_1_7_BRANCH 2005-02-17 17:08	jst%mozilla.jstenback.com
Backing out the fix for bug 228557 (and bug 263060) since it caused regression
bug 267352. This was backed out of the aviary branch some time ago.
a=[e-mail]

Comment 33

[Frank Wein [:mcsmurf]]

Confirming with current 1.7 branch build, print preview displays text in input
fields and printing it out shows the text on the paper, too :).

Comment 34

[Boris Zbarsky [:bzbarsky]]

So..  Bug 228557 as never checked in on trunk, but t his was.  Do we still need
this on trunk?

Comment 35

[sairuh (rarely reading bugmail)]

vrfy'd fixed using firefox 1.0.1 and mozilla 2005031011-1.7 builds on linux fc3.

Comment 36

[sairuh (rarely reading bugmail)]

mistakenly removed fixed1.7.6 --pardon the bugspam. set your filter/quicksearch
to "ZippidityDooDahHey" to catch these for easy removal/etc/