269696 - Password list is in alpha order, not sorted by domain name

Status: RESOLVED WORKSFORME

(Firefox :: Settings UI, enhancement)

Description

[Dave Yorke]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.5) Gecko/20041107 Firefox/1.0
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.5) Gecko/20041107 Firefox/1.0

the list is sorted by strict alpha order so it sorts by protocol and sub-domain
before domain name.  Sorting by domain would keep passwords with the same domain
but different protocol (https vs. http) or a different sub-domain (www.foo.com
vs. foo.com).

Reproducible: Always
Steps to Reproduce:
1.
2.
3.




I know this is picky, but I wanted to remove all passwords from a domain today,
and had to hunt through the list to find the password under several different
protocol/sub-domain combinations.

Comment 1

[:Gavin Sharp [email: [e-mail]]]

Confirming RFE. This bugs me too.

Comment 2

[benc]

is this module javascript based? This bug would be a depends on bug 276474.

Also, is this a unique problem to Firefox, or does it affect Mozilla/TB? I don't
understand how bugs should be filed in the new world order.

Comment 3

[:Gavin Sharp [email: [e-mail]]]

(In reply to comment #2)
> is this module javascript based? This bug would be a depends on bug 276474.

This is javascript based. The sort code is at:
http://lxr.mozilla.org/mozilla/source/toolkit/components/passwordmgr/resources/content/passwordManager.js#300
(Firefox) 
http://lxr.mozilla.org/mozilla/source/extensions/wallet/signonviewer/resources/content/SignonViewer.js#407
(Seamonkey)

You can see it just does a regular Tree Sort, which I am assuming is alphabetical.

> Also, is this a unique problem to Firefox, or does it affect Mozilla/TB? I don't
> understand how bugs should be filed in the new world order.

It isn't a Core bug, since as you can see above wallet was forked with the
advent of toolkit. So the usual procedure is to file a SM - Password Manager and
a Toolkit - Satchel (I think) bug, marking depends, although since the affected
code hasn't changed I would tend to leave this open as one bug. If a patch for
one materializes then it could easily be ported to the other.

Comment 4

[Jim Booth]

The corresponding Seamonkey bug seems to be:
Bug 143472 - Host sort order in "Password Manager" should be done by Top Level
Domain on down

Comment 5

[David P James]

Mass edit: Changing QA to default QA Contact

Comment 6

[Chris Wood]

This bug blocks bug 376682.

Comment 7

[era+mozilla]

See also Bug 282220 which (I believe correctly) covers this for all of password manager, cookies, and the cookies exception manager.

Comment 8

[Martin Sch]

See bug 143472

Comment 10

[Henrique Martins]

I submitted an attachment to bug 282220 almost two years ago that I think solves this for IPv4. It was rejected because it had no comments, when the original file had not a single comment line before.  I then submitted almost the same version for review, but fully commented, and haven't heard anything since.

Every time I get updated I have to manually patch browser.jar, which is kind of a a pain. And I don't really understand the meaning of this bug, i.e. 269696, blocking 282220.

I also have an IPv6 version almost ready ....

Comment 11

[Justin Dolske [:Dolske]]

Henrique: I'd take a version of 282220 for the password manager UI, though it would need test coverage (there are existing tests to modify), and I think you'd need to use the eTLD service for better sorting... [see http://mxr.mozilla.org/mozilla-central/source/netwerk/dns/public/nsIEffectiveTLDService.idl]

Can I tempt you with the promise of a prompt review? Now's a great time, seeing as things are just getting rolling for 3.7. :-)

Not sure why 282220 has fallen through the cracks; I suspect you'd have better results by fixing each list in the preferences individually.

Comment 12

[:Gavin Sharp [email: [e-mail]]]

(In reply to comment #11)
> Not sure why 282220 has fallen through the cracks; I suspect you'd have better
> results by fixing each list in the preferences individually.

They all use the function being patched there, don't they? If we're going to have code that does this I'd like it to be shared across the various places that can use it... I was going to suggest writing a JS module for it, but if they're already all sharing the sorting code then that works just fine, and we should work on getting that patch tested and reviewed.

Comment 13

[:Gavin Sharp [email: [e-mail]]]

Ah, I forgot that the password manager pref UI code lives in toolkit. Perhaps a JS module would be best, then.

Comment 14

[Frankie]

@Gavin, Justin, et al, how exactly would Henrique pull his code out to a module? Writing drop-in replacement code for an existing file is a fairly straightforward task; starting a new library requires info about the project as a whole which newcomers might not have.

Comment 15

[:Gavin Sharp [email: [e-mail]]]

http://hg.mozilla.org/mozilla-central/rev/78e5543c0bc4 is an example of a patch that added a JS module (Services.jsm). I'd be happy to provide more detailed help over IRC or email if someone is interested in working on this.

Comment 16

[Henrique Martins]

I'll give it a try later this week.

Comment 18

[:Gijs (he/him)]

The about:logins code has different sort options these days (and is in domain order by default, I think).