349863 - Sort domains by the later elements of name

Status: RESOLVED DUPLICATE of bug 269696

(Toolkit :: Password Manager, enhancement)

Description

[ralphmerridew]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8.0.5) Gecko/20060731 Ubuntu/dapper-security Firefox/1.5.0.5
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8.0.5) Gecko/20060731 Ubuntu/dapper-security Firefox/1.5.0.5

I think the password manager would be more useful if it were arranged so that accounts from "foo.com", "http://foo.com", and "www.foo.com" were all put together, instead of being spread across the list.

Alternate Comparison Algorithm:
1)  Go to the next to last word in each domain.
2)  If the strings from that point to the end are different, return the comparison of those two strings.
3)  As long as neither string has been backed to the beginning:
3a)    Go back one word on each string.
3b)    If the words from there are different, return the comparison of those two words.
4)  If both strings have reached the beginning, they are identical.  Otherwise, whichever string is not at the beginning should go later.

I've written out a quick functor to demonstrate the algorithm; I've tested it briefly and it appears to give correct results (it formed a correctly sorted list; it was transitive in all my tests; all calls returned), but I haven't performed full analysis on it (It could also be arranged to avoid allocating the strings t1 and t2.)

Reproducible: Always

Comment 1

[ralphmerridew]

Attachment: Algorithm Demonstration

Comment 2

[Mike Masi]

This would be nice.  It's difficult to find the passwords now.

Comment 3

[Michael Wu [:mwu]]

Why did this get moved to preferences? The password manager Show Passwords UI is provided with password manager last I checked.

Comment 4

[Phil Ringnalda (:philor)]

Because I was getting ready to dupe it to mconnor's "one perfect display of domains to rule them all" when I got distracted by the effective-TLD work (which you would want to use, separate or together with the other things that display the same class of information, currently in various ways).

Comment 5

[ralphmerridew]

What was mconner's "one perfect display of domains to rule them all"?  (I searched but couldn't find it.)

Also, above code can be used under GPL v2, BSDL, MPL, or even "do whatever you want, so long as you give me credit".  OTOH, I used as "sit down and write" process, not "design carefully first"; one version would infinite-loop on two identical strings beginning with dots.

Comment 6

[Martin Sch]

See bug 143472 and bug 269696

Comment 9

[Chris Wood]

Bug 282220 seems to cover this, so is this a dupe?