271768 - Card Summery Pane Ignores Line Breaks In Notes Field

Status: RESOLVED FIXED

(Thunderbird :: Address Book, defect)

Description

[Jason]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.5) Gecko/20041107 Firefox/1.0
Build Identifier: Mozilla Thunderbird Version 0.9 (20041103)

When entering a multi-line note in Mozilla Thunderbird 0.9 the line breaks are
removed in the card summery pane.  They look like they have been replaced by
spaces, but I could be wrong.

i.e. The following is entered into the notes field of an address book card:
1
2
3

The following appears in the card summery pane:
1 2 3

Reproducible: Always
Steps to Reproduce:
1.Open Address Book
2.Create a new card
3.Go to 'Other' tab
4.Type the following into the 'Notes' field: 1 {enter} 2 {enter} 3
5.Press 'OK'
6.Select the new card in the Address Book (it has no name so it should be on the
top)
7.Assuming you have the Card Summery Pane on you will see under 'Other' it lists
'1 2 3'

Actual Results:  
Card Summery Pane displays:
1 2 3

Expected Results:  
Card Summery Pane should display:
1
2
3

It looks like the information is being saved correctly as you can enter the line
breaks, close Thunderbird, reopen the card and the notes text box displays the
text correctly.  It just looks like the Card Summery Pane is having problems
with the line break (I wonder if it has something to do with crlf vs. cr vs. lf
but I don’t know enough about the internal working of Mozilla to be sure)

Comment 1

[Mark Banner (:standard8)]

Ok, I submitted a patch for this a while back on mailnews. Looks like I need to 
port it across if it hasn't been incorporated (will check tonight), therefore 
taking bug for the time being.

Comment 2

[Mark Banner (:standard8)]

Confirming bug on  - and assigning to self, patch coming soon.

Comment 3

[Mark Banner (:standard8)]

Attachment: Port of Mailnews patch to tb

This is the one line patch to fix the multi-line notes problem ported from bug
16408. Going for r and sr at the same time as it's a simple fix.

FWIW, forgot to paste the build id I was confirming with earlier - version 0.6+
(20050203).

Comment 4

[Scott MacGregor]

Comment on attachment 173300 [details] [diff] [review]
Port of Mailnews patch to tb

I'll check this in for you. Thaks for the patch.

Comment 5

[Scott MacGregor]

fixed

Comment 6

[Mark Banner (:standard8)]

*** Bug 305318 has been marked as a duplicate of this bug. ***