273244 - Download Manager - memory usage increases when opening/removing files - memory is not reclaimed

Status: RESOLVED WORKSFORME

(Toolkit :: Downloads API, defect)

Description

[David Shipman]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.5) Gecko/20041107 Firefox/1.0
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.5) Gecko/20041107 Firefox/1.0

I get a consistent increase in Firefox 1.0 memory usage when opening downloaded
files (images) and then removing them from the downloaded list


Reproducible: Always
Steps to Reproduce:
1. Open Tools / downloads
2. Select a file e.g. a jpeg file 
3.  Click on Open  (this error happens whether the file is present or has been
moved/delted) 
4.   If file is present close viewer (if a picture file) or if file has been
deleted acknowledge OK in windows pop-up box.
5.  Click on remove

One can see the memory usage increasing by having the task manager open (in
another window side by side with the Downloads window) with the 'Processes' tab
active and sorting my memory usage. By having Firefox at the top of the list you
can see that every time you go through steps two to four above the memory usage
increases.

Actual Results:  
The PC response time increased as did the hard disk activity (as this Windows XP
page file access ?, I do not know enough about Windows XP to be certain, but I
suspect so)

Expected Results:  
Reclaimed the memory.

I did not continue wth sufficient iterations of the process in steps 2-4 above
until the PC crashed, but I am certain that the response time would have
continued increasing ntil the PC was effectively unusable or had in fact crashed.

Comment 1

[Jo Hermans]

*** Bug 274074 has been marked as a duplicate of this bug. ***

Comment 2

[stephen mcleod]

Note that closing the download manager window releases the memory.  You do not
have to close firefox entirely.
Also note that this also happens in Win2k.

Comment 3

[:Gavin Sharp [email: [e-mail]]]

*** Bug 271135 has been marked as a duplicate of this bug. ***

Comment 4

[Heikki Ylipaavalniemi]

Attachment: Firefox using more than 190 K of memory after clearing Downloads.

I cleared the list of Downloads and after each file Firefox used more memory.
In the end when I had deleted all Downloads Firefox was using over 190 K of
memory. It didn't free it after I had finished deleting the files. At the
moment when I'm writing this Firefox is using 192 K.

Comment 5

[mousky67]

(In reply to comment #4)
> Created an attachment (id=173607) [edit]
> I cleared the list of Downloads and after each file Firefox used more memory.
> In the end when I had deleted all Downloads Firefox was using over 190 K of
> memory. It didn't free it after I had finished
> 
> I cleared the list of Downloads and after each file Firefox used more memory.
> In the end when I had deleted all Downloads Firefox was using over 190 K of
> memory. It didn't free it after I had finished deleting the files. At the
> moment when I'm writing this Firefox is using 192 K.

Did you CLOSE Download Manager and verify that Firefox was still using over 192
MB (you are incorrectly referring to KB when it should be MB)

Comment 6

[Steve Chapel]

*** Bug 252065 has been marked as a duplicate of this bug. ***

Comment 7

[William Knight]

I have had this problem with multiple versions of Firefox, on Win98 ME. It
doesn't matter whether you close the download manager or not.  After downloading
more than 5 or 6 times, the memory usage just gets ridiculous - my disk just
keeps thrashing worse and worse until I have to close Firefox.  I love Firefox,
but this is a major ugly bug.

Comment 8

[Laszlo Sebo]

I was about to report the same bug, but i see it was reported many times already.

It seems like downloading multiple, but really small (make it 1-2k big) files
while the download manager is open is what results in the memory leak.
Each file adds about 1-5megs to the firefox process' ram usage. Closing the
download manager does not free all the used up memory. For example, i've
downloaded 10 small files (1-2k), which resulted in a mem usage increase of
about 15megs, but closing the download manager it only freed about 4megs.

Note, that i only downloaded the files, and didnt open them.

Comment 9

[Stefan Brandner]

I also see the above problem on W2k. I only wanted to add that when I run out of
memory the CPU goes to 100%. This is maybe the root cause for certain other
reported bugs.
If firefox does not crash which happens some time it has to be killed to release
the memory again.

Comment 10

[Conrad]

This problem can be circumvented by changing the download manager's history
setting to remove files from the download manager "upon successful download",
from the default setting "manually".  I tested this circumvention with Firefox
1.0.4 in SuSE Linux, WinXP and 2k (both at SP2).  More complete instructions to
verify the problem, fix, and verify the circumvention are at
http://cwclark.com/FIREFOX_Hangs.html

Comment 11

[Jeffrey Arcand]

I think you can also circumvent the problem by not showing the download manager
when download begins; but neither this nor automatically removing the download
is a solution to the problem; it just avoids the symptoms of the bug, it does
not solve it.

Comment 12

[WADA:World Anti-bad-Duping Agency]

Bug 242521, Bug 273244(this bug) and Bug 306190 look to be same problem.

Comment 13

[Hermann Schwab]

*** Bug 306190 has been marked as a duplicate of this bug. ***

Comment 14

[Hideo Oshima]

*** Bug 242521 has been marked as a duplicate of this bug. ***

Comment 15

[Wesley Johnston (:wesj)]

This seems fixed on the latest trunk. I don't see anything but a few page faults with Process Explorer.

Comment 16

[Shawn Wilsher :sdwilsh]

RESOLVED->WORKSFORME per comment 15