278759 - update dialog replaces opener window / takes entire screen, closes browser if finished OR cancelled

Status: RESOLVED WORKSFORME

(Toolkit :: Application Update, defect)

Description

[Aaron Slunt]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b) Gecko/20050113 Firefox/1.0+
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b) Gecko/20050113 Firefox/1.0+

Using the blue update icon found in the top righ thand corner, by clicking on it
and choosing "cancel" if you don't want to update whatever it finds, firefox
closes. This also occurs when the extension is installed, and "finished" is
clicked. What's worse is the update dialog replaces the browser itself, and
there is no way to resume the browser session once the update process begins.

Reproducible: Always

Comment 1

[Peter van der Woude [:Peter6]]

Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8b) Gecko/20050117 Firefox/1.0+

WFM

Comment 2

[Chris Blore]

WFM under Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b)
Gecko/20050117 Firefox/1.0+

Comment 3

[Anton van Bohemen]

Confirming. Does _not_ WFM with 2005-01-16 and 2005-01-18.

Also: In Tools->Extensions->Update, when no updates are found (or if the check
is cancelled) the same thing happens: the Extensions window is closed. I expect
to return to the Extensions dialogue.

Might also be related to bug 278297: there, the window cannot be closed. If it
would (but I admit that's a long shot), the entire Options dialogue probably
will close.

Comment 4

[Aaron Slunt]

A demonstration of this can be found here:

http://turkeybot.info/firefoxbug.avi

Comment 5

[José Jeria]

Attachment: Screenshot

Build 20050130, Windows XP, saw the green icon, clicked on it, update dialog
fills the entire screen. Clicking Cancel or finish (no updates found it says)
closes Firefox. Maybe related to bug 280603?

Comment 6

[Fred Collier]

Mozilla/5.0 (Windows; U; Win95; en-US; rv:1.8b) Gecko/20050131 Firefox/1.0+

WFM

Could this be Win XP only?

Comment 7

[Steve England [:stevee]]

Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8b) Gecko/20050201 Firefox/1.0+

Here's how to reproduce the bug.

1. Go to Tools > Options > Software Update
2. Click "Check Now"
3. Notice that the blue arrow icon appears in the top right of the browser window.
4. Click 'CANCEL' (The one in the most bottom right of the Options window, not
the one pertaining directly to the software update.
5. Notice that the blue arrow icon remains in the top right of the browser
window for a couple of seconds before disappearing.
6. Before the icon disappears, left click on it
7. Observe the Firefox Update window takes over the whole browser window. You
now have to close the browser and restart it to be able to browse. Also, when
you click "Finish" the browser closes itself anyway.

Comment 8

[Thomas Rutter]

Bug #272888 is concerned with Firefox closing without warning when pressing
"Finished" after a successful update.

Note that I experienced this problem when upgrading from 1.0RC2 to 1.0, but not
when upgrading from 1.0PR to 1.0.

Comment 9

[Phil Ringnalda (:philor)]

*** Bug 281087 has been marked as a duplicate of this bug. ***

Comment 10

[James Ross]

Has anyone who's seen this tried the Update Now button in Advanced? It's quite
sweet what happens.

I can't see any comments indicating what is actually happening, but I know - it
is replacing the opener with the actual dialog! E.g. the coloured update blob
replaces the /entire browser/ with the wizard, Update Now replaces the
iframe/page of the Options, and right-clicking and selecting Update on an
extension replaces the entire Extensions window.

Doesn't happen in 1.0, but does happen in this 1.0+ build I just installed:
Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8b) Gecko/20050204 Firefox/1.0+

Comment 11

[José Jeria]

(In reply to comment #10)
> Has anyone who's seen this tried the Update Now button in Advanced? It's 
quite sweet what happens.

I guess that would be bug 280627

Comment 12

[James Ross]

*** Bug 280627 has been marked as a duplicate of this bug. ***

Comment 13

[James Ross]

Just to clear things up: taking up the entire screen is because it replaces the
entire browser window, and the same thing also means Finish *and* Cancel kill it
(since you really only have the update wizard).

Comment 14

[Steve England [:stevee]]

This problem seems to be fixed with the 20050209 build
Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8b) Gecko/20050209 Firefox/1.0+

Comment 15

[José Jeria]

Also WFM, same build, Windows XP. Dialog opens up in its own dialgo now (comment 13)

Comment 16

[Aaron Slunt]

It now WFM Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b)
Gecko/20050210 Firefox/1.0+

Can anyone find out what bug was fixed that caused this to be fixed as well, so
we know what it depended on?

Also, I will resolve this to worksforme since I don't know what actually fixed
it...if this should be resolved as fixed, then please change it to that.

Also note that the blue icon is still painted onto the top-right hand corner
after the whole cancel thing to get it...that should be fixed, but that's
another bug...

Comment 17

[James Ross]

http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/toolkit/mozapps/update/src/nsUpdateService.js.in&mark=254-255#246

That's the line that opens the wizard, and that (and all code near it) has not
changed. :(  I also can't find anything in Bonsai from 2005-02-03 to 2005-02-09
in mozilla/toolkit or mozilla/browser.

Ahaa! After much Bonsai fun, I found this:
http://bonsai.mozilla.org/cvslog.cgi?file=mozilla/docshell/base/nsDocShell.cpp&root=/cvsroot&rev=1.658

I don't really know docshell, but that looks suspiciously related (the wizard
code opens an unnamed window, after all) and is within the period in question.