279105 - International keyboard input completely broken (typed text displays as accented Latin-1)

Status: RESOLVED FIXED

(Core :: Internationalization, defect)

Description

[Simon Montagu :smontagu]

In recent builds non-Latin keyboard methods are not working. Instead of the
correct international characters I am getting garbage in the Latin-1 range, e.g
in Greek instead of Οδυσσευς I get Ïäõóóåõò.

Steps to reproduce (on Windows XP; I don't know yet if the same bug exists on
other platforms)
1) Install a non-Latin keyboard method at Control Panel | Regional and Language
Options | Languages | Details | Add
2) Activate the keyboard with Alt - Shift or the task bar icon
3) Type in a Mozilla text box or Composer

Expected results (for typing "qwertyuiop" with Greek keyboard):
;ςερτυθιοπ

Actual results:
;òåñôõèéïð

Assigning to aaronlev because backing out the patch from bug 167145 corrects the
problem.

Comment 1

[Aaron Leventhal]

Can we find out if it's broken on other platforms?

That's crucial to debugging the cause. I don't want to back out bug 167145 if I
can avoid it. I need that fix.

Comment 2

[Aaron Leventhal]

Neil, any idea?

Comment 3

[Ilya Konstantinov]

For the record, no such problem on gtk2.

Comment 4

[Alexander Doborshhuk]

Using Gecko/20050120 Firefox/1.0+@XPSP2 experiencing this :(. It completely
blocks my testing work.

---
Expected: проверка
Actual: проверка
---

Comment 5

[Aaron Leventhal]

Attachment: Does this fix the problem?

Comment 6

[Ben Fowler]

I am using Camino version 2005011508 (v0.8+) and can type using
a Cyrillic keyboard, videlicet: Нерсесова.

FYI qwertyuiop goes йцукенгшщз.

(See previous comment - are you happy that this is windows only?)

Comment 7

[[e-mail]]

CCing other people who have looked at this code recently for comments.

Comment 8

[Asaf Romano (gone)]

*** Bug 279137 has been marked as a duplicate of this bug. ***

Comment 9

[Asaf Romano (gone)]

WFM on OS X.

Comment 10

[Ere Maijala (slow)]

Comment on attachment 171880 [details] [diff] [review]
Does this fix the problem?

r+ even if it doesn't fix the problem..

Comment 11

[Jungshik Shin]

The patch here isn't likely to fix the problem. Anyway, I agree with Ere that we
need it.

Comment 12

[Simon Montagu :smontagu]

(In reply to comment #11)
> The patch here isn't likely to fix the problem.

It does fix the problem :)

Comment 13

[Simon Montagu :smontagu]

*** Bug 279429 has been marked as a duplicate of this bug. ***

Comment 14

[Jungshik Shin]

(In reply to comment #12)
> (In reply to comment #11)
> > The patch here isn't likely to fix the problem.
> 
> It does fix the problem :)

Good !!  My reasoning was : the patch replaces 'A' APIs with 'W' APIs *only* on
Win 2k/XP so that it wouldn't change anything on Win 9x/ME. 

My memory is not clear as to whether it's possible to use a keyboard other than
the default (for the system locale which is fixed on Win 9x/ME) on Win 9x/ME
(GlobalIME for CJK can be certainly used on Win9x/ME). If it's not possible,
that's not an issue. If it's possible, somebody needs to test it on Win 9x/ME. 

Comment 15

[Simon Montagu :smontagu]

(In reply to comment #14)
> My memory is not clear as to whether it's possible to use a keyboard other than
> the default (for the system locale which is fixed on Win 9x/ME) on Win 9x/ME
> (GlobalIME for CJK can be certainly used on Win9x/ME). If it's not possible,
> that's not an issue. If it's possible, somebody needs to test it on Win 9x/ME. 

Good point, we should test what's been happening on Win 9x/ME. I've only seen
the regression and the fix on XP.

Comment 16

[Aaron Leventhal]

Checked in. Please reopen if the problem persists.

Comment 17

[Vedran Miletic]

Verified fixed, Croatian characters work again. Thanks to everybody who worked
on it!

Comment 18

[Jungshik Shin]

I'm on Windows ME (EN) and have just tried firefox 2005-01-17 (before the check
in for bug 167145), 2005-01-19 (after the check-in for bug 167145),  2005-01-24
(after the check-in of the fix here) and firefox 1.0. Somehow, Greek input just
worked fine in all four cases. However, there's a big problem (which seems to be
a separate issue) with Korean global IME (I guess Chinese and Japanese global
IMEs have the same problem). With firefox 1.0 and Mozilla 1.1beta (I haven't
booted up WinME for a long time), globale IME for Korean works fine, but in
recent trunk builds (all three of them) of firefox and suite 1.8a6, the global
IME cannot be activated at all.   For this problem, I filed bug 279105.

Comment 19

[Jungshik Shin]

Sorry for bug spam. It's bug 279816

Comment 20

[Patrick]

*** Bug 279356 has been marked as a duplicate of this bug. ***