284081 - When software install (xpinstall.enabled) is disabled clicking "Edit Options" on the message bar opens an empty window

Status: RESOLVED FIXED

(Firefox :: Settings UI, defect)

Description

[PikeUK]

When you have software install disabled, the message bar popups up giving you
the option to re-enable it, but with the new options window that doesn't work.
This bug is similar to Bug 283944 but is not the same.

Steps to reproduce:
1. Goto Tools->Options->Content
2. Uncheck "Allow web sites to install software"
3. Try to install something, e.g. http://hacksrus.com/~ginda/chatzilla/
4. Click "Edit Options"

Actual Results
An empty window opens.

Expected Results
The options window opens at the Content page (or some other method of
re-enabling software install is provided).

p.s. This is *not* a dupe of Bug 283944, note step 2 above.

Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.8b2) Gecko/20050228 Firefox/1.0+

Comment 1

[PikeUK]

*** Bug 287117 has been marked as a duplicate of this bug. ***

Comment 2

[PikeUK]

Tweaking summary (added pref name, xpinstall.enabled) to make bug more findable.

Based on dupe:

OS -> ALL

Comment 3

[Steffen Wilberg]

Attachment: patch v0.1

Mostly done, but I need to update the pane button when the dialog is already
open and we're just switching the pane.

Comment 4

[:Gavin Sharp [email: [e-mail]]]

*** Bug 287890 has been marked as a duplicate of this bug. ***

Comment 5

[Steffen Wilberg]

Attachment: patch v1

Now it flies. Use e.g. openPreferences("paneContent"); to open the Content
pane. The pane button is now selected in the showPane method.

Tested in Thunderbird as well. It doesn't break it, but Thunderbird needs a
port of the openPreferences() changes to its openOptionsDialog() function in
mailCore.js and adjust the callers of that.

Comment 6

[Mike Connor [:mconnor]]

Comment on attachment 180784 [details] [diff] [review]
patch v1

let's try to get this for alpha, not hold-worthy at this stage though.

Comment 7

[Asa Dotzler [:asa]]

Comment on attachment 180784 [details] [diff] [review]
patch v1

a=asa

Comment 8

[Steffen Wilberg]

Checking in mozilla/browser/base/content/browser.js;
/cvsroot/mozilla/browser/base/content/browser.js,v  <--  browser.js
new revision: 1.422; previous revision: 1.421
done
Checking in mozilla/browser/base/content/utilityOverlay.js;
/cvsroot/mozilla/browser/base/content/utilityOverlay.js,v  <--  utilityOverlay.js
new revision: 1.20; previous revision: 1.19
done
Checking in mozilla/toolkit/content/widgets/preferences.xml;
/cvsroot/mozilla/toolkit/content/widgets/preferences.xml,v  <--  preferences.xml
new revision: 1.14; previous revision: 1.13
done

Comment 9

[Dave Townsend [:mossop]]

I believe this caused Bug 292411

Comment 10

[Mike Connor [:mconnor]]

sorry for bugspam, long-overdue mass reassign of ancient QA contact bugs,
filter on "beltznerLovesGoats" to get rid of this mass change