284130 - regression: Reload icon displays wrong when using small icons

Status: VERIFIED FIXED

(Firefox :: Toolbars and Customization, defect)

Description

[[e-mail]]

User-Agent:       Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.8b2) Gecko/20050228 Firefox/1.0+ (PowerBook)
Build Identifier: Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.8b2) Gecko/20050228 Firefox/1.0+ (PowerBook)

The Reload icon in the Navigation Toolbar is displayed wrong when you use
activate "Use Small Icons" and open a new tab.
Worked fine with the 2005.02.27 build, so it must be caused by a recent checkin.

Reproducible: Always

Steps to Reproduce:
1. Customize Navigation Toolbar.
2. Activate "Show Small Icons".
3. Open a new tab.

Actual Results:  
The blue Reload icon disappear and a some other graphic takes its place.

Expected Results:  
The blue Reload icon should be grayed out, just like when you use the "Normal"
icon size.

Comment 1

[Asaf Romano (gone)]

regression from 237776.

Comment 2

[Mike Connor [:mconnor]]

There's no reason for this to be broken in the default theme (both pinstripe and
winstripe have CSS to cover this), though third-party themes might not have
CSS/images for a disabled reload button.

Comment 3

[Asaf Romano (gone)]

This does happen with Pinstripe (small icons mode only)

Comment 4

[Frederic Bezies]

so my bug 284052 is a duplicate of this one ;(

Comment 5

[Frederic Bezies]

*** Bug 284052 has been marked as a duplicate of this bug. ***

Comment 6

[Asaf Romano (gone)]

*** Bug 284724 has been marked as a duplicate of this bug. ***

Comment 7

[Asaf Romano (gone)]

*** Bug 284848 has been marked as a duplicate of this bug. ***

Comment 8

[Asaf Romano (gone)]

*** Bug 284895 has been marked as a duplicate of this bug. ***

Comment 9

[Frederic Bezies]

Sorry for spamming the bug !

Please, Asaf, stop reporting duplicates ;o)

How many duplicates before this *censored* bug is fixed ?!

Comment 10

[Asaf Romano (gone)]

lol

Comment 11

[Kevin Gerich]

Whining must take the form of a diff

fixed on trunk

Comment 12

[Ryan VanderMeulen [:RyanVM]]

(In reply to comment #11)
> Whining must take the form of a diff
> 
> fixed on trunk

What checkin fixed it? And if a checkin for another bug fixed it, shouldn't this
one be resolved WORKSFORME?

Comment 13

[Asaf Romano (gone)]

Thanks Kevin.

http://bonsai.mozilla.org/cvsquery.cgi?treeid=default&module=all&branch=HEAD&branchtype=match&dir=&file=&filetype=match&who=&whotype=match&sortby=Date&hours=2&date=explicit&mindate=2005-03-05+12%3A58&maxdate=2005-03-05+12%3A58&cvsroot=%2Fcvsroot

and even if it was on another bug, as long as we know when-and-how it was fixed,
wfm is invalid.

Comment 14

[Frederic Bezies]

Well, now it is fixed, I have to build a new fox ;o)

Thanks !

Comment 15

[Jesse Smith]

(In reply to comment #14)
> Well, now it is fixed.

Oh no it's not

http://forums.mozillazine.org/viewtopic.php?t=354194