296080 - showAutoscrollMarker code is wrong in special situations

Status: RESOLVED FIXED

(Toolkit :: UI Widgets, defect)

Description

[Martijn Wargers (dead)]

See upcoming testcase.
The showAutoscrollMarker relies on documentElement.offsetHeight and -offsetWidth
to get the document height.
This is not the case with the testcase.
The result of this is that the user gets to see the wrong autoscrollmarker image
(autoscroll_all.png).

Comment 1

[Martijn Wargers (dead)]

Attachment: testcase

Comment 2

[Martijn Wargers (dead)]

Attachment: patch

This patch fixes it for me. I've also checked this works in xul and xml
environments.
I've also simplified some other code in that function (which I think is an
improvement).

Comment 3

[Martijn Wargers (dead)]

Uhm, Gavin, why have you cancelled my review? Did I do something wrong?

Comment 4

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 184934 [details] [diff] [review]
patch

No, the change of component canceled the request. Sorry Martijn.

Comment 5

[Martijn Wargers (dead)]

Ok, no problem, Gavin, but this sounds like a bugzilla bug to me (and I can't
find any bug that is similar to this).

Comment 6

[:Gavin Sharp [email: [e-mail]]]

Yes, it's bugzilla bug 261995.

Comment 7

[Martijn Wargers (dead)]

*** Bug 216035 has been marked as a duplicate of this bug. ***

Comment 8

[Martijn Wargers (dead)]

Comment on attachment 184934 [details] [diff] [review]
patch

Anyway, this is good enough. The overflow:hidden case can be solved, but I'll
do that in an eventuel other patch.

Comment 9

[Martijn Wargers (dead)]

Oops! Comment 8 is about the wrong bug (browser tabs can sometimes be very
confusing).

Comment 10

[Mike Connor [:mconnor]]

Comment on attachment 184934 [details] [diff] [review]
patch

I'm not in wifi range as I'm writing this, but I swear I've reviewed this patch
before.

Comment 11

[Martijn Wargers (dead)]

Checked in by bz.

Comment 12

[:Gavin Sharp [email: [e-mail]]]

Checked in on the 1.8 branch.
mozilla/toolkit/content/widgets/browser.xml; new revision: 1.70.2.6;