Closed Bug 212273 Opened 21 years ago Closed 2 years ago

[META] Use "better" Autoscroll for Firefox

Categories

(Firefox :: General, defect)

x86
All
defect

Tracking

()

RESOLVED FIXED

People

(Reporter: boullet.marc, Unassigned)

References

Details

(Keywords: meta)

Attachments

(1 file, 2 obsolete files)

Some people think that the autoscroll version in AiO is "better" and should be
the basis for the "standard" one in FireBird. See
http://forums.mozillazine.org/viewtopic.php?t=14971&postdays=0&postorder=asc&start=10

As the author if AiO Autoscroll enhancements, I ported the AiO autoscroll in
browser.xml. See attachment in next post.

Enhancements:
  - smooth scrolling speed changes (so called pseudo-logarithmic).
  - better "something to scroll" detection: ability to scroll in divs with
overflow: auto, textareas, etc.
Attached patch Patch against 07-06 browser.xml (obsolete) — Splinter Review
Comment on attachment 127429 [details] [diff] [review]
Patch against 07-06 browser.xml

Blake, can you take a look at this?
Attachment #127429 - Flags: review?(blaker)
Attachment #127429 - Attachment is obsolete: true
Attachment #127429 - Flags: review?(blaker)
--> enhancement
Severity: normal → enhancement
This also fixes bug 212072.
I think this bug is more than just an enhancement because it fixes two other bugs.
Steffen:
That's right.

-> OS: Windows
Tweaking summary to be a meta bug.
Severity: enhancement → normal
Depends on: 211858, 212072
Keywords: meta
OS: All → Windows XP
Summary: Use "better" Autoscroll for Firebird → [META] Use "better" Autoscroll for Firebird
Depends on: 212002
Blocks: 212000
Depends on: 213250
The patch is bit-rotted because Blake modified browser.xml twice since then. I
wonder why he's fixing the bugs of the native autoscroll instead of just
switching to the AiO one.
We are still investigating to switch AiO. Please wait for a while. Thanks.
checked in by noririty between 03:34 and 04:21 today.
Depends on: 213496
No longer depends on: 213496
Depends on: 213496
Depends on: 213726
but why isn't it marked FIXED then?
Because it's a meta bug. Fixing this depends on all the dependant bugs being fixed.
backing out AiO because of performance and some event handling issues.
Depends on: 215825
When/if AiO's implementation gets ported, we should make sure that bug 213250 is
fixed in that extension's code, too. I first noticed it in the extension, and
found it again in a recent nightly. See my comment at
http://bugzilla.mozilla.org/show_bug.cgi?id=213250#c7 on how to fix it (for the
current non-AiO impl).
We also have to do something about the conflicting nature of autoscroll and
contentLoadURL in Linux, particularly since both are enabled by default. Right
now it's simply a usability nightmare as they fight each other.

In bug 216899 I suggest a solution that will allow both features to co-exist and
not conflict. How difficult this will be to code I'm not sure, but it does
involve giving precedence to contentLoadURL rather than autoscroll (autoscroll
currently seems to have precedence in most cases).
Depends on: 216899
OS: Windows XP → All
QA Contact: asa
Summary: [META] Use "better" Autoscroll for Firebird → [META] Use "better" Autoscroll for Firefox
Depends on: 218686
Depends on: 242466
Depends on: 240363
Depends on: 215762
Depends on: 203878
Depends on: 216035
Depends on: 223542
Depends on: 232882
Depends on: 242621
Depends on: 238923
Bug 242621 has been filed for moving the autoscroll icon out of the DOM, which
would solve at least five of the above bugs.
Depends on: 239212
Depends on: 253085
Depends on: 251903
Depends on: 247260
Robert, would this include not being able to scroll with wheel or autoscroll AT
ALL in e.g. DIVs with overflow=scroll? Or is this a separate bug?
Depends on: 260782
No longer blocks: 212000
Depends on: 212000
No longer depends on: 260782
Depends on: 260782
No longer depends on: 253085
No longer depends on: 251903
Depends on: 251903
Depends on: 269798
*** Bug 291134 has been marked as a duplicate of this bug. ***
Attached file Sorry (obsolete) —
Test it
Attachment #181968 - Flags: superreview+
Attachment #181968 - Attachment description: Test it → Sorry
Attachment #181968 - Attachment filename: README.txt
Attachment #181968 - Attachment is patch: false
Attachment #181968 - Flags: superreview+
Attachment #181968 - Attachment is obsolete: true
Depends on: 296080
QA Contact: general
Assignee: bross2 → nobody
With bug 242621 fixed, we have a "better" autoscroll.  A couple deps for this bug are still open, but it might be ok to resolve this metabug.
Depends on: 1752081
Severity: normal → S3

The dependencies of this are all fixed and hasn't been used in ages.

Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: