304003 - Bfcache does not work anymore

Status: VERIFIED FIXED

(Core :: DOM: Navigation, defect, P1)

Description

[Ria Klaassen (not reading all bugmail)]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b4) Gecko/20050809 Firefox/1.0+
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b4) Gecko/20050809 Firefox/1.0+

When I click Back Firefox does no go to the previous page.
In order to go back I need to click Go after Back. Then it loads the page twice.
Also setting browser.sessionhistory.max_viewers to 0 works.

Reproducible: Always

Steps to Reproduce:
1. Click a link on a page.
2. Click Back


Actual Results:  
Firefox shows a white page, although the right URL appears in the location bar.

Expected Results:  
Grab the page from the cache and show it.

Comment 1

[Ria Klaassen (not reading all bugmail)]

Regression between 2005080808 and 2005080822.

Comment 2

[Ryuichi KUBUKI]

*** Bug 304011 has been marked as a duplicate of this bug. ***

Comment 3

[Christian :Biesinger (don't email me, ping me on IRC)]

bonsai query for that regression range:
http://bonsai.mozilla.org/cvsquery.cgi?treeid=default&module=all&branch=HEAD&branchtype=match&dir=&file=&filetype=match&who=&whotype=match&sortby=Date&hours=2&date=explicit&mindate=2005-08-08+07%3A00&maxdate=2005-08-08+23%3A00&cvsroot=%2Fcvsroot

Comment 4

[snip4]

In the latest hourly builds, when press the back button, the page don't load,
and press the stop button and firefox crash, everytime

This behaviour since 2005080822 'till now (2005080903) is very anonying.

Somebody happens?

Comment 5

[Ashley Bischoff (blog at handcoding.com)]

Would the "smoketest" keyword be applicable here? If bfcache is enabled by
default (?), this would appear to hinder smoketest item #B.14.
http://www.mozilla.org/quality/smoketests/

Comment 6

[Christian :Biesinger (don't email me, ping me on IRC)]

restoring presentation from session history: http://www.mozilla.org/start/
++DOMWINDOW == 9
WARNING: NS_ENSURE_TRUE(holder) failed, file
../../../../../mozilla/dom/src/base/nsGlobalWindow.cpp, line 6638
WARNING: NS_ENSURE_TRUE(NS_SUCCEEDED(rv)) failed, file
../../../../mozilla/docshell/base/nsDocShell.cpp, line 5287
###!!! ASSERTION: RestoreFromHistory failed: 'NS_SUCCEEDED(rv)', file
../../../../mozilla/docshell/base/nsDocShell.cpp, line 4935
Break: at file ../../../../mozilla/docshell/base/nsDocShell.cpp, line 4935
###!!! ASSERTION: RestoreFromHistory failed: 'NS_SUCCEEDED(rv)', file
../../../../mozilla/docshell/base/nsDocShell.cpp, line 4935
Break: at file ../../../../mozilla/docshell/base/nsDocShell.cpp, line 4935

Comment 7

[Christian :Biesinger (don't email me, ping me on IRC)]

nsGlobalWindow.cpp, in nsGlobalWindow::RestoreWindowState
   6637   nsCOMPtr<WindowStateHolder> holder = do_QueryInterface(aState);
   6638   NS_ENSURE_TRUE(holder, NS_ERROR_FAILURE);


nsDocShell.cpp
   5286     rv = privWin->RestoreWindowState(windowState);
   5287     NS_ENSURE_SUCCESS(rv, rv);

Comment 8

[Christian :Biesinger (don't email me, ping me on IRC)]

caused by bug 298459?

Comment 9

[Christian :Biesinger (don't email me, ping me on IRC)]

there's also this warning while saving the state:
WARNING: NS_ENSURE_TRUE(rv) failed, file
../../../../../mozilla/dom/src/base/nsGlobalWindow.cpp, line 6610

at:
   6606 #ifdef DEBUG_PAGE_CACHE
   6607   printf("saving window state, stateObj = %p\n", (void*)stateObj);
   6608 #endif
   6609   nsresult rv = CopyJSProperties(cx, mJSObject, stateObj);
   6610   NS_ENSURE_TRUE(rv, rv);

Comment 10

[Christian :Biesinger (don't email me, ping me on IRC)]

   6610   NS_ENSURE_TRUE(rv, rv);

should be SUCCESS, not TRUE

Comment 11

[Christian :Biesinger (don't email me, ping me on IRC)]

Attachment: patch

Comment 12

[Jaime Mitchell (use [e-mail] for email)]

*** Bug 304057 has been marked as a duplicate of this bug. ***

Comment 13

[Simon Fraser [no longer active]]

Comment on attachment 192098 [details] [diff] [review]
patch

Can we get this reviewed an in?

Comment 14

[Chase Phillips]

Comment on attachment 192098 [details] [diff] [review]
patch

a=[e-mail]

Comment 15

[Christian :Biesinger (don't email me, ping me on IRC)]

for reference:
2005-08-09 14:29	timeless%mozdev.org 	mozilla/ dom/ src/ base/
nsGlobalWindow.cpp 	1.759 	2/2  	Bug 304003 Bfcache does not work anymore patch
by biesi r=bryner sr=smfr a=chase

Comment 16

[Darin Fisher]

*** Bug 304090 has been marked as a duplicate of this bug. ***

Comment 17

[Adam Guthrie]

*** Bug 304086 has been marked as a duplicate of this bug. ***

Comment 18

[Adam Guthrie]

*** Bug 304108 has been marked as a duplicate of this bug. ***

Comment 19

[Stephen Donner [:stephend] Not actively reading bugmail]

*** Bug 304116 has been marked as a duplicate of this bug. ***

Comment 20

[Uri Bernstein]

*** Bug 304134 has been marked as a duplicate of this bug. ***

Comment 21

[Tracy Walker [:tracy]]

Verified with Linux and Windows builds from 2005-08-10