305020 - Allow Dynamic dictionary switching from the compose window

Status: RESOLVED FIXED

(Thunderbird :: Message Compose Window, defect)

Description

[Scott MacGregor]

Add a drop down to the spell check button which will allow you to change
dictionaries on the fly.

Switching the dictionary will cause us to load the new dictionary and if inline
spell check is turned on, re-check text using the new dictionary.

Spun out from Bug #280825

Comment 1

[Scott MacGregor]

Attachment: the fix

Dynamically populates a drop down for the spell check button which lists the
current dictionaries. 

I'm tempted to ditch the UI in the preferences window that lets you switch the
language as well.

Comment 2

[Scott MacGregor]

this change really needs the memory leak fix from Bug #305017

Comment 3

[Scott MacGregor]

fixed on the trunk. I'm going to leave it open for a day to see how it shakes
out before putting on the branch.

Comment 4

[Jo Hermans]

*** Bug 300077 has been marked as a duplicate of this bug. ***

Comment 5

[Jo Hermans]

*** Bug 300896 has been marked as a duplicate of this bug. ***

Comment 6

[Jo Hermans]

(In reply to comment #3)
> fixed on the trunk. I'm going to leave it open for a day to see how it shakes
> out before putting on the branch.

Actually, I think you checked this in the branch ...

Comment 7

[Scott MacGregor]

so I did. It's now on the trunk too.

Comment 8

[Peter Lairo]

(In reply to comment #1)
> I'm tempted to ditch the UI in the preferences window that lets you switch the
> language as well. 

That is a good idea (cleans up the pref dialogs). However, users might remove
the "Spell" toolbar button (to save space). Therefore, there should be the
ability to switch the language for the menus:

| Options |
   Spelling Language > English / United States
                       German / Germany
                       --------------------------
                       Download More Dictionaries

Comment 9

[Tuukka Tolvanen (sp3000)]

(In reply to comment #8)
> That is a good idea (cleans up the pref dialogs). However, users might remove
> the "Spell" toolbar button (to save space). Therefore, there should be the

Speaking of which, did this break message compose when Spell is not on the
toolbar (bug 306379)?

Comment 10

[Adam Guthrie]

*** Bug 352975 has been marked as a duplicate of this bug. ***