305089 - Don't mark as scam any mail composed by user (Drafts, Templates, Sent, Outbox folders)

Status: RESOLVED FIXED

(Thunderbird :: Mail Window Front End, defect)

Description

[Matjaz]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.10) Gecko/20050716 Firefox/1.0.6
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.10) Gecko/20050716 Firefox/1.0.6

Saving an email as a draft results in TB marking it as possible scam if it
contains a link to a any site written as IP address instead of domain name. This
is also the case if the linki is local intranet address.

Reproducible: Always

Steps to Reproduce:
1. Create a new email.
2. Enter any address as IP: http://10.12.25.99
3. Save it
4. Open this email in drafts folder

Actual Results:  
Thunderbird thinks this email is scam

Expected Results:  
Email messages that are composed by a users himself cannot be scams.

Note: TB also marks as possible scams messages that contain links to local
intranet sites. Such messages should not be marked as possible scams, even if
they are received messages.

Comment 1

[Matjaz]

Forgot to mention> I'm using TB version 1.0+ (20050817)

Comment 2

[guanxi]

confrming.

changing summary to make it more general:
was:  Mail in drafts marked as possible scam (address with IP in body)
now:  Don't mark as scam any mail composed by user (Drafts, Sent folders)


In my TB 1.5, it marks e-mails in my Sent folder as Scams.

Comment 3

[Tuukka Tolvanen (sp3000)]

*** Bug 337612 has been marked as a duplicate of this bug. ***

Comment 4

[Tuukka Tolvanen (sp3000)]

on the other hand, fixing this would make it harder to test what will be detected as scam and what won't. bug 308366 and bug 328455 deal with the (local) ip address issue.

Comment 5

[(not reading, please use [e-mail] instead)]

I'm not sure this is really a bug for dveditz.

I think that tbird already special cases certain actions for certain folders (like don't check messages in your trash to see if they are junk.  see http://lxr.mozilla.org/mozilla1.8/source/mailnews/base/util/nsMsgDBFolder.cpp#1892)

scott, perhaps tbird can do the same with the scam detection?

Comment 6

[Scott MacGregor]

See Bug 308366 which made it so we don't mark local IP addresses as scams.

Comment 7

[Daniel Veditz [:dveditz]]

Came to me because originally filed as a security bug. -> default assignee

Comment 8

[Magnus Melin [:mkmelin]]

*** Bug 351787 has been marked as a duplicate of this bug. ***

Comment 9

[Bryan Clark (DevTools PM) [:clarkbw]]

I'm not seeing this happening on Trunk, Shredder.  Can anyone else confirm?

Comment 10

[Magnus Melin [:mkmelin]]

No wonder, the scam detector was broken - bug 452661.

Comment 11

[Magnus Melin [:mkmelin]]

Attachment: proposed fix

Comment 12

[Phil Ringnalda (:philor)]

Please "borrow" the comment from SeaMonkey's copy of this file about how aUrl.folder will throw for a saved .eml - it took me quite a bit of poking to figure out why we were hiding this all away in a try/catch.

And since we don't want to silently swallow any other exceptions, can we test ex, and rethrow if it's anything other than that one expected one? (I didn't look yet at how unhappy IsSpecialFolder is with a null folder, to see if I actually mean "those expected two.")

Comment 13

[Magnus Melin [:mkmelin]]

Attachment: proposed fix, v2

Added the comment and checking we don't hide other than the expected error.

IsSpecialFolder is quite happy with a null folder.

Comment 14

[Phil Ringnalda (:philor)]

Comment on attachment 337524 [details] [diff] [review]
proposed fix, v2

Looks good to me, thanks!

Comment 15

[Magnus Melin [:mkmelin]]

changeset:   307:55c2a5ba26b6
http://hg.mozilla.org/comm-central/rev/55c2a5ba26b6

->FIXED

Comment 16

[Dave Jarvis]

This issue appears to have resurfaced.

Replicate

1. Compose a new message to a friend, such as:

From https://www.upwork.com/o/jobs/job/_~014308dd0e75d018fd/ :

https://s3.amazonaws.com/stuffpub/brief-charcter-rig-1.swf
https://s3.amazonaws.com/stuffpub/brief-charcter-rig-2.swf

2. Click "Send".
3. Click "Send Mail".

Expected Results

Message is not marked as a possible scam.

Actual Results

Message is marked as a possible scam.

Comment 17

[Dave Jarvis]

Sorry, step 3 should be:

3. Click "Sent Mail".

Using Thunderbird 31.7.0 on Xubuntu Linux.