307340 - [Mac] Disable "Full Screen" UI for 1.5

Status: VERIFIED FIXED

(Firefox :: General, defect, P1)

Description

[Asaf Romano (gone)]

Our full screen support on OS X has some issues which make it almost useless:
 * This is not a real full screen mode, the window is "over-maximized" instead.
 * The window goes under the dock.
 * Parts of the window go offscreen.

We are not going to fix any of those for 1.5.

Comment 1

[Asaf Romano (gone)]

Attachment: patch (UI and Help)

Also removed the tip about Opt+Home on mac although it might work for some
users (we didn't yet #ifdef the Home keyboard shortcut on mac)

Comment 2

[Asaf Romano (gone)]

Comment on attachment 195145 [details] [diff] [review]
patch (UI and Help)

(I didn't #ifdef the fullscreen code in browser.js, mainly in order to make a
possible extension easier).

Comment 3

[Mike Connor [:mconnor]]

Comment on attachment 195145 [details] [diff] [review]
patch (UI and Help)

r=me, this should also be noted in the release notes

Comment 4

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 195145 [details] [diff] [review]
patch (UI and Help)

I'd originally thought "but what about kiosk mode users" until I got a friend's
Mac to see what full screen looked like. :)

r=me

Comment 5

[Asaf Romano (gone)]

Comment on attachment 195145 [details] [diff] [review]
patch (UI and Help)

Better to get this kind of UI change for the first beta.

Comment 6

[Asaf Romano (gone)]

Trunk:
mozilla/browser/base/content/browser-menubar.inc,v  1.63
mozilla/browser/base/content/browser-sets.inc 1.56
mozilla/browser/locales/en-US/chrome/help/firebird-toc.rdf 1.39
mozilla/browser/locales/en-US/chrome/help/menu_reference.xhtml 1.34
mozilla/browser/locales/en-US/chrome/help/shortcuts.xhtml 1.38; 
mozilla/browser/locales/en-US/chrome/help/using_firebird.xhtml 1.31

Comment 7

[Scott MacGregor]

we should not respin beta 1 for this. This is not a stop ship bug. Let's take
this for beta 2.

Comment 8

[Chase Phillips]

Comment on attachment 195145 [details] [diff] [review]
patch (UI and Help)

Per triage meeting, not taking for 1.8b4.  What l10n impact this patch has we
can assume in 1.8b5 when we're ready to take more patches for beta 2.

Comment 9

[Chase Phillips]

blocking1.8b4- per triage meeting.

Comment 10

[Asaf Romano (gone)]

1.8 Branch:
mozilla/browser/base/content/browser-menubar.inc 1.57.2.6
mozilla/browser/base/content/browser-sets.inc 1.51.2.6
mozilla/browser/locales/en-US/chrome/help/firebird-toc.rdf 1.34.2.4
mozilla/browser/locales/en-US/chrome/help/menu_reference.xhtml 1.31.2.3
mozilla/browser/locales/en-US/chrome/help/shortcuts.xhtml 1.34.4.4
mozilla/browser/locales/en-US/chrome/help/using_firebird. 1.29.2.2

Comment 11

[Andre-John Mas]

Question: are there any plans to actually make full-screen work properly in the post 1.5 version?

Comment 12

[:Gavin Sharp [email: [e-mail]]]

(In reply to comment #11)
> Question: are there any plans to actually make full-screen work properly in
the post 1.5 version?

See bug 307371.

Comment 13

[José Jeria]

See also comment 0