308788 - Tabs cannot be closed in recent fx-trunk

Status: VERIFIED FIXED

(Firefox :: Tabbed Browser, defect)

Description

[Nobu Nari]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20050915 Firefox/1.6a1
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20050915 Firefox/1.6a1 ID:2005091523

Recent firefox-trunk does not close tabs with middle-click or context-menu.

Reproducible: Always

Steps to Reproduce:
1. Open tabs
2. Try to close those tabs by middle-click or choose "close tab" from menu.
3.

Actual Results:  
Tabs are not closed

Expected Results:  
Tabs should be closed.

JS error was shown in JS console:

Error: [Exception... "Failure arg 0 [nsIDocShell.contentViewer]"  nsresult:
"0x80004005 (NS_ERROR_FAILURE)"  location: "JS frame ::
chrome://global/content/bindings/tabbrowser.xml :: updateTitlebar :: line 558" 
data: no]
Source File: chrome://global/content/bindings/tabbrowser.xml
Line: 558

Comment 1

[Nobu Nari]

Another error shown in JS console:

Error: uncaught exception: [Exception... "Failure arg 0
[nsIDocShell.contentViewer]"  nsresult: "0x80004005 (NS_ERROR_FAILURE)" 
location: "JS frame :: chrome://global/content/bindings/tabbrowser.xml ::
removeTab :: line 1197"  data: no]

Comment 2

[Nobu Nari]

Tab close works on
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20050915
Firefox/1.6a1 ID:2005091517.
However it does not work on
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20050915
Firefox/1.6a1 ID:2005091520.

Comment 3

[Ria Klaassen (not reading all bugmail)]

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20050915
Firefox/1.6a1 ID:2005091523

I see the same.

Comment 4

[Mike Pesce (:By-Tor)]

Confirmed here: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1)
Gecko/20050916 Firefox/1.6a1 ID:2005091602

Error: uncaught exception: [Exception... "Failure arg 0
[nsIDocShell.contentViewer]"  nsresult: "0x80004005 (NS_ERROR_FAILURE)" 
location: "JS frame :: chrome://global/content/bindings/tabbrowser.xml ::
removeTab :: line 1197"  data: no]

Error: uncaught exception: [Exception... "Failure arg 0
[nsIDocShell.contentViewer]"  nsresult: "0x80004005 (NS_ERROR_FAILURE)" 
location: "JS frame :: chrome://global/content/bindings/tabbrowser.xml ::
updateTitlebar :: line 558"  data: no]

Comment 5

[Thomas K. (:tom)]

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20050916
Firefox/1.6a1 [9/16/2005 1:02:00 PM version]

confirmed, can't middle click close, can't hit x to close, can't right click the
tab to close

Comment 6

[Thomas K. (:tom)]

Only change in g/c/b/tabbrowser.xml this month:
http://bonsai.mozilla.org/cvsview2.cgi?diff_mode=context&whitespace_mode=show&file=tabbrowser.xml&branch=&root=/cvsroot&subdir=mozilla/xpfe/global/resources/content/bindings&command=DIFF_FRAMESET&rev1=1.126&rev2=1.127

Summary of change:
Bug 306810 Fix regressions from bug 302575 r=bz sr=darin

Could this be the problem?  It changed different lines, but it seems to be
related.  I could be way off, I'm new to this.

Comment 7

[(not currently active) Ted Mielczarek]

Not present in 2005-09-15-17-trunk, showing up in 09-16.

I think the regression window is:
http://bonsai.mozilla.org/cvsquery.cgi?treeid=default&module=all&branch=HEAD&branchtype=match&dir=&file=&filetype=match&who=&whotype=match&sortby=Date&hours=2&date=explicit&mindate=2005-09-15+17%3A00%3A00&maxdate=2005-09-16+07%3A00%3A00&cvsroot=%2Fcvsroot

Comment 8

[Brian Polidoro]

(In reply to comment #6)
> Only change in g/c/b/tabbrowser.xml this month:
>
http://bonsai.mozilla.org/cvsview2.cgi?diff_mode=context&whitespace_mode=show&file=tabbrowser.xml&branch=&root=/cvsroot&subdir=mozilla/xpfe/global/resources/content/bindings&command=DIFF_FRAMESET&rev1=1.126&rev2=1.127
> 
> Summary of change:
> Bug 306810 Fix regressions from bug 302575 r=bz sr=darin
> 
> Could this be the problem?  It changed different lines, but it seems to be
> related.  I could be way off, I'm new to this.

Both of those bugs were only checked into the Suite's tabbrowser.xml.

Comment 9

[Phil Ringnalda (:philor)]

If anyone's got a build setup and some free time, I'd be interested in seeing if
a local backout of the patch from bug 20022 fixes it.

Comment 10

[:Gavin Sharp [email: [e-mail]]]

*** Bug 308853 has been marked as a duplicate of this bug. ***

Comment 11

[Blake Kaplan (:mrbkap) (inactive)]

Attachment: fix

This is fallout from bug 308629. DocumentViewerImpl needs to QI to nsISupports.
This has r+sr=dbaron (in person).

Comment 12

[Blake Kaplan (:mrbkap) (inactive)]

Fix checked into TRUNK.

Comment 13

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 196353 [details] [diff] [review]
fix

Yep, r+sr=dbaron.

Comment 14

[Asaf Romano (gone)]

*** Bug 308877 has been marked as a duplicate of this bug. ***

Comment 15

[Ryan Flint [:rflint] (ping via IRC for reviews)]

*** Bug 308955 has been marked as a duplicate of this bug. ***

Comment 16

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED using Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1)
Gecko/20050917 Firefox/1.6a1

Comment 17

[Mugros]

Today i opened several links at the same time with Linky and again all tabs were
not clickable and IIRC not closable. I had to restart the browser.
It was FF 20050917 and in this build this should have been fixed.

Comment 18

[Phil Ringnalda (:philor)]

*** Bug 309354 has been marked as a duplicate of this bug. ***

Comment 19

[Stephen Donner [:stephend] Not actively reading bugmail]

*** Bug 309457 has been marked as a duplicate of this bug. ***

Comment 20

[Dave Townsend [:mossop]]

*** Bug 310726 has been marked as a duplicate of this bug. ***