Closed Bug 316458 Opened 20 years ago Closed 1 year ago

Undo-close-tab function

Categories

(Camino Graveyard :: Tabbed Browsing, enhancement, P2)

Product:
Camino Graveyard
Component:
Tabbed Browsing
Platform:
All
macOS
Type:
enhancement

Tracking

(Not tracked)

Status:
RESOLVED INCOMPLETE

People

(Reporter: brodie.allum, Unassigned)

References

Details

User-Agent: Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.8) Gecko/20051108 Camino/1.0b1 Build Identifier: Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.8) Gecko/20051108 Camino/1.0b1 Is it time to think about adding one with functionality similar to the undoclosetab extension in Firefox? Reproducible: Always Steps to Reproduce:
Summary: Undo-close-tab function. → Undo-close-tab function
Just to follow up on this RFE, it would allow a user to undo the last closed tab. This shouldn't use the standard "Undo" shortcut, however (cmd-z) as that would complicate the Camino-global-undo list. While I've seen this mentioned in the forums a bit, I don't recall it ever being filed. As such... Confirming as RFE.
Status: UNCONFIRMED → NEW
Ever confirmed: true
Target Milestone: --- → Future
(In reply to comment #1) > Just to follow up on this RFE, it would allow a user to undo the last closed > tab. This shouldn't use the standard "Undo" shortcut, however (cmd-z) as that > would complicate the Camino-global-undo list. Actually it lets you reopen more than one (the tab cache size can be specified in about:config). Also, the extension in question: https://addons.mozilla.org/extensions/moreinfo.php?application=firefox&category=Tabbed%20Browsing&numpg=10&id=58
Should we combine this with the saved-session-state patch? The two functionalities seem fairly closely related. cl
That kind-of sounds like the last part of Jasper's bug 152147 comment 34. If we implement the "invisible bg autosave" type of session-saving, then it seems this would fit in very well, except you'd have to be careful not to purge the last tab/page from the state immediately, or something like that.
Good news! This has already been implemented in testing releases of Firefox 2.
(In reply to comment #5) > Good news! This has already been implemented in testing releases of Firefox 2. This bug is for Camino. The two use totally different GUI implementations. cl
*** Bug 359692 has been marked as a duplicate of this bug. ***
This is one of the items on the 1.2 shortlist right now, so targeting appropriately.
Target Milestone: Future → Camino1.2
Assignee: mikepinkerton → nobody
QA Contact: tabbed.browsing
Please make it remember several recently closed tabs, instead of only the last one: say, the last ten. And I guess they should survive crashes and restore from saved sessions too.
(In reply to comment #9) > And I guess they should survive crashes and restore from saved sessions too. No, they shouldn't. Undo stacks have never persisted across quit and relaunch in OS X.
OK. Not saying it should matter, but they do in Firefox though AFAICR. I guess closing a (few) tab(s) by mistake then experiencing a crash before having realized that mistake may be considered too much bad luck!
Syncing priority per meet-up notes. See also bug 381814.
Priority: -- → P2
Just wanted to add my voice to the call for a recently closed tabs option like in Firefox. Cheers.
Please use voting, not commenting, to express support for feature requests, as explained in the bugzilla guidelines.
Pushing off.
Target Milestone: Camino1.6 → ---
Firefox has a keyboard shortcut for restoring the most recently closed tab (Cmd+Shift+T). Now that Bug 419578 has been fixed, perhaps we could look into providing this same functionality. It would have to be a different shortcut, as Cmd+Shift+T is already used. The Recently Closed Pages menu would need to be modified to add the shortcut (and alternates) to the topmost entry. It would also need to remove an entry when it is opened. The shortcut would probably have to be wired up so it always opens in a new tab/window, so as to enable 'rapid fire' undoing of multiple closed pages.
I guess this never made it into the bug, but I'm extremely hesitant to add a feature called anything suggesting "undo" unless we actually serialize the page, including any text that has been entered, and can actually restore it, rather than just loading the URL again. That's why I spun off bug 419578, which is implemented in a way that doesn't suggest an undo capability that we don't yet have.
Safari 5 does this as-is. It uses "Undo" but implements it basically like putting a Cmd-Z shortcut on our most recently closed tab item. http://www.macworld.com/article/152042/2010/06/safari5tips.html Is this a case where the perfect is the enemy of the good? I dunno. I see Stuart's argument, certainly, that it isn't a true "undo", but it's also a case where even an incomplete implementation is better than nothing at all for most people.
Hardware: PowerPC → All
The important thing to me is that there is *some* keyboard shortcut, not that it necessarily be the "undo" shortcut. If it's a Safari "secret" anyway, it doesn't seem like users would necessarily expect the shortcut cmd-z to reopen closed tabs in the first place. Firefox uses shift-cmd-T, which seems not bad to me.
Doing a quick test of this new Safari functionality: it reopens the (most recently) closed tab alright, however it doesn't remember the state of the page (tested with some filled form fields). Similar with pages that do some ajaxy loading after the full page has loaded. Personally I'd prefer a dedicated keyboard shortcut to reopen the most recently closed tab, which is bug 520840.
(In reply to comment #18) > I guess this never made it into the bug, but I'm extremely hesitant to add a > feature called anything suggesting "undo" unless we actually serialize the (There's also a long argument on irc between froodian, smorgan, and me about whether Undo Close Tab belongs in the Undo stack or not.) All of this is neither here nor there right now, though, since we don't have an Undo Close Tab feature; there's no need to debate a shortcut for a non-existant feature. (In reply to comment #19) > Stuart's argument, certainly, that it isn't a true "undo", but it's also a case > where even an incomplete implementation is better than nothing at all for most > people. We *do* have an "incomplete implementation" that's been better than nothing at all for almost two years now; it was bug 419578. Bug 520840 is about giving it a shortcut.
Status: NEW → RESOLVED
Closed: 1 year ago
Resolution: --- → INCOMPLETE
You need to log in before you can comment on or make changes to this bug.