318991 - brand.dtd shouldn't hardcode the version number in releaseURL

Status: RESOLVED FIXED

(Firefox :: General, defect)

Description

[Steffen Wilberg]

Follow-up to bug 307462 comment 9 and bug 307462 comment 10.

Comment 1

[Steffen Wilberg]

Attachment: Trunk patch

Comment 2

[Benjamin Smedberg]

Comment on attachment 204928 [details] [diff] [review]
Trunk patch

I love you.

Comment 3

[Steffen Wilberg]

Checked in.

Comment 4

[Steffen Wilberg]

Attachment: 1.8 branch patch

The trunk patch doesn't apply cleanly, so here's a branch patch.

Comment 5

[Steffen Wilberg]

I guess about: in Firefox 2 shouldn't link to the Firefox 1.5 release notes, so requesting blocking-firefox2.

Comment 6

[Steffen Wilberg]

*** Bug 287477 has been marked as a duplicate of this bug. ***

Comment 7

[Steffen Wilberg]

1.8 branch:
Checking in mozilla/toolkit/content/about.xhtml;
/cvsroot/mozilla/toolkit/content/about.xhtml,v  <--  about.xhtml
new revision: 1.8.8.1; previous revision: 1.8
done
Checking in mozilla/other-licenses/branding/firefox/locales/en-US/brand.dtd;
/cvsroot/mozilla/other-licenses/branding/firefox/locales/en-US/brand.dtd,v  <--  brand.dtd
new revision: 1.1.8.2; previous revision: 1.1.8.1
done

Comment 8

[Axel Hecht [:Pike]]

This is a semantic change and busts all builds. Note that not all locales use
URLs that go nicely with this change, too.
http://lxr.mozilla.org/l10n-mozilla1.8/search?string=releaseURL is the current
state of the l10n tree.

Using something like releaseBaseURL sounds better.

Comment 9

[Steffen Wilberg]

It busts all builds that don't pick up this change. So I'll change the key to releaseBaseURL to force them to do that. Looks like it's a good idea anyway since quite a few still link to 1.0.html.

Comment 10

[Steffen Wilberg]

Attachment: change the entity to releaseBaseURL

I also added a localization note.

Comment 11

[Axel Hecht [:Pike]]

Comment on attachment 213089 [details] [diff] [review]
change the entity to releaseBaseURL

add a 

,e.g. "2.0.html"

to the localization note? And make that __MOZ_APP_VERSION__, if localizers see variable substitution, it should match the pattern.

I'm not sure about sq, could you file a good follow-up bug for http://lxr.mozilla.org/l10n-mozilla1.8/source/sq/browser/chrome/help/firefox_welcome.xhtml#41 ? I don't know what that should look like from a help point of view.

Comment 12

[Steffen Wilberg]

Checked in branch and trunk, with comment addressed.

Comment 13

[Steffen Wilberg]

And as for the sq locale, the bug would be "wake up from hibernation and update your locale from 1.0.6 to 1.5" ;-)

The 1.5 Help welcome page (the one that appears when you press F1) doesn't contain the release notes link anymore. That was bug 277328, checked in 2005-05-05. The current version is this: http://lxr.mozilla.org/mozilla1.8/source/browser/locales/en-US/chrome/help/firefox_welcome.xhtml

Comment 14

[Steffen Wilberg]

Or in other words, sq is not affected since I didn't touch the AVIARY_1_0_1_20050124_BRANCH.

Comment 15

[Nickolay_Ponomarev]

Attachment 213089 [details] [diff] caused bug 329130.

I attached a patch to fix the issue with about: in a firefox build without branding, but I'm not sure what other uses of releaseURL need to be updated: http://landfill.mozilla.org/mxr-test/mozilla/search?string=releaseURL&regexp=on&find=&filter=releaseURL