319649 - "Reset Camino" should reset the last visited date on bookmarks, too

Status: RESOLVED FIXED

(Camino Graveyard :: General, defect)

Description

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

In bug 319491 comment 5, Stuart wrote:

Last visit is history information as well, and should also be cleared--whatever
"cleared" means, since I'm guessing a nil date will cause issues.  Maybe
setting the date to the epoch and special casing the display of that value in
the info window?

Comment 1

[Håkan Waara]

Attachment: Simple fix

Smokey/SS, can any of you just test this that it looks OK in the UI too?

Comment 2

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Comment on attachment 212799 [details] [diff] [review]
Simple fix

No, we really need to do what Stuart said in the comment I quoted above; that is, once you reset the date to whatever, then transform it to "Never" (as a localizable string, of course).

Right now it displays as "Mon, 1 Jan 1, 19:00" (I guess that's based on the date prefs loc'l string), but that's not a true value (and it's ugly, to boot)

r- based on that ;)

Comment 3

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Another question to debate: should we be resetting this info when we clear history, too?  This is clearly history information of some sort, but it's also bookmarks info, and where is the line?  Some users might expect it to be cleared when they clear history, and others might be surprised that clearing history affects their bookmarks (and Top 10).

Or do we all agree to punt on finding that line and only handle this in Reset Camino?

Comment 4

[Stuart Morgan]

(In reply to comment #3)
> Another question to debate: should we be resetting this info when we clear
> history, too?

Yes

Comment 5

[Chris Lawson (gone)]

See also bug 300408 comment 4 (pink votes against clear-when-clearing-history) and bug 300408 comment 9 (smfr votes weakly against).

For what it's worth, I don't much care either way, but I'm leaning slightly toward clearing visit counts along with history.

cl

Comment 6

[Mark Mentovai]

Bug 411338 will fix this.

(In reply to comment #3)
> Or do we all agree to punt on finding that line and only handle this in Reset
> Camino?

That line is:

http://bonsai.mozilla.org/cvsblame.cgi?file=/mozilla/camino/src/application/MainController.mm&rev=1.248&mark=1015-1016,1467-1472#1456

The "Clear History…" button in the History preference pane currently has its own implementation, but that's scheduled to change in bug 410030.

Stuart and Smokey, above, seem to think that this is the right thing to do (and I mostly agree), but Mike and Simon were against clearing bookmark visit info when clearing history in bug 300408 comment 4 and bug 300408 comment 9.

Comment 7

[Mark Mentovai]

Fixed by bug 411338.  Clearing the visit count, which "Reset Camino" always did, also sets the last visit time to "never".