32360 - View Frame Source is broken

Status: VERIFIED FIXED

(SeaMonkey :: UI Design, defect, P1)

Description

[Richard Zach]

Right click on frame and choosing "View frame source" from context menu doesn't
work.

To reproduce:
1. Go to frameset page, e.g., http://socrates.berkeley.edu/~frege
2. Right-click
3. Choose "View frame source"

Actual result: Nothing happens.  Console sez:

JavaScript Error: TypeError: contextMenu.viewFrameSource is not a function

Expected result: source view of frame

Linux build 2000.03.17.09

Comment 1

[Sean Richardson]

Confirmed as reported on WinNT with 2000-03-20-11-M15. The "View Page Source"
item on the context menu for either frame displays the source for the frameset
page, as expected, but the "View Frame Source" item does nothing.
Changing OS to "All".

Comment 2

[sairuh (rarely reading bugmail)]

not a problem using beta1 branch bits (linux, winNT, mac, 2000.03.20.06-nb1b,
opt comm) --so, just to clarify, was this seen in tip builds? thx!

Comment 3

[Sean Richardson]

Yes, the build I used was not an nb1b build.

From comments in bug 29795, "cannot view frame source right", WORKSFORME,
it looks like this was working at the beginning of the month; marking as
regression.

Comment 4

[Richard Zach]

I saw it on a trunk build, not on beta.

Comment 5

[Gervase Markham [:gerv]]

Note related bug 32437. Upping severity (the whole subsystem seems to have 
problems) and changing to XPApps, as suggested by [e-mail].

Gerv

Comment 6

[Bill Law]

I've fixed this and will be checking it in soon.  Some code got deleted from 
nsContextMenu.js.  I've put it back and have tweaked it to match the new view 
source strategy.

Comment 7

[Gervase Markham [:gerv]]

View Frame Source does precisely nothing on 20000328 W95 or NT. (It does work in 
the commercial beta, though ;-)

Gerv

Comment 8

[Bill Law]

I'll check it in "soon," just not *that* soon :-).  I'll mark this 
resolved-fixed as soon as I do.  Priority is on some beta2 feature work at the 
moment.

Comment 9

[don]

Move to M16 ... when Bill can get to it ... I hope ...

Comment 10

[Martin Horwath]

insert following code in nsContextMenu.js at line 272

    // Open new "view source" window with the frame's URL.
    viewFrameSource : function () {
    window.openDialog(	"chrome://navigator/content/viewSource.xul",
			"_blank",
			"chrome,dialog=no",
			this.target.ownerDocument.location.href);
    },

ripped an a little bit modified from
http://bonsai.mozilla.org/cvsview2.cgi?diff_mode=context&whitespace_mode=show&subdir=mozilla/xpfe/browser/resources/content&command=DIFF_FRAMESET&file=nsContextMenu.js&rev1=1.13&rev2=1.14&root=/cvsroot

Tested with Build ID: 2000041008 on WinNT - works perfectly ;-)

Comment 11

[Gervase Markham [:gerv]]

[e-mail] or anyone else - there's an easy kill for you here...

Gerv

Comment 12

[David Hallowell]

*** Bug 36340 has been marked as a duplicate of this bug. ***

Comment 13

[R.K.Aa.]

*** Bug 37325 has been marked as a duplicate of this bug. ***

Comment 14

[don]

Nominating as beta 2 blocker.

Comment 15

[leger]

Putting on [nsbeta2+][6/01] radar.  This work must be done by 06/01 or we may 
pull this for PR2.

Comment 16

[leger]

Changing from [6/01] to [6/15]

Comment 17

[don]

Move to M19.

Comment 18

[R.K.Aa.]

*** Bug 40852 has been marked as a duplicate of this bug. ***

Comment 19

[Bill Law]

Fixed checked in (finally).

Comment 20

[Mike Baptiste]

*** Bug 42126 has been marked as a duplicate of this bug. ***

Comment 21

[sairuh (rarely reading bugmail)]

vrfy 2000.06.14.08-m17 all/all.