324322 - window.open() causes new window to open even when "Open all links in tab" is set.

Status: RESOLVED DUPLICATE of bug 314721

(Firefox :: Tabbed Browser, defect)

Description

[Ryan Jones-Ward [:sciguyryan]]

User-Agent:       Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.8) Gecko/20060120 Firefox/1.5
Build Identifier: Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.8) Gecko/20060120 Firefox/1.5

Found this on accident.Click the image

window.open() causes new window to open even when "Open all links in tab" is set. Is this supposed to occur or should it simply do as links to and force it to open into a new tab and not a new window. Either way thought I'd rep[ort it incase its a bug.

Reproducible: Always

Steps to Reproduce:
1. Go the the link above.
2. Click the image
3.

Actual Results:  
A new window appears.

Expected Results:  
A new tab should appear.

Irrelivant, tested in the latest Dark Park build and the latest Firefox build also.

Comment 1

[Ria Klaassen (not reading all bugmail)]

See Bug 313300.
In about:config you should set browser.link.open_newwindow.restriction to 0.
http://kb.mozillazine.org/About:config

Comment 2

[Ria Klaassen (not reading all bugmail)]

Sorry, incomplete information.
These two prefs together open the window of the URL in a new tab:
user_pref("browser.link.open_newwindow", 3);
user_pref("browser.link.open_newwindow.restriction", 0);

Comment 3

[Robin Monks]

Confirmed.  windows.open() can still open new windows.

Comment 4

[Grant Wohl]

This is the intended behavior. Bug 313300 changed the default value for browser.link.open_newwindow.restriction to "2".

Comment 5

[Adam Guthrie]

*** Bug 357441 has been marked as a duplicate of this bug. ***

Comment 6

[Ria Klaassen (not reading all bugmail)]

*** Bug 357686 has been marked as a duplicate of this bug. ***

Comment 7

[Not interested in Mozilla any more]

This is incorrect behaviour and should be fixed. If the user says they want all new window requests turned into new tabs then Javascript should not be allowed to overrule them. This is especially true in the light of bug 348031, which will not allow you to use command-w to close the new window.