162189 - Ctrl+Enter in URL bar ignores "Load links in the background" pref

Status: RESOLVED WORKSFORME

(SeaMonkey :: Tabbed Browser, defect)

Description

[Jonas Jørgensen]

Build 2002080708, Win2k.

* Make sure the "Load links in the background" Tabbed Browsing pref is turned on.
* Type "mozilla.org" in the URL bar and hit Ctrl+Enter.

Actual results: A new tab opens with focus and loads mozilla.org.

Expected results: A new tab opens in the background and loads mozilla.org.

Comment 1

[Jonas Jørgensen]

See also bug 162193, "Ctrl+Enter in URL bar should load URL in a new window".

Comment 2

[Christian :Biesinger (don't email me, ping me on IRC)]

not sure I agree with this bug. use ctrl+shift+enter to open the tab in the
background... then again... hm...

cc'ing mpt for an opinion on whether this is valid or WONTFIX, and what should
happen for ctrl+shift+enter if "load links in background" is enabled.

Comment 3

[Jonas Jørgensen]

Why Ctrl+Enter should respect the Load links in the background pref:

If I'm reading http://example.com/page1.html and I want to read page2.html
afterwards, I will be able to hit Ctrl+L, change the "1" to "2", hit Ctrl+Enter,
and the page will load in a new background tab. Currently I have to press as
many Ctrl+PageUp/PageDowns as required to get the focus back to the original tab.

Comment 4

[Christian :Biesinger (don't email me, ping me on IRC)]

Jonas: Use Ctrl+Shift+Enter

Comment 5

[Jonas Jørgensen]

But why should I need to hold down Shift while Ctrl+Entering in the URL bar when
I don't need to when clicking a link, Ctrl+Entering a link, etc.?

Comment 6

[Christian :Biesinger (don't email me, ping me on IRC)]

good point indeed; maybe I'll create a patch for that later.

question, should ctrl+shift+enter then load the tab in the foreground, or do the
same as ctrl+enter?

Comment 7

[djk]

I think ctrl-shift-enter should do the opposite of whatever the 'load links in
background' setting specifies.

Comment 8

[Jonas Jørgensen]

djk is right; Ctrl+Shift+Enter should do the opposite of Ctrl+Enter. (That is
consistent with Ctrl+Shift+Enter on a link.)

I might make a patch for this.

Comment 9

[Stefan [:stefanh]]

Mozilla/5.0 (Macintosh; U; PPC; en-US; rv:1.1) Gecko/20020826 (Mac OS 9.1).
I don´t know if I should file this as a (two?) separate bug(s)... There are two
other cases where "Load links in the background" is ignored:
1) File - New - Navigator Tab
2) "Open Web Location" and choosing  selecting open in "New Navigator Tab"

Comment 10

[Jonas Jørgensen]

Interesting:

"foo" + Ctrl+Enter -> load in foreground.
"foo bar" + Ctrl+Enter -> load in background.
"foo bar" + Ctrl+Enter where "foo" is a bookmark keyword -> load in foreground.

Comment 11

[sairuh (rarely reading bugmail)]

see also bug 207678 for the personal toolbar context menu.

Comment 12

[Chris Thomas (CTho) [formerly [e-mail] [e-mail]]]

I don't agree that this should change.  If this were "fixed", I'd have to use ctrl+shift+enter the majority of the time.  WONTFIX?

Comment 13

[[e-mail]]

IMHO it should certainly ignore the main "switch to new tabs opened from links" preference. However, you could argue the case that it should use the "switch to new tabs opened from other applications" preference.

Comment 14

[Philip Chee]

WORKSFORME: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:9.0a1) Gecko/20110824 SeaMonkey/2.6a1