324588 - In-page RSS discovery and dispatch

Status: RESOLVED WORKSFORME

(Firefox Graveyard :: RSS Discovery and Preview, defect)

Description

[Ben Goodger (use ben at mozilla dot org for email)]

Per evolving design doc, show in-page discovery and dispatch UI for clicked feeds.

Do this the right way without any nasty hacks in the browser chrome.

Comment 1

[Ben Goodger (use ben at mozilla dot org for email)]

Attachment: proof of concept, does nothing, works inefficiently

here's a quick javascript hack which does something like this. We might like to re-do this in C++ and use an actual content sink for parsing the RSS, so that we can decide without having to download and parse all the data whether or not something is a feed.

Comment 2

[Phil Ringnalda (:philor)]

First couple of thoughts: you'll need CTYPE_APPLICATIONXML too, and unless you've got a check in hand for the product placement, I think the list of things to do would look better as "Tbird, {program registered with the OS for application/(rss|atom)+xml or feed:// handler}, Live Bookmarks."

Comment 3

[Ben Goodger (use ben at mozilla dot org for email)]

Why so suspicious? :-P

I want to add a generic way for websites to register themselves as the default handler for specific content types... there are many online RSS readers, just like mail readers, pdf/doc/etc viewers and so on. As apps move into the online realm a new kind of helper app is emerging. 

Comment 4

[Ben Goodger (use ben at mozilla dot org for email)]

Attachment: more progress...

this is further along. it now displays a XUL page with chrome privs for application/rdf+xml content. w00t.

Comment 5

[Ben Goodger (use ben at mozilla dot org for email)]

Attachment: patch

moves document analysis into a separate object, implements a feed: protocol handler for consistent user experience clicking on http feed links vs. feed:// links.

Comment 6

[Ben Goodger (use ben at mozilla dot org for email)]

Attachment: separate feed processing out into a separate component

... which over time might become generically useful.

Comment 7

[Ben Goodger (use ben at mozilla dot org for email)]

Attachment: make text/plain work, make atom work

Comment 8

[Ben Goodger (use ben at mozilla dot org for email)]

Attachment: make application/xml work, identify and differentiate between application types

Comment 9

[Ben Goodger (use ben at mozilla dot org for email)]

Attachment: fix http protocol handler assertions, fix js error navigating away from a feed preview

Comment 10

[Ben Goodger (use ben at mozilla dot org for email)]

This relies on some sort of content sniffing so that we can load text/html feeds (sadly, text/html is a fairly common content-type for RSS feeds). 

Comment 11

[Phil Ringnalda (:philor)]

>+  _isFeedRSS10: function() {
>+    if (this._de.namespaceURI == "http://www.w3.org/1999/02/22-rdf-syntax-ns#" || 
>+        this._de.namespaceURI == "http://purl.org/rss/1.0/")

That's not RSS 1.0, it's all RDF/XML. Since you also want to catch RSS 0.90, the other RDF RSS, you probably want something more like

  if (this._de.namespaceURI == "http://www.w3.org/1999/02/22-rdf-syntax-ns#" &&
      (this._de.getElementsByTagNameNS("http://purl.org/rss/1.0/", "channel").length ||
       this._de.getElementsByTagNameNS("http://my.netscape.com/rdf/simple/0.9/", "channel").length))

Comment 12

[Phil Ringnalda (:philor)]

*** Bug 343671 has been marked as a duplicate of this bug. ***

Comment 13

[Søren Munk Skrøder (extended hiatus)]

this is just an idea ... 

but why not put the RSS preview page out in a sidebar instead... that way, people won't experience that they are browsing away from a page just because they've clicked "Subscribe to this page..." in the location bar...

furthermore, the "cleanup" is only to restore the sidebar state to what it was before

Comment 14

[Phil Ringnalda (:philor)]

We're shipping it, apparently it's pretty much done (elsewhere, mostly), and changes to it should certainly be done elsewhere.