325449 - Handle import of existing events intelligently [Error code: DUPLICATE_ID. Description: ID already exists for addItem]

Status: NEW

(Calendar :: General, defect)

Description

[jem.benazra]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; fr; rv:1.8) Gecko/20051111 Firefox/1.5
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; fr; rv:1.8) Gecko/20051111 Firefox/1.5

When I load an event which already exist, it make a failed import error.
I don't know if the message is conform but i'd like to be notify if this event already exist or if the import realy failed

Reproducible: Always

Steps to Reproduce:
1.Import an *.ics event
2.Import the same event
3.

Actual Results:  
Import failed

Expected Results:  
This event already exist

Comment 1

[Dan Mosedale (:dmosedale, :dmose)]

Ultimately, we should actually compare the events being imported to see if they differ.  If they do, the right thing to do is probably pop up a dialog with various different options, including aborting the import, handling the conflicting events one-by-one, allowing the import to always win or lose.  This code can probably be shared, to some extent, with caching/sync code as well.

Comment 2

[Stefan Sitter [:ssitter]]

*** Bug 330547 has been marked as a duplicate of this bug. ***

Comment 3

[Seth]

(In reply to comment #2)
> *** Bug 330547 has been marked as a duplicate of this bug. ***
> 

My bug, 343461,was marked as a dupe of 330547.  now 330547 has been marked as a dupe of this one...but this one doesn't have anything to do with mine...mine is an error where there are no duplicate items in the schedule...trying to import the .ics into a new, empty, calendar...

Comment 4

[Stefan Sitter [:ssitter]]

(In reply to comment #3)
This doesn't matter. It is one database. If the event already exist in that database (even if in another calendar) the error message is shown at the moment.

Comment 5

[Seth]

(In reply to comment #4)
> (In reply to comment #3)
Thanks for clarification, it makes sense now.  i was under the assummption each calendar within the program was actually separate.

Comment 6

[Matthew (lilmatt) Willis]

carrying over bug 330547's blocking0.3?

Comment 7

[Joey Minta]

Would accept a patch, but we're not going to block on this.

Comment 8

[Ankit Singla]

Each calendar file should be a separate database. In Sunbird 0.2, if I deleted a calendar, it deleted all events with it, too, hence I could re-import an ics file to put it into a new calendar. I can't do that with Lightning.

Comment 9

[Stefan Sitter [:ssitter]]

*** Bug 356913 has been marked as a duplicate of this bug. ***

Comment 10

[Bryce Mozilla Nesbitt]

Import an UPDATED item with an EXISTING UID.  You'll get:
  "1 items failed to import.  The last error was: 2147500037"

The error message proposed above:
  "This even already exists"

Is not the RFC2445 compliant solution.  In this case we've updated the event, so the old entry should be REPLACED.  There really should never be a situation where a UID duplicated, unless it is meant to be an update to the original event (or a harmless duplicate of the same event).

Comment 12

[Gary Kwong [:gkw] [:nth10sd] (NOT official MoCo now)]

jem, could you pls test with the latest trunk / 0.8pre nightlies and see if this issue still occurs?

Comment 17

[[e-mail]]

This is still a problem on Thunderbird 102.11.0 (64-bit) on Ubuntu 23.04; though it was marked as resolved in #497200 due to lack of response.

console.warn: Calendar: There has been an error reading data for calendar: Work. However, this error is believed to be minor, so the program will attempt to continue. Error code: DUPLICATE_ID. Description: ID already exists for addItem

I'd like to help testing out a branch or nightly (if there's a solution in place).

Comment 19

[Meik Neubauer]

This bug is classified as Severity: S3.

The definition of S3 is "Blocks non-critical functionality and a work around exists".

Can somebody please explain what the necessarily existing 'work around' is that justifies the classification?