Closed Bug 327285 Opened 18 years ago Closed 14 years ago

Edit Message As New > Send -- FAILS (Save As Draft/Send Later fails at Edit As New window on multipart/related + multipart/alternative + HTML of cid: to outer structure)

Categories

(Thunderbird :: Message Compose Window, defect)

Product:
Thunderbird
Component:
Message Compose Window
Platform:
x86
Windows XP
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED INCOMPLETE

People

(Reporter: fwsfws, Unassigned)

References

(Blocks 1 open bug)

Details

(Whiteboard: closeme 2010-11-15)

Attachments

(1 file)

Problem messge as it appears in trash folder
42.84 KB, application/octet-stream
Details 
User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.0.1) Gecko/20060111 Firefox/1.5.0.1
Build Identifier: Thunderbird 1.5 (Windows/20051201)

Editing (deleting previous header info) on a message that contains html code and then attempting to send fails.

Reproducible: Always

Steps to Reproduce:
1. Select message to be edited that contains a significant amount of html code, including external references.
2. delete the previous sender information
3. Click - send

Actual Results:  
Tbird opens a window -- "Sending Messages..."
Status "Attaching op.aspx..."
Progress:  bar keeps moving left to right
After a few minutes, "Cancel" is clicked to stop the process that was not working.

Expected Results:  
I expect the message to be sent

I will be happy to send the original message that was being edited if you want to use it for testing.
I am still having the problem with Edit Message as New.  I have a very simple message that I cannot edit as new.  However, I can copy the complete content that includes a photo, paste it into a new messge, save the photo from the old, insert it into the new and the new message appears to be identical.  Create the same kind of distribution list, send it to myself.  Receive this new creation and Edit it as NEW works fine.

If interested, I will be happy to send the original message to examine.  To provide this message the following steps were taken --

1.  empty trash folder
2.  copy message to trash
3.  zip the trash folder containing the file - which is the problem message

I have confirmed that in the trash folder, opening the messge and trying to edit it as new still gives the error.

To reconstruct the problem unzip this file which has the name trash.
Replace the existing TRASH folder (file) with this one.
open the messge to confirm its integrity.
Try to edit as new and it should fail.

I will be happy to forward the zip file to someone interested in working on this problem.

2008-03-19-2221
Version: unspecified → 2.0
Summary: Edit Message As Net > Send -- FAILS → Edit Message As New > Send -- FAILS
This is the message referenced in my previous post.
My version of Tbird is version 2.0.0.12 (20080213)
The problem still occurs.

Is this something that someone will look into in the foreseeable future?

I have more messages that are a problem.
Keywords: qawanted
Attempted to Edit Message as New 04/24/08.  Immediately saved the message - successfully.  The BCC: address was to me.  BCC was changed to TO.  Attempted to save the message again and it failed.

The only change to the message BCC changed to TO.  The e-mail address field was not changed.

I've learned to make frequent saves to preserve progress to that point.  In this situation, there is no progress.

Failure message - 
Unable to save your message as draft.
There was an error attaching.  Please check if you have access to the file.

version 2.0.0.14 (20080421)
Have modified the message to delete extraneous stuff and added to the distribution list.

Got the message --
Unable to save your message as draft.
There was an error attaching.  Please check if you have access t the file.

This is getting to be aggravating.  After names are added to the distribution list, then the error condition.  What is worse, there is no way to retrieve what has been typed.  It must be retyped.

I do not understand why you still have this classified as UNCONFIRMED.

This has gone on for over TWO YEARS.

Would it help to have the Severity raised?
A procedure that has worked.  

1.CTRL-E (Edit message as new)
2.save message – to confirm that there are no problems.
3.Cleanup any items in body that are not desired
4.save message – to confirm that there are no problems
5.delete names in original distribution list
6.save message – to confirm that there are no problems
7.start a new message – this will contain the distribution list
8.enter names for the distribution list
9.save distribution list message
10.CTRL-U on this distribution list message
11.select and copy the names in the distribution list to clip board
12.paste names into microsoft word – text only
13.run macro to clean up distribution list.  This removes paragraph marks and inserts commas between names.
14.Select new distribution list and copy to clip board
15.go back to message being edited and paste this new distribution list
16.Hit Enter to have names moved to their own line
17.save message – to confirm that there are no problems

If this last save is successful, then the message can be sent.

If any of the intermediate saves fail, the last successful save is opened and that version is edited more carefully.  After each slight edit to the message, it is saved.


After Ctrl-E is pressed to initiate the new message, it was saved successfully.

The old distribution list was deleted and the message saved successfully.

4 or 5 names were added to the distribution list.  When I tried to save, failure.

The names were removed, back to the last successful save.  However, the attempt to save failed.  It appears that whatever the issue is, once triggered, it is not reversible by going back to a know good state.
Addendum to 2008-05-23 19:59:42 PDT

The intent was to send this to another e-mail account for testing on a Vista system.

Ctrl-E
Save. Successful
Change e-mail address of recipient.  Save.  Succesful.
noticed it was BCC so it was changed to "To"  Save - Failure.
Ctrl-E
Saved message - successfully
Left the name in BCC and changed the name to where I wanted it to go.
Saved successfully.

Attempted to send.  Failure.
It could not be saved either at this point.
Ctrl-E
Changed name in BCC field to where I wanted it to go.  DID NOT try to save.
SEND
The send was successful.

The only difference between this attempt and the last, no save.
The send that was "successful" did not include the body of the message.

The original message was 84kb.  The message that was sent was 1kb.

Thunderbird stripped the body from the message.  My SENT folder has the 1kb message too.  NOTHING was done to remove the body on my part.

version 2.0.0.14 (20080421)
it will help if you can test with trunk build and report those results
 ftp://ftp.mozilla.org/pub/thunderbird/releases/3.0a1/
 
choose custom install as described http://kb.mozillazine.org/Testing_pre-release_versions

The problem still exists in version 2.0.0.16 (20080708).  Thunderbird version 3.0a1 (2008050715) was loaded.  It exhibited the same problem with the same message.

I will be happy to provide this message to someone willing to look at it.  However, I am NOT willing to post it in a public forum.  The e-mail addresses would be public.  If interested, the reference is Subject: Fishing, date Aug 17  2008 to help locate the message.
(In reply to comment #2)
> Created an attachment id=310668
> Problem message as it appears in trash folder

After change "X-Mozilla-Status: 1001 => 0001"(==Undo delete), I could observe problem with Tb Trunk on MS Win-XP SP3.
 - View/Message Body As/Original HTML
 - Compose option : HTML

(1) "Edit As New" of the mail, "Save Ad Draft"
> Save Draft Error
>   Unable to save your message as draft.
>   There was an error attaching.
>   Please check if you have access to the file.
>                                    OK Cancel
(2) Wait for a while with do nothin => following was issued
> Confirm
>   There was a problem including the file http://about/ in the message.
>   Would you like to continue saving the message without the file?
>                                    OK Cancel
(3) Draft mail is is saved
(4-A) (1) to (3) repeats. Same error occurs upon auto-save.
(4-B) "Edit Draft", and "Edit As New" after copy the draft to other folder,
      produced (1) to (3) too.

Confirming.

Mail(HTML portion) is sent with;
> Content-Type: text/html; charset="iso-8859-1"
> Content-Transfer-Encoding: quoted-printable
I guess that (1) corruption of HTML of quoted-printable occurs(known issue), (2) then problem in attachment handling occurs while composing mail data.

WORKAROUND:
(a) "Forward"(as Inline) instead of "Edit As New": quoted-printable is not used
(b) "Forward"(as Attachment): no need to process quoted-printable data

To F W Stone(bug opener):

Please test with "Save As Drat" or "Send Later" instead of "Send", because problem is while constructing mail data, instead of while mail sending.
Please change bug summary to avoid misleading/confusion("Send -- FAILS" tends to mislead)

By the way, you experience this bug very frequently?
If yes, try "Forward(inline)" instead of "Edit As New".
Status: UNCONFIRMED → NEW
Ever confirmed: true
Version: 2.0 → Trunk
"Save as Draft" frequently fails too.  However, all failures have occurred AFTER some change has been made to the message.  In this most recent situation, the original distribution list was being replaced with a different one.  When "Send" was attempted, it failed.

I did try your WORKAROUND (a) Forward as Inline.  That worked,  The original distribution list was removed and mine added.  Thank you.

"Do I experience this bug very frequently?"  It seems that most of the time when I edit a complex message as new.  I had never paid attention to the construction of the original message until now.

I can live with forward Inline, as a work around.

If you have a suggestion as to what this summary should be called, let me know.  It was given the summary title because this was the operation being performed that failed.
Assignee: mscott → nobody
I confirm the problem.
It happens almost evry time if some file is attached to the message.
TB claims "it cannot read the attachement".
Component: General → Message Compose Window
QA Contact: general → message-compose
Summary: Edit Message As New > Send -- FAILS → Edit Message As New > Send -- FAILS (Edit of quoted-printable HTML mail corrupts HTML, then failure in attachment handling occurs)
WFM on:

Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1pre) Gecko/20090624 Shredder/3.0b3pre

Don't know if it is last night's build, or if it is fine on the Mac version. But following the Steps To Reproduce worked for me.
(In reply to comment #17)
> WFM on: (snip)

Jay Moran, WFM with what kind of mail? Have you checked with mail folder file attached to Comment #2 by bug opener? (No need to execute "Send". "Save As Draft" is sufficient.)
Summary: Edit Message As New > Send -- FAILS (Edit of quoted-printable HTML mail corrupts HTML, then failure in attachment handling occurs) → Edit Message As New > Send -- FAILS (Edit of quoted-printable HTML mail corrupts HTML, then failure in attachment handling occurs which causes draft save error)
Okay, WFM if doing what the original Comment #1 described from an IMAP folder.

It also WFM per Comment #1 from a Local Folder.

Now for the simpler steps for what seems to be described in Comment #6 and later comments. There are two different (though likely related) STEPS TO REPLICATE.

Using IMAP Drafts folder the following happens:
1) From a Local Folder, "Edit As New" a message.
2) Save as Draft with you Draft Folder set to an IMAP folder.
3) Saves a copy in the Drafts folder just fine. Image still present.
4) Click Send, image disappears immediately, and get following dialog box: "Send Message Error -- Sending of message failed. There was an error attaching . Please check if you have access to the file."
5) Click OK, Click Send, same thing.
6) Close message compose window.
7) Click on Draft copy and click Edit.
8) Click Send, message Sends just fine.

Using Local Folder Drafts folder the following happens:
1) From a Local Folder, "Edit As New" a message.
2) Save As Draft (set to Local Folders/Drafts)
3) Immediate hangs on dialog box -- Saving Messages, Status: "Attaching..." The image in the signature (cid:image001.jpg) goes to a broken link the moment I click on "Save As Draft".
4) Click "Cancel" and then Send, it hangs on dialog box -- Sending Messages, Status: "Attaching..."

ALWAYS WORKS: If I don't click "Save As Draft" first (and one isn't autosaved), then the Edit As New works as expected no matter what type of "Drafts" folder (IMAP or Local) I have setup in my account. All has to do with the Save As Draft.

ALWAYS WORKS: If I am editing a message that was originally in IMAP, I can save as Draft on IMAP/Drafts OR Local Folder/Drafts and still send without issues.

EXPECTED RESULTS:
Can "Edit As New" and then "Save As Draft" and it actually save a copy as a draft and allow me to edit without losing attachments or the like.
(In reply to comment #19)
> Okay, WFM if doing what the original Comment #1 described from an IMAP folder.
> 
> It also WFM per Comment #1 from a Local Folder.

ARGH! Not Comment #1... the original Description are the steps I was following.

BTW, I'd bet the original submitter had a really short "Auto Save Draft" timer set. Mine is set to 5 minutes, perhaps his was 1 minute and he was always slower than that when he had the problem.
Bug 307023 was closed on 2009-04-15 and verified on 2009-04-26. But problem of this bug with attached mail still occurs with next build.
> Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1pre) Gecko/20090625 Shredder/3.0b3pre
Different issue from Bug 307023 is involved in this bug?
Bug 323092 is relevant?  Bug 348468 is relevant?
No longer blocks: 395936
Structure of attached mail is as follows.
 (A) First part of multipart/related(body part of mail) is multipart/alternative.
 (B) text/html part in nested multipart/alternative refers to
     second part of higher multipart/related via cid:.
(A) is correct structure?
(B) is correct pointing by cid:?
It can be said "mulformed mail", isn't it?
Setting dependency to Bug 348468. 

> Content-Type: multipart/related;
> Part-1 : Content-Type: multipart/alternative; 
>          Part-1-1 : Content-Type: text/plain; charset="iso-8859-1"
>                     Content-Transfer-Encoding: quoted-printable
>          Part-1-2 : Content-Type: text/html; charset="iso-8859-1"
>                     Content-Transfer-Encoding: quoted-printable
>           (HTML has next tag)
>            <IMG=20
>            id=3DMA1.1205963052 title=3D"" height=3D472 alt=3D""=20
>            src=3D"cid:009901c88a23$f817d8e0$566cd0d1@NEWCOMPUTER" width=3D667 =
>            DATASIZE=3D"39949">
> Part-2 : Content-Type: image/jpeg; name="picoftor1.jpg"
>          Content-Transfer-Encoding: base64
>          Content-ID: <009901c88a23$f817d8e0$566cd0d1@NEWCOMPUTER>
Depends on: 348468
FYI.
Next is normal structure.
> Content-Type: multipart/alternative;
> Part-1 : Content-Type: text/plain;
> Part-2 : Content-Type: multipart/related;
>          Part-2-1 : Content-Type: text/html;
>                 (HTML with next tag)
>                  <IMG src=3D"cid:009901c88a23$f817d8e0$566cd0d1@NEWCOMPUTER">
>          Part-2-2 : Content-Type: image/jpeg; name="picoftor1.jpg"
>                     Content-ID: <009901c88a23$f817d8e0$566cd0d1@NEWCOMPUTER>>
quoted-printable was irrelevant. Problem occurs even after next change. 
 (A) Content-Transfer-Encoding: quoted-printable => 7bit
 (B-1) "=20" => " ", (B-2) "=3D" => "="
 (C-1) Remove "=" at line end
 (C-2) Remove some [CRLF]s to avoid split of attribute value
           xxx="... =[CRLF]..." yyy=...
       =>  xxx="... ..." [CRLF] yyy=...

I think problem can be be said as follows.
"Edit As New(in HTML)" can't reach cid: of next tag, if never-well-formed structure of Comment #22, although mail display already has quirks or workaround for the never-well-formed structure.
> <IMG src="cid:009901c88a23$f817d8e0$566cd0d1@NEWCOMPUTER">
Summary: Edit Message As New > Send -- FAILS (Edit of quoted-printable HTML mail corrupts HTML, then failure in attachment handling occurs which causes draft save error) → Edit Message As New > Send -- FAILS (Save As Draft/Send Later fails at Edit As New window on multipart/related + multipart/alternative + HTML of cid: to outer structure)
FYI.
Bug 348468 was problem when structure of Comment #23, which I said "normal"...
A message with this problem --

 Bug 417204 -  false filename (%7C instead of |) for embedded pictures after copy/paste  

will also PREVENT a message from being saved.

I became aware of this from a message I posted --

http://forums.mozillazine.org/viewtopic.php?f=39&t=1530215&p=7721965#p7721965

If an image is dragged into a new message with the image reference path incorrectly formed, the message cannot be saved or sent.  This may be a contributor in this bug 327285.
I think I've found a work around for this problem.  Save the file as .eml.  Re-open the file in Thunderbird.  It seems to work.  I've tried this on two messages and have had success.

I do not know what the process of saving the message does, but the brief experience seem to work.

There is also a post in the forum --

http://forums.mozillazine.org/viewtopic.php?f=39&t=1762465
I was a bit premature on saving as .eml and opening back up in Thunderbird.  I just encountered a message that this process did not work.  However, the message was opened in outlook express and forwarded back to me and I was able to clean up the distribution and process the message as expected.

So... given the situation where you cannot edit or forward and retain the content, save file as .eml, open in outlook express and forward back.  The new message seems to meet the qualifications to be processed either edit as new or forward and maintain content.

It seems reasonable to conclude that there is something in this process that cleans up the file.
Save this might have been fixed by bug 351224. Could you take a few minutes and download the latest nightly ( http://ftp.mozilla.org/pub/mozilla.org/thunderbird/nightly/latest-comm-central/ ), backup your profile and test and let us know if this is fixed or not ?
is  attachment 310668 [details] still a valid testcase?
Keywords: qawanted
Whiteboard: closeme 2010-11-15
RESOLVED INCOMPLETE due to lack of response to last question. If you feel this change was made in error, please respond to this bug with your reasons why.
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → INCOMPLETE
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: