Closed Bug 329544 Opened 15 years ago Closed 15 years ago
Port back mailnews improvements to dynamic 3-pane generation/decks
Bug 326814 for mailnews is hopefully introducing some improvements to dynamic 3-pane generation and decks, this bug will port them back to TB.
This patch: * Moves manipulation of threadpane elements to threadpane functions from accountcentral functions * Rewrites comment for Thread Pane / Account Central * Removes try from ObserveDisplayDeckChange * Swaps order of elements in deck and moves setting of account central page to ShowAccountCentral For more details see bug 326814
Changes since v0.1: * Took on fixes from bug 330198 for SM
Attachment #214254 - Attachment is obsolete: true
Ian, is this patch ready for a code review or are you still tweaking it?
Changes since v0.1a: * Unbitrotted against current trunk I've been testing this on and off but not spotted any problems yet.
Comment on attachment 223684 [details] [diff] [review] Unbitrotted patch v0.1b (Checked in trunk and 1.8 branch) Thanks Iann.
Attachment #223684 - Flags: superreview?(bienvenu) → superreview+
Comment on attachment 223684 [details] [diff] [review] Unbitrotted patch v0.1b (Checked in trunk and 1.8 branch) Checking in (trunk) mailWindow.js; new revision: 1.40; previous revision: 1.39 mailWindowOverlay.xul; new revision: 1.145; previous revision: 1.144 messenger.xul; new revision: 1.58; previous revision: 1.57 msgMail3PaneWindow.js; new revision: 1.86; previous revision: 1.85 done Checking in (1.8 branch) mailWindow.js; new revision: 126.96.36.199; previous revision: 188.8.131.52 mailWindowOverlay.xul; new revision: 184.108.40.206; previous revision: 220.127.116.11 messenger.xul; new revision: 18.104.22.168; previous revision: 22.214.171.124 msgMail3PaneWindow.js; new revision: 126.96.36.199; previous revision: 188.8.131.52 done
Attachment #223684 - Attachment description: Unbitrotted patch v0.1b → Unbitrotted patch v0.1b (Checked in trunk and 1.8 branch)
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Are there any expected user-visible effects of this patch, or is it strictly internal? Also: does bug 326814 still have pending changes, or should it be resolved?
(In reply to comment #7) > Are there any expected user-visible effects of this patch, or is it strictly > internal? > There should be no user-visible changes - if there are please let me know. > Also: does bug 326814 still have pending changes, or should it be resolved? > Yes, there is more work to happen on that bug when I get round to it.
You need to log in before you can comment on or make changes to this bug.