329544 - Port back mailnews improvements to dynamic 3-pane generation/decks

Status: RESOLVED FIXED

(Thunderbird :: Mail Window Front End, enhancement)

Description

[Ian Neal]

Bug 326814 for mailnews is hopefully introducing some improvements to dynamic 3-pane generation and decks, this bug will port them back to TB.

Comment 1

[Ian Neal]

Attachment: Provisonal patch v0.1

This patch:
* Moves manipulation of threadpane elements to threadpane functions from
accountcentral functions
* Rewrites comment for Thread Pane / Account Central
* Removes try from ObserveDisplayDeckChange
* Swaps order of elements in deck and moves setting of account central page to ShowAccountCentral

For more details see bug 326814

Comment 2

[Ian Neal]

Attachment: Revised patch v0.1a

Changes since v0.1:
* Took on fixes from bug 330198 for SM

Comment 3

[Scott MacGregor]

Ian, is this patch ready for a code review or are you still tweaking it?

Comment 4

[Ian Neal]

Attachment: Unbitrotted patch v0.1b (Checked in trunk and 1.8 branch)

Changes since v0.1a:
* Unbitrotted against current trunk

I've been testing this on and off but not spotted any problems yet.

Comment 5

[Scott MacGregor]

Comment on attachment 223684 [details] [diff] [review]
Unbitrotted patch v0.1b (Checked in trunk and 1.8 branch)

Thanks Iann.

Comment 6

[Ian Neal]

Comment on attachment 223684 [details] [diff] [review]
Unbitrotted patch v0.1b (Checked in trunk and 1.8 branch)

Checking in (trunk)
mailWindow.js;
new revision: 1.40; previous revision: 1.39
mailWindowOverlay.xul;
new revision: 1.145; previous revision: 1.144
messenger.xul;
new revision: 1.58; previous revision: 1.57
msgMail3PaneWindow.js;
new revision: 1.86; previous revision: 1.85
done
Checking in (1.8 branch)
mailWindow.js;
new revision: 1.32.2.8; previous revision: 1.32.2.7
mailWindowOverlay.xul;
new revision: 1.116.2.22; previous revision: 1.116.2.21
messenger.xul;
new revision: 1.49.2.8; previous revision: 1.49.2.7
msgMail3PaneWindow.js;
new revision: 1.70.2.17; previous revision: 1.70.2.16
done

Comment 7

[Mike Cowperthwaite]

Are there any expected user-visible effects of this patch, or is it strictly internal?

Also: does bug 326814 still have pending changes, or should it be resolved?

Comment 8

[Ian Neal]

(In reply to comment #7)
> Are there any expected user-visible effects of this patch, or is it strictly
> internal?
> 
There should be no user-visible changes - if there are please let me know.

> Also: does bug 326814 still have pending changes, or should it be resolved?
> 
Yes, there is more work to happen on that bug when I get round to it.