Closed Bug 329544 Opened 15 years ago Closed 15 years ago

Port back mailnews improvements to dynamic 3-pane generation/decks

Categories

(Thunderbird :: Mail Window Front End, enhancement)

enhancement
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird2.0

People

(Reporter: iann_bugzilla, Assigned: iann_bugzilla)

References

Details

(Keywords: fixed1.8.1)

Attachments

(1 file, 2 obsolete files)

Bug 326814 for mailnews is hopefully introducing some improvements to dynamic 3-pane generation and decks, this bug will port them back to TB.
Depends on: 326814
Attached patch Provisonal patch v0.1 (obsolete) — Splinter Review
This patch:
* Moves manipulation of threadpane elements to threadpane functions from
accountcentral functions
* Rewrites comment for Thread Pane / Account Central
* Removes try from ObserveDisplayDeckChange
* Swaps order of elements in deck and moves setting of account central page to ShowAccountCentral

For more details see bug 326814
Attached patch Revised patch v0.1a (obsolete) — Splinter Review
Changes since v0.1:
* Took on fixes from bug 330198 for SM
Attachment #214254 - Attachment is obsolete: true
Ian, is this patch ready for a code review or are you still tweaking it?
Changes since v0.1a:
* Unbitrotted against current trunk

I've been testing this on and off but not spotted any problems yet.
Attachment #215453 - Attachment is obsolete: true
Attachment #223684 - Flags: review?(mscott)
Comment on attachment 223684 [details] [diff] [review]
Unbitrotted patch v0.1b (Checked in trunk and 1.8 branch)

Thanks Iann.
Attachment #223684 - Flags: review?(mscott)
Attachment #223684 - Flags: review+
Attachment #223684 - Flags: approval-branch-1.8.1+
Attachment #223684 - Flags: superreview?(bienvenu)
Attachment #223684 - Flags: superreview?(bienvenu) → superreview+
Comment on attachment 223684 [details] [diff] [review]
Unbitrotted patch v0.1b (Checked in trunk and 1.8 branch)

Checking in (trunk)
mailWindow.js;
new revision: 1.40; previous revision: 1.39
mailWindowOverlay.xul;
new revision: 1.145; previous revision: 1.144
messenger.xul;
new revision: 1.58; previous revision: 1.57
msgMail3PaneWindow.js;
new revision: 1.86; previous revision: 1.85
done
Checking in (1.8 branch)
mailWindow.js;
new revision: 1.32.2.8; previous revision: 1.32.2.7
mailWindowOverlay.xul;
new revision: 1.116.2.22; previous revision: 1.116.2.21
messenger.xul;
new revision: 1.49.2.8; previous revision: 1.49.2.7
msgMail3PaneWindow.js;
new revision: 1.70.2.17; previous revision: 1.70.2.16
done
Attachment #223684 - Attachment description: Unbitrotted patch v0.1b → Unbitrotted patch v0.1b (Checked in trunk and 1.8 branch)
Status: NEW → RESOLVED
Closed: 15 years ago
Keywords: fixed1.8.1
Resolution: --- → FIXED
Are there any expected user-visible effects of this patch, or is it strictly internal?

Also: does bug 326814 still have pending changes, or should it be resolved?
(In reply to comment #7)
> Are there any expected user-visible effects of this patch, or is it strictly
> internal?
> 
There should be no user-visible changes - if there are please let me know.

> Also: does bug 326814 still have pending changes, or should it be resolved?
> 
Yes, there is more work to happen on that bug when I get round to it.
Depends on: 342441
Depends on: 351437
You need to log in before you can comment on or make changes to this bug.