Port back mailnews improvements to dynamic 3-pane generation/decks

RESOLVED FIXED in Thunderbird2.0

Status

--
enhancement
RESOLVED FIXED
13 years ago
12 years ago

People

(Reporter: iann_bugzilla, Assigned: iann_bugzilla)

Tracking

({fixed1.8.1})

Trunk
Thunderbird2.0
fixed1.8.1
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 2 obsolete attachments)

(Assignee)

Description

13 years ago
Bug 326814 for mailnews is hopefully introducing some improvements to dynamic 3-pane generation and decks, this bug will port them back to TB.
(Assignee)

Updated

13 years ago
Depends on: 326814
(Assignee)

Comment 1

13 years ago
Created attachment 214254 [details] [diff] [review]
Provisonal patch v0.1

This patch:
* Moves manipulation of threadpane elements to threadpane functions from
accountcentral functions
* Rewrites comment for Thread Pane / Account Central
* Removes try from ObserveDisplayDeckChange
* Swaps order of elements in deck and moves setting of account central page to ShowAccountCentral

For more details see bug 326814
(Assignee)

Comment 2

13 years ago
Created attachment 215453 [details] [diff] [review]
Revised patch v0.1a

Changes since v0.1:
* Took on fixes from bug 330198 for SM
Attachment #214254 - Attachment is obsolete: true

Comment 3

13 years ago
Ian, is this patch ready for a code review or are you still tweaking it?
(Assignee)

Comment 4

13 years ago
Created attachment 223684 [details] [diff] [review]
Unbitrotted patch v0.1b (Checked in trunk and 1.8 branch)

Changes since v0.1a:
* Unbitrotted against current trunk

I've been testing this on and off but not spotted any problems yet.
Attachment #215453 - Attachment is obsolete: true
Attachment #223684 - Flags: review?(mscott)

Comment 5

13 years ago
Comment on attachment 223684 [details] [diff] [review]
Unbitrotted patch v0.1b (Checked in trunk and 1.8 branch)

Thanks Iann.
Attachment #223684 - Flags: review?(mscott)
Attachment #223684 - Flags: review+
Attachment #223684 - Flags: approval-branch-1.8.1+
(Assignee)

Updated

13 years ago
Attachment #223684 - Flags: superreview?(bienvenu)

Updated

13 years ago
Attachment #223684 - Flags: superreview?(bienvenu) → superreview+
(Assignee)

Comment 6

13 years ago
Comment on attachment 223684 [details] [diff] [review]
Unbitrotted patch v0.1b (Checked in trunk and 1.8 branch)

Checking in (trunk)
mailWindow.js;
new revision: 1.40; previous revision: 1.39
mailWindowOverlay.xul;
new revision: 1.145; previous revision: 1.144
messenger.xul;
new revision: 1.58; previous revision: 1.57
msgMail3PaneWindow.js;
new revision: 1.86; previous revision: 1.85
done
Checking in (1.8 branch)
mailWindow.js;
new revision: 1.32.2.8; previous revision: 1.32.2.7
mailWindowOverlay.xul;
new revision: 1.116.2.22; previous revision: 1.116.2.21
messenger.xul;
new revision: 1.49.2.8; previous revision: 1.49.2.7
msgMail3PaneWindow.js;
new revision: 1.70.2.17; previous revision: 1.70.2.16
done
Attachment #223684 - Attachment description: Unbitrotted patch v0.1b → Unbitrotted patch v0.1b (Checked in trunk and 1.8 branch)
(Assignee)

Updated

13 years ago
Status: NEW → RESOLVED
Last Resolved: 13 years ago
Keywords: fixed1.8.1
Resolution: --- → FIXED

Comment 7

13 years ago
Are there any expected user-visible effects of this patch, or is it strictly internal?

Also: does bug 326814 still have pending changes, or should it be resolved?
(Assignee)

Comment 8

13 years ago
(In reply to comment #7)
> Are there any expected user-visible effects of this patch, or is it strictly
> internal?
> 
There should be no user-visible changes - if there are please let me know.

> Also: does bug 326814 still have pending changes, or should it be resolved?
> 
Yes, there is more work to happen on that bug when I get round to it.

Updated

13 years ago
Depends on: 342441

Updated

12 years ago
Depends on: 351437
You need to log in before you can comment on or make changes to this bug.