336231 - "Manage Search Engines..." in Search dropdown still has stale/incorrectly positioned tooltip

Status: RESOLVED FIXED

(Firefox :: Search, defect)

Description

[aja+bugzilla]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20060501 Minefield/3.0a1
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20060501 Minefield/3.0a1

After bug 311653, the "Manage Search Engines..." action in the Search dropdown still has a stale tooltip.

Reproducible: Always

Steps to Reproduce:
1. Activate Search dropdown
2. Select "Manage Search Engines..."
3. Notice the tooltip

Actual Results:  
stale tooltip (e.g. "Search Google") located top/left

Expected Results:  
Tooltip with text "Manage Search Engines..." near the selected action

Comment 1

[Peter van der Woude [:Peter6]]

Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9a1) Gecko/20060502 Minefield/3.0a1 ID:2006050207 [cairo]

confirmed

Comment 2

[mmortal03]

I see this in the new search box drop down.

You can put your mouse over any of the search dropdown menu engine options and it does this.

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8) Gecko/20060505 BonEcho/2.0a1 ID:2006050602

Comment 3

[mmortal03]

Was this fixed with Bug 311653?

Comment 4

[:Gavin Sharp [email: [e-mail]]]

no(In reply to comment #3)
> Was this fixed with Bug 311653?

no

Comment 5

[:Gavin Sharp [email: [e-mail]]]

(In reply to comment #4)
> no(In reply to comment #3)
> > Was this fixed with Bug 311653?
> no

But it was "fixed" on the branch with that bug's 1.8 branch patch (which removed all tooltips), so this shouldn't be an issue on the branch.

Comment 6

[:Gavin Sharp [email: [e-mail]]]

*** Bug 361258 has been marked as a duplicate of this bug. ***

Comment 7

[Hideo Oshima]

Works for me with latest trunk linux build.
Is this fixed?

Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9a8pre) Gecko/2007091519 Minefield/3.0a8pre

Comment 8

[:Gavin Sharp [email: [e-mail]]]

I can still reproduce in the latest Windows nightly.

Comment 9

[Jason Quinn]

Does not work for me on Linux. Tooltip says "Search using Google" for "Manage Search Engines...".

Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9b2)
Gecko/2007121016 Firefox/3.0b2

Comment 10

[:Gavin Sharp [email: [e-mail]]]

Jason, could you file a new bug, with steps to reproduce? Might be worth trying a newer build first.

Comment 11

[Peter van der Woude [:Peter6]]

(In reply to comment #10)
> Jason, could you file a new bug, with steps to reproduce? Might be worth trying
> a newer build first.
> 
Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9b3pre) Gecko/2008011008 Minefield/3.0b3pre ID:2008011008

repro:
open FF
Click on the [G] in the searchbar
hover over [Manage Search Engines]

result:
tooltip: Search using Google

Comment 12

[:Gavin Sharp [email: [e-mail]]]

Oh, right, that's this bug. Sorry for saying "file a new bug", I thought this bug was resolved for some reason.

Comment 13

[Vlado Valastiak [:wladow]]

Attachment: simple hack

Very simple hack - sets empty tooltiptext for this menuitem

Comment 14

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 299439 [details] [diff] [review]
simple hack

Hmm, good idea! :)

Can you put a comment explaining why we're using a blank tooltip here? Just a "<!-- XXX See bug 336231 -->" should do.

Comment 15

[Vlado Valastiak [:wladow]]

Attachment: patch for checkin

Comment 16

[Reed Loden [:reed]]

Checking in browser/components/search/content/search.xml;
/cvsroot/mozilla/browser/components/search/content/search.xml,v  <--  search.xml
new revision: 1.117; previous revision: 1.116
done

Comment 17

[David Baron :dbaron:]

I backed this out due to the following test failure in the browser mochitests:

FAIL - Exception thrown - TypeError: items[i].getAttribute is not a function -
chrome://mochikit/content/browser/browser/components/search/test/browser_405664.js

Looks like adding the comment isn't such a great idea, since it introduces a comment node!  I'd think maybe you want a node type check in that loop?  Or a comment using the XUL preprocessor?  Or some other type of check in the loop?  I'm sure a browser peer would know which is the best style to fix.

Comment 18

[:Gavin Sharp [email: [e-mail]]]

Ugh, that sucks. I'll just change it to use a preprocessor comment, having the comment in the processed source isn't all that important, and not worth adding runtime checks for this kind of thing.

Comment 19

[:Gavin Sharp [email: [e-mail]]]

Attachment: fixed patch

Comment 20

[:Gavin Sharp [email: [e-mail]]]

mozilla/browser/components/search/content/search.xml 	1.119

Filed bug 414642 on removing this workaround once bug 374288 is fixed.