337646 - Hang in blank entering secure site dialog after viewing cert for domain name mismatch

Status: RESOLVED FIXED

(Core Graveyard :: Widget: Mac, defect)

Description

[Tracy Walker [:tracy]]

This regressed between 2006-05-08-03 and 2006-05-09-09 builds of Bon Echo on Mac (both ppc and intel are affected)

steps to reproduce:
-ensure security.warn_entering_secure is set to *true*
(this gets turned off by default after the first https site visited)
-go to the url given: https://verisign.com
dialog:
-Click View Certificate
View Cert Window:
-Click Close
next dialog:
-Click OK

tested results:
a blank dialog slides out... we're hung.  force quit. or sometimes able to actually Firefox | Quit but then crash.

expected results:
Entering Securing Site warning appears and is dismissable.

work-around is to ensure security.warn_entering_secure is set to *false*  or don't view the cert.

note: I tested the regression window builds on the trunk. they don't show this bug.

Comment 1

[Mark Mentovai]

Sounds like my event handling changes.  I'll investigate.

Comment 2

[Mark Mentovai]

Event handling changes seem to be the trigger - I also see this in the 1.5.0.4rc3+ event handling test build at http://jackassofalltrades.com/tmp/firefox-1504rc3-332579v8-337199v4.dmg .  I also see this on the trunk now, probably following bug 338153.

Comment 3

[Mark Mentovai]

Looks like we're re-showing the last sheet on a kEventWindowActivated event oddly sent from inside HideSheetWindow.  I'm going to compare this to how we handled activation with WaitNextEvent.

Comment 4

[Eddie Maddox]

Perhaps I'm seeing the same:

Mac blue G3, OSX 10.3.9.latest-updates

Bon Echo A3

http://usfed.org/   (a financial institution site)

- login: a half dozen numerals
- password: whatever-you-wish
- next screen: it tries to transfer data from the site,
a blank "sheet" pops down, Hangs!

Ff 1.5.0.3 & 1.5.0.4.RC4 work.

Eddie Maddox

Comment 5

[Mark Mentovai]

OK, I see the problem.  ShowSheetWindow is being called multiple times to attach a sheet to the same top-level window.  In this case, it's the same sheet being attached twice in a row.  The first attachment is happening in nsMacWindow::Show, the second is happening when reentering nsMacWindow::Show on a kEventWindowActivated event caused by the first ShowSheetWindow call after hiding a parent sheet.  The solution to this bug is to only call ShowSheetWindow to attach a sheet, not if Show is called for a sheet that's already attached.

I'm marking this bug as dependent on bug 312586, because the patch I'm about to post depends on the more robust sheet support that bug 312586 provides.  (Bug 312586 fixes some similar problems.)

Comment 6

[Mark Mentovai]

*** Bug 339359 has been marked as a duplicate of this bug. ***

Comment 7

[Mark Mentovai]

Attachment: Patch (requires 312586)

This patch was prepared against the trunk, which already has the patch to bug 312586.  I intend to take that patch on the 1.8 branch as well.

Comment 8

[Mark Mentovai]

Checked in on trunk.

Comment 9

[Mark Mentovai]

Comment on attachment 223697 [details] [diff] [review]
Patch (requires 312586)

Will consolidate with 312586 checkin on branch once it's proven.

Comment 10

[Nick Fagerlund]

Mark, was this the same behavior that was causing 338501?

Comment 11

[Mark Mentovai]

*** Bug 338501 has been marked as a duplicate of this bug. ***

Comment 12

[Mark Mentovai]

Yes, I'll do some branch checkins shortly that will fix all sorts of sheet problems.

Comment 13

[Mark Mentovai]

Attachment: 1.8 branch version (includes 312586)

Checked in on MOZILLA_1_8_BRANCH.

Comment 14

[Eddie Maddox]

Still broken, but different now.

Nightly: firefox-2.0a3.en-US.mac.dmg  31-May-2006 16:28   17M
On: Mac blue G3, OSX 10.3.9.all-updates

URL: usfed.org (Financial institution.)

After giving my acct # and PW,
the next screen Hangs "Transferring data from ...". (Same.)
No sheet drops down. (Different.)
Page is all white. (Same.)

Cannot make BonEcho Stop the transfer,
nor Quit except via Force Quit. (All the same.)


Thank you,
Eddie Maddox

Comment 15

[LonelyBob]

Tested with Bon echo updated on 20060822 with Intel Mac OSX 10.4.7
No hang or crash observed. 

After following the steps in Description, Click OK, the Secure site warning is closed and Verisign webpage is downloaded and displayed.