340195 - Enable printing in Lightning

Status: VERIFIED FIXED

(Calendar :: Lightning Only, defect)

Description

[Joey Minta]

I started poking around in Lightning to get printing working.  Right now we're missing a couple of key ingredients.  For starters, we need to unify the view code, so that we have an easy way to get the current view.  Then we need to probably unify the selection too.

Note that both of these can be worked around with some simple if clauses, but we should really just get more of this code unified and then Do The Right Thing

Comment 1

[Matthew (lilmatt) Willis]

blocking0.3?

Filter bugspam out using maggieIsMyCat

Comment 2

[Joey Minta]

Attachment: make printDialog.js neutral

mvl loves printing so much, he gets this review.

This patch makes printDialog.js neutral with respect to the app that its used in.  That means it can't care about gCalendarWindow or view-deck.  To do this, I've added a helper function to get selected items regardless of whether we're in sunbird or lightning.

Comment 3

[Michiel van Leeuwen (email: mvl+moz@)]

Comment on attachment 231120 [details] [diff] [review]
make printDialog.js neutral

r=mvl

Comment 4

[Joey Minta]

We need to figure out the best way to integrate printing into the menubar in thunderbird.  The current proposal here is to add it to the Calendar menu, where import/export are.  dmose has also suggested tying into the normal Thunderbird print options.  Asking for UI-review prior to checkin, to get this sorted out.

Comment 5

[Dan Mosedale (:dmosedale, :dmose)]

Thunderbird already has Printing UI in the file menu.  Tb + Ltn are intended to behave like a single app, so we should use that.  As jminta pointed out, this probably depends on us getting our selection model sorted out.

Comment 6

[Stefan Sitter [:ssitter]]

(In reply to comment #5)
> Thunderbird already has Printing UI in the file menu.  Tb + Ltn
> are intended to behave like a single app, so we should use that.
> As jminta pointed out, this probably depends on us getting our
> selection model sorted out.

I suggest to just add an additional 'Print Calendar' menu item to the 'File' menu and use the same print dialog as in Sunbird for 0.3 release. 
This allows to enable and test printing in Lightning 0.3.

In future Lightning version - when the selection model is sorted out - we should look for a better integration in the Thunderbirds print model.

Comment 7

[Matthew (lilmatt) Willis]

(In reply to comment #2)
> Created an attachment (id=231120) [edit]
> make printDialog.js neutral

You'll also need to move radioGroupSelectItem out of applicationUtil.js and into calUtils.js, and remove applicationUtils.js from printDialog.xul.

Comment 8

[Sean McMurray]

I agree with dmose. It shouldn't be its own menu item. The File|Print command can launch a different dialog if it needs to, but printing should still go through File|Print.

(In reply to comment #6)
> I suggest to just add an additional 'Print Calendar' menu item to the 'File'
> menu and use the same print dialog as in Sunbird for 0.3 release.

Comment 9

[Matthew (lilmatt) Willis]

Added entity to lightning.dtd to get it in before string freeze

<!ENTITY lightning.toolbar.print.label       "Print Calendar…">

uir=dmose, rs=dmose

Comment 10

[Dan Mosedale (:dmosedale, :dmose)]

Nice to have, but in a pinch, we could live without.

Comment 11

[Matthew (lilmatt) Willis]

Attachment: adds printing using separate menuitem

This is similar to the patch of jminta's that you've already reviewed. Many of the changes in the original patch made it in as part of the printDialog rework or the select all work.

After speaking with dmose, we agreed that we can work to integrate this into Thunderbird's native Print command in a later bug.

This also needs a spinoff to clean up uses of radioGroupSelectItem and radioGroupIndexOf to use the versions in calendarUtils.js.

Comment 12

[Michiel van Leeuwen (email: mvl+moz@)]

Comment on attachment 244010 [details] [diff] [review]
adds printing using separate menuitem

r=mvl, but make sure you file followup bugs for the better integrated UI.

Comment 13

[Matthew (lilmatt) Willis]

Spinoffs:
 - bug 358805: radioGroupSelectItem/radioGroupIndexOf cleanup
 - bug 358803: better printing UI integration

Patch landed on MOZILLA_1_8_BRANCH and trunk.

-> FIXED