Closed Bug 340984 Opened 14 years ago Closed 14 years ago

strict warnings in calItemBase.js and calAlarmService.js

Categories

(Calendar :: Internal Components, defect, minor)

x86
All
defect
Not set
minor

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: ssitter, Assigned: ssitter)

Details

Attachments

(1 file)

JavaScript strict warnings in calItemBase.js and calAlarmService.js


Warning: trailing comma is not legal in ECMA-262 object initializers
Source File: file:///Y:/sb/dist/bin/components/calItemBase.js
Line: 470, Column: 4
Source Code:
    },

http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/calendar/base/src/calItemBase.js&rev=1.62&mark=469#453


Warning: variable duration hides argument
Source File: file:///Y:/sb/dist/bin/components/calAlarmService.js
Line: 196, Column: 12
Source Code:
        var duration = datetime.subtractDate(alarmTime);

http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/calendar/base/src/calAlarmService.js&rev=1.17&mark=196,197#180
Attached patch patchSplinter Review
(btw, this are the strict warnings that caused sunbird to fail in bug 340881)
Attachment #225024 - Flags: first-review?(jminta)
See also bug 307501
Comment on attachment 225024 [details] [diff] [review]
patch

Thanks. r=jminta
Attachment #225024 - Flags: first-review?(jminta) → first-review+
patch checked in.
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.