Closed
Bug 340984
Opened 19 years ago
Closed 19 years ago
strict warnings in calItemBase.js and calAlarmService.js
Categories
(Calendar :: Internal Components, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: ssitter, Assigned: ssitter)
Details
Attachments
(1 file)
|
2.29 KB,
patch
|
jminta
:
first-review+
|
Details | Diff | Splinter Review |
JavaScript strict warnings in calItemBase.js and calAlarmService.js
Warning: trailing comma is not legal in ECMA-262 object initializers
Source File: file:///Y:/sb/dist/bin/components/calItemBase.js
Line: 470, Column: 4
Source Code:
},
http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/calendar/base/src/calItemBase.js&rev=1.62&mark=469#453
Warning: variable duration hides argument
Source File: file:///Y:/sb/dist/bin/components/calAlarmService.js
Line: 196, Column: 12
Source Code:
var duration = datetime.subtractDate(alarmTime);
http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/calendar/base/src/calAlarmService.js&rev=1.17&mark=196,197#180
|
Assignee | |
Comment 1•19 years ago
|
||
(btw, this are the strict warnings that caused sunbird to fail in bug 340881)
Attachment #225024 -
Flags: first-review?(jminta)
|
||
Comment 2•19 years ago
|
||
See also bug 307501
|
|
||
Comment 3•19 years ago
|
||
Comment on attachment 225024 [details] [diff] [review]
patch
Thanks. r=jminta
Attachment #225024 -
Flags: first-review?(jminta) → first-review+
|
|
||
Comment 4•19 years ago
|
||
patch checked in.
Status: NEW → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•