Closed Bug 341283 Opened 14 years ago Closed 9 years ago

Can't install a microsummary generator if it has a non-absolute URL

Categories

(Firefox Graveyard :: Microsummaries, defect)

2.0 Branch
defect
Not set

Tracking

(Not tracked)

RESOLVED WONTFIX

People

(Reporter: ispiked, Unassigned)

References

Details

(Whiteboard: [microsummaries-feature-removal])

Attachments

(2 files)

Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8.1a3) Gecko/20060612 BonEcho/2.0a3

Steps to reproduce:
1. Download the two testcase files to the same directory.
2. Open testcase.html and click the install microsummary link.
2. Then go to Bookmarks > Add Bookmark and open the dropdown. 

Results:
The microsummary is not displayed in the dropdown.

Expected results:
Microsummary is available for use.

I'm also seeing the following error in the JS console:

Error: [Exception... "Component returned failure code: 0x804b000a [nsIIOService.newURI]"  nsresult: "0x804b000a (<unknown>)"  location: "JS frame :: file:///home/aguthrie/downloads/2006-06-12-04-mozilla1.8/components/nsSidebar.js :: anonymous :: line 185"  data: no]
Source File: file:///home/aguthrie/downloads/2006-06-12-04-mozilla1.8/components/nsSidebar.js
Line: 185

Myk had originally said he thought this had to do with file:/// URIs, but this happens when you upload stuff to a webserver, too.
Attached file testcase.html
Attached file testcase-generator.xml
To fix this, we probably have to make the addMicrosummaryGenerator method of the sidebar component interpret such URLs relative to the base URI of the page calling that method.  It's unclear how complicated or significant a change that is, so targeting this to Firefox 3 for now, but if we get a fix in the beta2 timeframe, and it looks like something we could take in that release, I'll retarget.
OS: Linux → All
Priority: -- → P1
Hardware: PC → All
Whiteboard: [myk: mss]
Target Milestone: --- → Firefox 3
Component: Bookmarks → Microsummaries
Whiteboard: [myk: mss]
The microsummary code in nsSidebar.js could probably just set the third arg of newURI() [to the page URI, instead of null], which looks like it should make relative URIs work.

I'm curious if the other sidebar services work with relative URIs...
Assignee: nobody → dolske
(In reply to comment #4)
> The microsummary code in nsSidebar.js could probably just set the third arg of
> newURI() [to the page URI, instead of null], which looks like it should make
> relative URIs work.

Except that nsSidebar.js has no way of knowing the "page URI". Bug 334875 provides such a way, it blocks some similar potential improvements to the search code (e.g. bug 340604).
Hmm, good point.

I've added a note to http://developer.mozilla.org/en/docs/Creating_a_Microsummary
Depends on: 334875
Whiteboard: [blocked]
QA Contact: bookmarks → microsummaries
Assignee: dolske → nobody
Priority: P1 → --
Target Milestone: Firefox 3 → ---
No longer depends on: 334875
- BUGSPAM -
Wontfixing all Microsummaries bugs, since the feature has been removed from the core product and previous versions won't get further fixes for it.
If interested in supporting Microsummaries in your add-on, you're free to use our old microsummaries code and to search all previously open bugs by looking for [microsummaries-feature-removal] in the status whiteboard field.
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → WONTFIX
Whiteboard: [blocked] → [microsummaries-feature-removal]
No longer depends on: 518929
Product: Firefox → Firefox Graveyard
You need to log in before you can comment on or make changes to this bug.