Closed Bug 342232 Opened 19 years ago Closed 19 years ago

Disable various menu items when window/tab contains binary content

Categories

(Camino Graveyard :: Toolbars & Menus, defect)

PowerPC
macOS
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Camino1.5

People

(Reporter: froodian, Assigned: stuart.morgan+bugzilla)

References

Details

(Keywords: fixed1.8.1.1)

Attachments

(1 file)

5.72 KB, patch
bugzilla-graveyard
: review+
mikepinkerton
: superreview+
Details | Diff | Splinter Review
As a followup to bug 309132, we should disable various other menu items when binary content is being displayed. Per IRC, this should be: Fill Form all the Finds Bigger/Smaller Text Text Encoding Copy and Select All
Blocks: 341853
No longer blocks: 341853
Depends on: 341853
by "binary content" you mean just an image, or full-window plugin?
Well, either one, really. Are there cases where, for instance, Bigger Text actually *works* on a plugin? cl
(In reply to comment #2) > Well, either one, really. Are there cases where, for instance, Bigger Text > actually *works* on a plugin? no.
Blocks: 341853
No longer depends on: 341853
Attached patch fixSplinter Review
Does everything above except select/copy, since those are valid things to do to, say, an image. (This doesn't do anything with Fill Form since I fixed that in an earlier validation.)
Assignee: bugzilla → stuart.morgan
Status: NEW → ASSIGNED
Attachment #243872 - Flags: review?
(In reply to comment #4) > Created an attachment (id=243872) [edit] > fix > > Does everything above except select/copy, since those are valid things to do > to, say, an image. Is there any way to differentiate between an image and plugin content? I'm not sure Select/Copy have meaning on PDF, Flash, or Java content, for instance. That'd be fine for a followup bug if we want to tackle that later. r=me otherwise, though. cl
For Flash (and probably Java, and maybe PDF forms?), Cut/Copy/Paste should be enabled; see bug 315824 and bug 315824 comment 8.
(In reply to comment #6) > For Flash (and probably Java, and maybe PDF forms?), Cut/Copy/Paste should be > enabled; see bug 315824 and bug 315824 comment 8. Right. Is there a way for the plugin to tell us whether clipboard actions are meaningful? In some Flash and Java (and PDF forms) it would be, and in most, it wouldn't. I guess that's sort of a plugin bug in that case, and as I said, I'm fine with this as-is. Plugin authors should do the Right Thing™ but I'm not holding my breath. cl
Attachment #243872 - Flags: review? → review+
Attachment #243872 - Flags: superreview?(mikepinkerton)
Attachment #243872 - Flags: superreview?(mikepinkerton) → superreview?(joshmoz)
Attachment #243872 - Flags: superreview?(joshmoz) → superreview+
Checked in on trunk and MOZILLA_1_8_BRANCH
Status: ASSIGNED → RESOLVED
Closed: 19 years ago
Keywords: fixed1.8.1.1
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: