Disable various menu items when window/tab contains binary content

RESOLVED FIXED in Camino1.5

Status

Camino Graveyard
Toolbars & Menus
RESOLVED FIXED
11 years ago
11 years ago

People

(Reporter: froodian (Ian Leue), Assigned: Stuart Morgan)

Tracking

({fixed1.8.1.1})

unspecified
Camino1.5
PowerPC
Mac OS X
fixed1.8.1.1

Details

Attachments

(1 attachment)

fix
5.72 KB, patch
Chris Lawson (gone)
: review+
Mike Pinkerton (not reading bugmail)
: superreview+
Details | Diff | Splinter Review
(Reporter)

Description

11 years ago
As a followup to bug 309132, we should disable various other menu items when binary content is being displayed.  Per IRC, this should be:

Fill Form
all the Finds
Bigger/Smaller Text
Text Encoding
Copy and Select All
(Reporter)

Updated

11 years ago
Blocks: 341853

Updated

11 years ago
No longer blocks: 341853

Updated

11 years ago
Depends on: 341853

Comment 1

11 years ago
by "binary content" you mean just an image, or full-window plugin?

Comment 2

11 years ago
Well, either one, really. Are there cases where, for instance, Bigger Text actually *works* on a plugin?

cl

Comment 3

11 years ago
(In reply to comment #2)
> Well, either one, really. Are there cases where, for instance, Bigger Text
> actually *works* on a plugin?

no.

Updated

11 years ago
Blocks: 341853
No longer depends on: 341853
(Assignee)

Comment 4

11 years ago
Created attachment 243872 [details] [diff] [review]
fix

Does everything above except select/copy, since those are valid things to do to, say, an image.  (This doesn't do anything with Fill Form since I fixed that in an earlier validation.)
Assignee: bugzilla → stuart.morgan
Status: NEW → ASSIGNED
Attachment #243872 - Flags: review?

Comment 5

11 years ago
(In reply to comment #4)
> Created an attachment (id=243872) [edit]
> fix
> 
> Does everything above except select/copy, since those are valid things to do
> to, say, an image.

Is there any way to differentiate between an image and plugin content? I'm not sure Select/Copy have meaning on PDF, Flash, or Java content, for instance. That'd be fine for a followup bug if we want to tackle that later.

r=me otherwise, though.

cl
For Flash (and probably Java, and maybe PDF forms?), Cut/Copy/Paste should be enabled; see bug 315824 and bug 315824 comment 8.

Comment 7

11 years ago
(In reply to comment #6)
> For Flash (and probably Java, and maybe PDF forms?), Cut/Copy/Paste should be
> enabled; see bug 315824 and bug 315824 comment 8.

Right. Is there a way for the plugin to tell us whether clipboard actions are meaningful? In some Flash and Java (and PDF forms) it would be, and in most, it wouldn't. I guess that's sort of a plugin bug in that case, and as I said, I'm fine with this as-is. Plugin authors should do the Right Thing™ but I'm not holding my breath.

cl

Updated

11 years ago
Attachment #243872 - Flags: review? → review+
(Assignee)

Updated

11 years ago
Attachment #243872 - Flags: superreview?(mikepinkerton)
(Assignee)

Updated

11 years ago
Attachment #243872 - Flags: superreview?(mikepinkerton) → superreview?(joshmoz)
Comment on attachment 243872 [details] [diff] [review]
fix

sr=pink
Attachment #243872 - Flags: superreview?(joshmoz) → superreview+
(Assignee)

Comment 9

11 years ago
Checked in on trunk and MOZILLA_1_8_BRANCH
Status: ASSIGNED → RESOLVED
Last Resolved: 11 years ago
Keywords: fixed1.8.1.1
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.