342232 - Disable various menu items when window/tab contains binary content

Status: RESOLVED FIXED

Description

[froodian (Ian Leue)]

As a followup to bug 309132, we should disable various other menu items when binary content is being displayed.  Per IRC, this should be:

Fill Form
all the Finds
Bigger/Smaller Text
Text Encoding
Copy and Select All

Comment 1

[Simon Fraser]

by "binary content" you mean just an image, or full-window plugin?

Comment 2

[Chris Lawson (gone)]

Well, either one, really. Are there cases where, for instance, Bigger Text actually *works* on a plugin?

cl

Comment 3

[Simon Fraser]

(In reply to comment #2)
> Well, either one, really. Are there cases where, for instance, Bigger Text
> actually *works* on a plugin?

no.

Comment 4

[Stuart Morgan]

Created attachment 243872 [details] [diff] [review]
fix

Does everything above except select/copy, since those are valid things to do to, say, an image.  (This doesn't do anything with Fill Form since I fixed that in an earlier validation.)

Comment 5

[Chris Lawson (gone)]

(In reply to comment #4)
> Created an attachment (id=243872) [edit]
> fix
> 
> Does everything above except select/copy, since those are valid things to do
> to, say, an image.

Is there any way to differentiate between an image and plugin content? I'm not sure Select/Copy have meaning on PDF, Flash, or Java content, for instance. That'd be fine for a followup bug if we want to tackle that later.

r=me otherwise, though.

cl

Comment 6

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

For Flash (and probably Java, and maybe PDF forms?), Cut/Copy/Paste should be enabled; see bug 315824 and bug 315824 comment 8.

Comment 7

[Chris Lawson (gone)]

(In reply to comment #6)
> For Flash (and probably Java, and maybe PDF forms?), Cut/Copy/Paste should be
> enabled; see bug 315824 and bug 315824 comment 8.

Right. Is there a way for the plugin to tell us whether clipboard actions are meaningful? In some Flash and Java (and PDF forms) it would be, and in most, it wouldn't. I guess that's sort of a plugin bug in that case, and as I said, I'm fine with this as-is. Plugin authors should do the Right Thing™ but I'm not holding my breath.

cl

Comment 8

[Mike Pinkerton (not reading bugmail)]

Comment on attachment 243872 [details] [diff] [review]
fix

sr=pink

Comment 9

[Stuart Morgan]

Checked in on trunk and MOZILLA_1_8_BRANCH