34651 - Pressing Cancel in file picker opens new window

Status: VERIFIED FIXED

(SeaMonkey :: UI Design, defect, P3)

Description

[Henrik Gemal]

Choose File -> Open File... choose cancel.
A new blank window will be opened.

Comment 1

[Mike Pinkerton (not reading bugmail)]

not a menu bug by any stretch of the imagination.

Comment 2

[sairuh (rarely reading bugmail)]

able to repro on winNT and mac. on mac, i was able to crash the browser, too.
not a problem on linux.

winNT, opt comm bits 2000.04.06.10
macOS, opt comm bits 2000.04.05.10 (today's not available)

didn't get talkback on mac, but will attach Macsbug trace info.

Comment 3

[sairuh (rarely reading bugmail)]

Attachment: Macsbug trace for crash

Comment 4

[Bill Law]

I'm going to try to reassign this to pavlov because I think it must have to do 
with some subtle difference between nsIFileSpecWithUI and nsIFilePicker (more 
likely, the underlying implementation of same on Mac).  I remember fixing 
similar bugs at least once before when nsIFileWidget return values changed.

Comment 5

[sairuh (rarely reading bugmail)]

*** Bug 34891 has been marked as a duplicate of this bug. ***

Comment 6

[Stuart Parmenter]

Attachment: patch to fix problem

Comment 7

[Stuart Parmenter]

can someone please review the patch I just posted here so that I can check it 
in.

Comment 8

[Stuart Parmenter]

checked in fix

Comment 9

[Bill Law]

*** Bug 35406 has been marked as a duplicate of this bug. ***

Comment 10

[sairuh (rarely reading bugmail)]

*** Bug 35069 has been marked as a duplicate of this bug. ***

Comment 11

[sairuh (rarely reading bugmail)]

looks fine on winNT and macOS [opt comm bits 2000.04.1109/10]. (double-checked
on linux too --behaves nicely there as well.)