347412 - [Winstripe] "Back" and "forward" toolbarbutton layout gets broken when using Icons and Text for the navigation toolbar

Status: VERIFIED FIXED

(Firefox :: Toolbars and Customization, defect, P1)

Description

[Régis Caspar]

When hovered, the "Back" and "Forward" toolbarbutton, a part of the arrow is raised. This part gets broken in two part when the navigation toolbar use Icons+Text

Will attach screenshot.

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1b1) Gecko/20060804 BonEcho/2.0b1 ID:2006080409

Comment 1

[Régis Caspar]

Attachment: screenshot

Comment 2

[Mike Connor [:mconnor]]

The XUL implementation of back/forward buttons means that this is tough to fix, taking to experiment a bit.

Comment 3

[Jackie Liu]

I nominate this to block Firefox 2.  

Comment 4

[dex_sf]

I can confirm this also for Macs. Maybe the OS of this bug, currently set to PC, should be changed?

Comment 5

[Mike Connor [:mconnor]]

So, this requires either of:

a) a theme specific mod to the toolbarbutton menu-button structure so that the label is below both
b) separate look and feel with text enabled (no fancy outline effect, pretty much the 1.5 solution when we have text enabled)

b) needs graphics, so if that's the solution, poke Jay ASAP.

Comment 6

[:Gavin Sharp [email: [e-mail]]]

*** Bug 348565 has been marked as a duplicate of this bug. ***

Comment 7

[:Gavin Sharp [email: [e-mail]]]

*** Bug 348916 has been marked as a duplicate of this bug. ***

Comment 8

[Asaf Romano (gone)]

Attachment: patch

Comment 9

[Mike Connor [:mconnor]]

Comment on attachment 234110 [details] [diff] [review]
patch

looks good, r+a=me for this theme-only patch

Comment 10

[Asaf Romano (gone)]

1.8 branch:
mozilla/browser/themes/winstripe/browser/browser.css 1.17.2.36
mozilla/browser/themes/winstripe/browser/browser.xml 1.4.8.2

I'll file a separate bug for Pinstripe.