Closed Bug 347412 Opened 18 years ago Closed 18 years ago

[Winstripe] "Back" and "forward" toolbarbutton layout gets broken when using Icons and Text for the navigation toolbar

Categories

(Firefox :: Toolbars and Customization, defect, P1)

Product:
Firefox
Component:
Toolbars and Customization
Version:
2.0 Branch
Platform:
x86
Windows XP
Type:
defect

Tracking

()

Status:
VERIFIED FIXED
Milestone:
Firefox 2 beta2

People

(Reporter: regis.caspar+bz, Assigned: asaf)

References

Details

(Keywords: verified1.8.1, Whiteboard: [Fx2 theme change])

Attachments

(2 files)

screenshot
58.45 KB, image/png
Details
patch
13.98 KB, patch
mconnor
: review+
mconnor
: approval1.8.1+
Details | Diff | Splinter Review 
When hovered, the "Back" and "Forward" toolbarbutton, a part of the arrow is raised. This part gets broken in two part when the navigation toolbar use Icons+Text

Will attach screenshot.

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1b1) Gecko/20060804 BonEcho/2.0b1 ID:2006080409
Attached image screenshot — 

    
    

    
  
The XUL implementation of back/forward buttons means that this is tough to fix, taking to experiment a bit.
Assignee: nobody → mconnor

    
    

    
  
I nominate this to block Firefox 2.  
Flags: blocking-firefox2?
Flags: blocking-firefox2? → blocking-firefox2+
Whiteboard: [Fx2 theme change]
Target Milestone: --- → Firefox 2 beta2

    
    

    
  
I can confirm this also for Macs. Maybe the OS of this bug, currently set to PC, should be changed?

    
    

    
  
So, this requires either of:

a) a theme specific mod to the toolbarbutton menu-button structure so that the label is below both
b) separate look and feel with text enabled (no fancy outline effect, pretty much the 1.5 solution when we have text enabled)

b) needs graphics, so if that's the solution, poke Jay ASAP.
Assignee: mconnor → bugs.mano
Summary: "Back" and "forward" toolbarbutton layout gets broken when using Icon+Text for the navigation toolbar → "Back" and "forward" toolbarbutton layout gets broken when using Icons and Text for the navigation toolbar

    
    

    
  
*** Bug 348565 has been marked as a duplicate of this bug. ***

    
    

    
  
*** Bug 348916 has been marked as a duplicate of this bug. ***

    
  
Status: NEW → ASSIGNED
Priority: -- → P1

    
    

    
  

      
      
      
      

        Attached patch
          
          
        patch
        — 
          — Splinter Review
      

    


  

        Attachment #234110 -
        Flags: review?(mconnor)

    
    

    
  
Comment on attachment 234110 [details] [diff] [review]
patch

looks good, r+a=me for this theme-only patch

        Attachment #234110 -
        Flags: review?(mconnor)

        Attachment #234110 -
        Flags: review+

        Attachment #234110 -
        Flags: approval1.8.1+

    
    

    
  
1.8 branch:
mozilla/browser/themes/winstripe/browser/browser.css 1.17.2.36
mozilla/browser/themes/winstripe/browser/browser.xml 1.4.8.2

I'll file a separate bug for Pinstripe.
Status: ASSIGNED → RESOLVED
Closed: 18 years ago
Keywords: fixed1.8.1
Resolution: --- → FIXED
Summary: "Back" and "forward" toolbarbutton layout gets broken when using Icons and Text for the navigation toolbar → [Winstripe] "Back" and "forward" toolbarbutton layout gets broken when using Icons and Text for the navigation toolbar
Status: RESOLVED → VERIFIED
Keywords: fixed1.8.1 → verified1.8.1

    
  
Depends on: 349148

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: