Closed
Bug 349148
Opened 18 years ago
Closed 18 years ago
Clicking Back / Forward button label opens dropdown instead of going back in "Icons and Text" mode
Categories
(Firefox :: Toolbars and Customization, defect, P1)
Tracking
()
RESOLVED
FIXED
Firefox 2
People
(Reporter: rdmsoft, Assigned: asaf)
References
Details
(Keywords: fixed1.8.1, Whiteboard: [Fx2 theme change])
Attachments
(1 file, 4 obsolete files)
|
10.50 KB,
patch
|
mconnor
:
review+
mconnor
:
approval1.8.1+
|
Details | Diff | Splinter Review |
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1b1) Gecko/20060817 BonEcho/2.0b1
In 1.5, the main non-dropmarker part of the back and forward buttons is a nice big target. In the latest nightly, clicking slightly too low pops up the menu instead, with no prior visual indication what will happen when I click.
|
||
Comment 1•18 years ago
|
||
nominate this for blocking the final release. This could become a problem for many people.
|
||
Comment 2•18 years ago
|
||
(In reply to comment #1)
> nominate this for blocking the final release. This could become a problem for
> many people.
If you want to nominate the bug to block, you need to set the blocking flag to "?"...
|
Assignee | |
Updated•18 years ago
|
Assignee: nobody → bugs.mano
OS: Windows XP → All
Hardware: PC → All
Target Milestone: --- → Firefox 2
|
|
Assignee | |
Updated•18 years ago
|
Status: NEW → ASSIGNED
Priority: -- → P1
|
|
||
Comment 3•18 years ago
|
||
Please add the Forward button to the summary too, it does the same for the forward label as it does the back label. Thank you.
|
|
Assignee | |
Updated•18 years ago
|
Summary: Clicking Back button label opens dropdown instead of going back in "Icons and Text" mode → Clicking Back / Forward button label opens dropdown instead of going back in "Icons and Text" mode
|
|
Assignee | |
Comment 4•18 years ago
|
||
Attachment #234899 -
Flags: review?(mconnor)
|
|
Assignee | |
Updated•18 years ago
|
Flags: blocking-firefox2?
|
|
Assignee | |
Comment 5•18 years ago
|
||
Attachment #234899 -
Attachment is obsolete: true
Attachment #234903 -
Flags: review?(mconnor)
Attachment #234899 -
Flags: review?(mconnor)
|
|
Assignee | |
Comment 6•18 years ago
|
||
Attachment #234903 -
Attachment is obsolete: true
Attachment #234905 -
Flags: review?(mconnor)
Attachment #234903 -
Flags: review?(mconnor)
|
|
Assignee | |
Updated•18 years ago
|
Attachment #234903 -
Attachment is obsolete: false
Attachment #234903 -
Flags: review?(mconnor)
|
|
Assignee | |
Comment 7•18 years ago
|
||
argh
Attachment #234905 -
Attachment is obsolete: true
Attachment #234907 -
Flags: review?(mconnor)
Attachment #234905 -
Flags: review?(mconnor)
|
|
Assignee | |
Updated•18 years ago
|
Attachment #234903 -
Attachment is obsolete: true
Attachment #234903 -
Flags: review?(mconnor)
|
|
Assignee | |
Updated•18 years ago
|
Attachment #234907 -
Attachment is obsolete: true
Attachment #234907 -
Flags: review?(mconnor)
|
||
Updated•18 years ago
|
Flags: blocking-firefox2? → blocking-firefox2+
|
|
Assignee | |
Comment 8•18 years ago
|
||
This works pretty well on win32 and OS X.
Thanks to gavin and phil for testing the patches here.
Attachment #234978 -
Flags: review?(mconnor)
|
|
Assignee | |
Comment 9•18 years ago
|
||
*** Bug 349744 has been marked as a duplicate of this bug. ***
No longer blocks: 349744
|
|
Assignee | |
Updated•18 years ago
|
Whiteboard: [needs review mconnor]
|
||
Updated•18 years ago
|
Whiteboard: [needs review mconnor] → [Fx2 theme change][needs review mconnor]
|
|
||
Comment 10•18 years ago
|
||
Comment on attachment 234978 [details] [diff] [review]
patch
looks good, r+a=me for this branch theme change
Attachment #234978 -
Flags: review?(mconnor)
Attachment #234978 -
Flags: review+
Attachment #234978 -
Flags: approval1.8.1+
|
|
Assignee | |
Comment 11•18 years ago
|
||
1.8 branch:
mozilla/browser/themes/pinstripe/browser/browser.css 1.11.4.31
mozilla/browser/themes/pinstripe/browser/browser.xml 1.3.12.2
mozilla/browser/themes/winstripe/browser/browser.css 1.17.2.41
mozilla/browser/themes/winstripe/browser/browser.xml 1.4.8.3
Status: ASSIGNED → RESOLVED
Closed: 18 years ago
Keywords: fixed1.8.1
Resolution: --- → FIXED
Whiteboard: [Fx2 theme change][needs review mconnor] → [Fx2 theme change]
|
||
Comment 12•18 years ago
|
||
Could this bug have screwed up the positioning of the back and forward buttons? They're now much higher than all other toolbar buttons in build: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1b2) Gecko/20060825 BonEcho/2.0b2 ID:2006082504 when showing icons only (small icons).
~B
|
|
||
Comment 13•18 years ago
|
||
(In reply to comment #12)
> Could this bug have screwed up the positioning of the back and forward buttons?
> They're now much higher than all other toolbar buttons in build: Mozilla/5.0
> (Windows; U; Windows NT 5.1; en-US; rv:1.8.1b2) Gecko/20060825 BonEcho/2.0b2
> ID:2006082504 when showing icons only (small icons).
>
> ~B
>
The patch fixed the problem, but left a regression. I would recomment filing a regression bug for this. Paste the bug number in here once you do. Thanks.
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1b2) Gecko/20060825 BonEcho/2.0b2 ID:2006082504
You need to log in
before you can comment on or make changes to this bug.
Description
•